[
https://issues.apache.org/jira/browse/JCLOUDS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611778#comment-16611778
]
Rami Hänninen commented on JCLOUDS-1447:
First, I would respectfully argue that
>can you think of any other providers that need to URL encode headers?
I'm mostly familiar with compute providers, and those don't use HTTP headers as
extensively as Blob storage providers, so I'd say we're fine.
@davidcurrie could you please add some unit tests to the
`RestAnnotationProcessorT
[
https://issues.apache.org/jira/browse/JCLOUDS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1447:
Priority: Major (was: Minor)
> S3 CopyObject requires x-amz-copy-source to be URL encode
davidcurrie commented on this pull request.
> @@ -408,6 +408,21 @@ public void testCopyObject() throws Exception {
}
}
+ String sourceKeyRequiringEncoding = "apples#?:$&'\"<>čॐ";
That was my natural inclination but I was following the pattern used for
`sourceKey` elsewhere in th
[
https://issues.apache.org/jira/browse/JCLOUDS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611813#comment-16611813
]
Ignasi Barrera commented on JCLOUDS-1447:
-
I agree with you [~rami.hanni...@doc
[
https://issues.apache.org/jira/browse/JCLOUDS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611822#comment-16611822
]
David Currie commented on JCLOUDS-1447:
---
I did have a search throughout jclouds f
@davidcurrie pushed 1 commit.
66d76bc Address review comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1238/files/360c0fbbd0eccae7138ed0d92c3af8a14184760b..66d76bce77225bb2b97d6ca9acfc6b5e965df544
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1238#pullrequestreview-154608939
Fixes an issue where Azure ARM resource groups are not deleted when a node is
destroyed. This fix resolves the following Jiras
https://issues.apache.org/jira/browse/JCLOUDS-1330
https://issues.apache.org/jira/browse/JCLOUDS-1331
You can view, comment on, or merge this pull request online at:
h
[
https://issues.apache.org/jira/browse/JCLOUDS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612287#comment-16612287
]
ASF subversion and git services commented on JCLOUDS-1447:
--
Co
[
https://issues.apache.org/jira/browse/JCLOUDS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612291#comment-16612291
]
ASF subversion and git services commented on JCLOUDS-1447:
--
Co
[
https://issues.apache.org/jira/browse/JCLOUDS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Gaul resolved JCLOUDS-1447.
--
Resolution: Fixed
Assignee: Andrew Gaul
Fix Version/s: 2.1.2
[
https://issues.apache.org/jira/browse/JCLOUDS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Gaul updated JCLOUDS-1447:
-
Priority: Minor (was: Major)
> S3 CopyObject requires x-amz-copy-source to be URL encoded
> --
[
https://issues.apache.org/jira/browse/JCLOUDS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612307#comment-16612307
]
Andrew Gaul edited comment on JCLOUDS-1447 at 9/12/18 3:14 PM:
--
[
https://issues.apache.org/jira/browse/JCLOUDS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612307#comment-16612307
]
Andrew Gaul commented on JCLOUDS-1447:
--
This behavior has existed since jclouds in
Reworded commit message, shuffled some code between commits, and pushed to
master as 5803de0f8ea0fef324b15c4a5a3a801ea7e505f6 and
7ebf12bf3867c7cdead772b8c80675c8a41bf7fa and 2.1.x as
8693687766380901057f1e69070723e7f708bede and
f74d1c0976538f343cd192c18b2fccf91eb22b57. Thank you for your cont
Closed #1238.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1238#event-1841442277
[
https://issues.apache.org/jira/browse/JCLOUDS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612450#comment-16612450
]
Rami Hänninen commented on JCLOUDS-1447:
I can agree on that the vast majority
[
https://issues.apache.org/jira/browse/JCLOUDS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612580#comment-16612580
]
Andrew Gaul commented on JCLOUDS-1447:
--
No one is arguing against fixing this issu
[
https://issues.apache.org/jira/browse/JCLOUDS-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612942#comment-16612942
]
Jia Zhai commented on JCLOUDS-1166:
---
Oh, sorry, seems I brought in some noisy github
20 matches
Mail list logo
