Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread jclouds-commentator
Go to http://70d990968f075210bd8a-9c548d37cb8b0242bf79fec2ca7da7fc.r52.cf5.rackcdn.com/ to review your changes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. ba16be9 JCLOUDS-1458 Create Dimension Data Provider Guide - handling code review comments. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + +{% highlight java %} +/* + * Deploy Network Domain to the Zone / Datacenter we wish to operate on. The response from this API is the Network Domain Identifier. + */ +String networkDomainId = api.getNetworkApi().deployNetworkDomain(AU9,

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread Ignasi Barrera
nacx commented on this pull request. > + +{% highlight java %} +/* + * Deploy Network Domain to the Zone / Datacenter we wish to operate on. The response from this API is the Network Domain Identifier. + */ +String networkDomainId = api.getNetworkApi().deployNetworkDomain(AU9,

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread jclouds-commentator
Go to http://9ca7d3582b9c98bb7831-da204afdf4a5179afae59121cbb46ec0.r0.cf5.rackcdn.com/ to review your changes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 2f7f11f JCLOUDS-1458 Create Dimension Data Provider Guide - correcting the artifact id. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > @@ -69,6 +69,11 @@ The Maven Group ID for all supported providers below is > [org.apache.jclouds.prov digitalocean + +Dimension Data* I think this is all that you require @nacx ? --

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-11 Thread Ignasi Barrera
merged to master as a145a8fd[](http://git-wip-us.apache.org/repos/asf/jclouds-examples/commit/a145a8fd). Thanks, @trevorflanagan! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-11 Thread Ignasi Barrera
Closed #94. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/94#event-1897728163

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-11 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/94#pullrequestreview-163731854

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-11 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. b3e54fb Example of Dimension Data CloudControl provider. Code review comments. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-11 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 2d46a4b Example of Dimension Data CloudControl provider. Code review comments. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-11 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 8bb536c Example of Dimension Data CloudControl provider. Code review comments. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread jclouds-commentator
Go to http://8a95420fbf433646c291-b5a21ac7a2034c81ca27936639187c4c.r64.cf5.rackcdn.com/ to review your changes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-11 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > @@ -21,7 +21,7 @@ 4.0.0 org.apache.jclouds.examples jclouds-examples - 2.1.0 + 2.2.0-SNAPSHOT Great thanks I wasnt sure what the correct approach was for the parent pom. -- You are receiving this because you are subscribed to this

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. b13ec1f JCLOUDS-1458 Create Dimension Data Provider Guide -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > +{% highlight java %} +/* + * Deploy Network Domain to the Zone / Datacenter we wish to operate on. The response from this API is the Network Domain Identifier. + */ +String networkDomainId =

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread Ignasi Barrera
Could you also add the provider in the providers page, and link to the guide? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/220#issuecomment-428854692

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread Ignasi Barrera
nacx commented on this pull request. > + +Dimension Data CloudControl allows for Tags to be applied to assets. There are two parts to the tagging process, first a tag key needs to be created, second the tag key is applied to an asset. + +Create a tag key. We will use this to tag the assets

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread Ignasi Barrera
nacx commented on this pull request. > +{% highlight java %} +/* + * Deploy Network Domain to the Zone / Datacenter we wish to operate on. The response from this API is the Network Domain Identifier. + */ +String networkDomainId =

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread jclouds-commentator
Go to http://0dbe6aa2010efbcebaa1-1c9655684642689b76e7e9f1381a1c37.r15.cf5.rackcdn.com/ to review your changes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. dfc01f0 JCLOUDS-1458 Create Dimension Data Provider Guide -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-11 Thread Ignasi Barrera
nacx commented on this pull request. Thanks for the fixes. Just some minor comments and it will be ready to be merged! > +``` +git clone https://github.com/jclouds/jclouds-examples.git +cd jclouds-examples/dimensiondata/ +``` + +To download all dependencies, run: + +``` +mvn

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread jclouds-commentator
Go to http://19e02f0e3cef44b5eb11-580d706b8c642fcfc10fe48652be90dc.r60.cf5.rackcdn.com/ to review your changes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-11 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. c43833b JCLOUDS-1458 Create Dimension Data Provider Guide -- You are receiving this because you are subscribed to this thread. View it on GitHub: