Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

Yes, the code works. To test the overall functionality, I have implemented a small test app, looking at your code here: https://jclouds.apache.org/guides/azure-storage/ . I just pass an SAS as a credential and run the app, which manipulates blobs and containers in my own azure subscription.

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

@ak58588 pushed 1 commit. fb1f7a94374bc91a33b5fbbc1e62f78ad49cff7d Update providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/AzureBlobRequestSigner.java -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

@ak58588 pushed 1 commit. 1f020cf2a670cecd7e338722c749f4e36ff6eefb Update providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/AzureBlobRequestSigner.java -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

@ak58588 pushed 1 commit. b435ebf978a74eda9f3fb5dd92500c819389b8be Update providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/AzureBlobRequestSigner.java -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

@ak58588 pushed 1 commit. 0aba5bd39c946c022ee7f9544e447215daaff13c Update providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/AzureBlobRequestSigner.java -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

@ak58588 pushed 1 commit. ebf52044672822d719c3613d0cb9b0c7a94fc83b Update providers/azureblob/src/main/java/org/jclouds/azure/storage/filters/SharedKeyLiteAuthentication.java -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

@ak58588 pushed 1 commit. 97c4152d133bb5a83e225da0444e0d1a1064b14c Update providers/azureblob/src/main/java/org/jclouds/azure/storage/filters/SharedKeyLiteAuthentication.java -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

gaul requested changes on this pull request. I still don't understand if this represent a work in progress or something that actually functions. How would I manually test this? Where are the unit and live tests which would eliminate the need for manual testing? > @@ -110,7 +172,27 @@

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

nacx commented on this pull request. > public HttpRequest filter(HttpRequest request) throws HttpException { + request = this.isSAS ? filterSAS(request, this.credential) : filterKey(request); + return request; ```suggestion utils.logRequest(signatureLog, request, "<<");

[GitHub] nacx merged pull request #1: Fixing issue in Dimension Data NetworkDomainTearDown

nacx merged pull request #1: Fixing issue in Dimension Data NetworkDomainTearDown URL: https://github.com/apache/jclouds-examples/pull/1 This is an automated message from the Apache Git Service. To respond to the message,

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

ak58588 commented on this pull request. > - + + /** + * this is the method to parse container name and blob name from the HttpRequest. + * applicable for the cases with SAS Authentication + * + */ + public String[] cutUri (URI uri) throws NullPointerException,

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

ak58588 commented on this pull request. > @@ -110,7 +175,27 @@ HttpRequest replaceDateHeader(HttpRequest request) { request = request.toBuilder().replaceHeaders(Multimaps.forMap(builder.build())).build(); return request; } - + + /** + * this is the method to parse

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

@ak58588 pushed 1 commit. 09aedcf6472ae9afc08ea4b6f00636be80bf38ad [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage - simplified filterSAS, if/else in filter -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[GitHub] trevorflanagan opened a new pull request #1: Fixing issue in Dimension Data NetworkDomainTearDown

trevorflanagan opened a new pull request #1: Fixing issue in Dimension Data NetworkDomainTearDown URL: https://github.com/apache/jclouds-examples/pull/1 Fixing issue where during the clear down all servers in a Datacenter get deleted instead of just the ones in the Network Domain.

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

@ak58588 pushed 1 commit. d4f63bfdcbf26c78d4fbf8f10305f5048697f3df [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage - simplified filterSAS, if/else in filter -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

@ak58588 pushed 1 commit. f8e73064545c2fc75ccebdc56d50d1a58731796a [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage - simplified filterSAS, if/else in filter -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

ak58588 commented on this pull request. > + } + utils.logRequest(signatureLog, request, "<<"); + return request; + } + + /** + * this filter method is applied only for the cases with SAS Authentication. + * + */ + public HttpRequest filterSAS(HttpRequest

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

ak58588 commented on this pull request. > public HttpRequest filter(HttpRequest request) throws HttpException { + if (this.isSAS){ + request = filterSAS(request, this.credential); + } else { + request = filterKey(request); + } Done! -- You are receiving

Jenkins build is still unstable: jclouds-with-credentials » jclouds-google-compute-engine-live-tests #13

See

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

@ak58588 pushed 1 commit. e757b2406b090915200abd81ff6a92ff22cc80db [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage - changed logic behind authSAS -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

nacx commented on this pull request. > + } + utils.logRequest(signatureLog, request, "<<"); + return request; + } + + /** + * this filter method is applied only for the cases with SAS Authentication. + * + */ + public HttpRequest filterSAS(HttpRequest request,

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

@ak58588 pushed 1 commit. 15437339d9c36df016e4779ef788904df24fb8cb Update providers/azureblob/src/main/java/org/jclouds/azure/storage/filters/SharedKeyLiteAuthentication.java -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

nacx requested changes on this pull request. Formatting is still an issue to merge the PR. Please format all your code to use a 3 space indent. > public HttpRequest filter(HttpRequest request) throws HttpException { + if (this.isSAS){ + request = filterSAS(request,

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

ak58588 commented on this pull request. > + } + + /** + * this filter method is applied only for the cases with SAS Authentication. + * + */ + public HttpRequest filterSAS(HttpRequest request, String credential) throws HttpException { + String containerName = null; +

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

ak58588 commented on this pull request. > + * + */ + public HttpRequest filterSAS(HttpRequest request, String credential) throws HttpException { + String containerName = null; + String blobName = null; + URI requestUri = request.getEndpoint(); + try { +

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

@ak58588 pushed 1 commit. 7c2be6f78899852f1718347482f9343665c3ebc2 Support for SAS token based Authentication for Azure Blob Storage - changed logic behind authSAS -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

ak58588 commented on this pull request. > private final HttpUtils utils; + private final URI storageUrl; + private boolean sasAuthentication; Done! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

ak58588 commented on this pull request. > + this.sasAuthentication = authSAS(this.credential); + if (this.sasAuthentication){ + request = filterSAS(request, this.credential); + } else { + request = filterKey(request); + } + utils.logRequest(signatureLog,

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

ak58588 commented on this pull request. > + + if (method.equals("PUT")) { + request.replaceHeader("x-ms-blob-type", "BlockBlob"); + } + + HttpRequest req = request.build(); + + return req; + } + + /** + * modified sign()

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

ak58588 commented on this pull request. > + request = filterSAS(request, this.credential); + } else { + request = filterKey(request); + } + utils.logRequest(signatureLog, request, "<<"); + return request; + } + + /** + * + * this method checks the

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

@ak58588 pushed 1 commit. 9f4416d956ec57a7b565920fbe405beac6c675be Support for SAS token based Authentication for Azure Blob Storage - changed logic behind authSAS -- You are receiving this because you are subscribed to this thread. View it on GitHub: