[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-11 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r804764637 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/AlertProperties.java ## @@ -0,0 +1,58 @@ +/* + *

[GitHub] [jclouds] nacx commented on pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-11 Thread GitBox
nacx commented on pull request #133: URL: https://github.com/apache/jclouds/pull/133#issuecomment-1035972414 Thanks @SATYANAN-ANAND! This is looking much better! >Is it possible to add any integration tests? As @gaul says, it is important to add the corresponding tests to this

[GitHub] [jclouds] gaul commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-11 Thread GitBox
gaul commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r804426723 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/options/AlertRequestOptions.java ## @@ -0,0 +1,268 @@ +/* + * Licensed to