Re: [jclouds/jclouds-labs] Azurecompute ARM - proper tests for disks (#394)

bostko commented on this pull request. > @@ -108,13 +113,15 @@ public String toString() { public static DataDisk create(final String name, final String diskSizeGB, final Integer lun, final VHD vhd, final VHD image, final String createOption, final String

Re: [jclouds/jclouds-labs] Azurecompute ARM - proper tests for disks (#394)

The problem which I was hitting without if I update disks section of a vm with : ```java DataDisk newDataDisk = DataDisk.builder().name("managed-disk") // .caching(DataDisk.CachingTypes.READ_WRITE) //. .build(); ``` and in request for updating

Re: [jclouds/jclouds-labs] Azurecompute ARM - proper tests for disks (#394)

Examples if someone wants to add tests for managed disks operations https://docs.microsoft.com/en-us/rest/api/manageddisks/disks/disks-create-or-update -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[jclouds/jclouds-labs] Azurecompute ARM - proper tests for disks (#394)

- Fix DataDisk.CachingTypes.fromValue to recognize values properly - Fix tests which had blob disks and managed disks at the same time - At this point managed disks are used by default and should be tested. You can view, comment on, or merge this pull request online at:

Re: [jclouds/jclouds-labs] Adding support for provisioning of Windows VMs with enabled WinRM (#393)

bostko commented on this pull request. > @@ -91,15 +90,52 @@ public static LinuxConfiguration create(final String > disablePasswordAuthenticati @AutoValue public abstract static class WinRM { + public enum Protocol { + + HTTP("http"), +

Re: [jclouds/jclouds-labs] Adding support for provisioning of Windows VMs with enabled WinRM (#393)

bostko commented on this pull request. > @@ -82,6 +87,20 @@ protected void tearDown() { } } + @BeforeClass + @Override + public void setup() { + super.setup(); + + // Providing system properties for specifying the required Azure KeyVault configurations for Live

Re: [jclouds/jclouds-labs] Adding support for provisioning of Windows VMs with enabled WinRM (#393)

bostko commented on this pull request. > @@ -91,15 +90,52 @@ public static LinuxConfiguration create(final String > disablePasswordAuthenticati @AutoValue public abstract static class WinRM { + public enum Protocol { + + HTTP("http"), +

Re: [jclouds/jclouds-labs] Azurecompute - additional templateOptions for WindowsProvisioningConfiguration (#371)

I prefer to put effort in supporting more windowsconfiguration parameters in the TemplateOptions rather than focusing on this bit. I'd like to pick this simple change in 2.0.x as well. Thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [jclouds/jclouds-labs] Azurecompute - additional templateOptions for WindowsProvisioningConfiguration (#371)

bostko commented on this pull request. > @@ -54,6 +54,7 @@ protected String networkSecurityGroupName; protected String reservedIPName; protected Boolean provisionGuestAgent; + protected Boolean winrmUseHttps; Thank you very much for the suggestion. Looks good however I am more

Re: [jclouds/jclouds-labs] Azurecompute - additional templateOptions for WindowsProvisioningConfiguration (#371)

mvn build seems to be successful however jenkins report it failed. ``` [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 5:23.302s [INFO] Finished at: Sat Mar 18 03:42:33 EDT 2017 ... [JENKINS] Archiving

[jclouds/jclouds-labs] Azurecompute - additional templateOptions for WindowsProvisioningConfiguration (#371)

Listener protocol flag allowing https usage. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/371 -- Commit Summary -- * Azurecompute (Classic) - additional templateOptions for WindowsProvisioningConfiguration -- File Changes --

Re: [jclouds/jclouds-labs-google] Support shortened hardwareId in GCE (#171)

Closed #171. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/171#event-872956603

[jclouds/jclouds-labs-google] GCE: Nullable selfLink in SerialPortOutput (#174)

You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs-google/pull/174 -- Commit Summary -- * GCE: Nullable selfLink in SerialPortOutput -- File Changes -- M

[jclouds/jclouds] GCE ResetWindowsPassword (#966)

- Function which tells to GCE to reset Windows password - InstanceApiLiveTest for windows - Unit test for decrypting windows password - fixed compile errors The initial pull request was done against 1.9.x https://github.com/jclouds/jclouds-labs-google/pull/170 You can view, comment on, or

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

@andreaturli thank you! I will make a PR against jclouds master tomorrow. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/170#issuecomment-223938034

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

@andreaturli ? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/170#issuecomment-223508179

[jclouds/jclouds] Test retrieving images (#964)

What I am opening is more an issue than a PR. Can you give me an idea what to try and how to fix this issue, thanks. AWSEC2ImageSupplierTest#testDescribeImagesParallel throws an exception on my local machine: ``` java.util.concurrent.ExecutionException:

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

Closed #170. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/170#event-661422284

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

Reopened #170. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/170#event-661422299

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

> @@ -73,7 +76,9 @@ public BaseGoogleComputeEngineApiLiveTest() { > } > > @Override protected GoogleComputeEngineApi create(Properties props, > Iterable modules) { > - Injector injector = > newBuilder().modules(modules).overrides(props).buildInjector(); > + //

Re: [jclouds/jclouds] [JCLOUDS-1108]: shorten hardwareId (#951)

Wouldn't be nice if you preserve the feature for setting hardwareUri somehow? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/951#issuecomment-216478138

Re: [jclouds/jclouds] [JCLOUDS-1108]: shorten hardwareId (#951)

> @@ -141,15 +146,16 @@ > >Scheduling scheduling = getScheduling(options); > > - NewInstance newInstance = new NewInstance.Builder( name, > -template.getHardware().getUri(), // machineType > -network, > -disks) > -.description(group)

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

> @@ -73,7 +76,9 @@ public BaseGoogleComputeEngineApiLiveTest() { > } > > @Override protected GoogleComputeEngineApi create(Properties props, > Iterable modules) { > - Injector injector = > newBuilder().modules(modules).overrides(props).buildInjector(); > + //

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

@nacx I saw your comment now. I did it :) There was problem cleaning up resources. I decided to move this live test into new class so the windows is not dependent on the centos instances used in the original `InstanceApiLiveTest` --- You are receiving this because you are subscribed to this

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

@nacx the live tests do not work now because it is loading the wrong crypto. It is loading `org.jclouds.encryption.internal.JCECrypto` instead of `org.jclouds.encryption.bouncycastle.BouncyCastleCrypto` How to tell the injector to use the correct one in tests? --- You are receiving this because

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

Testing. Do not merge yet. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/170#issuecomment-214756140

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

@nacx wdyt? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/170#issuecomment-214749017

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

> + private final Predicate operationDone; > + > + // FIXME do not use new except for tests > + @Inject > + public ResetWindowsPassword(GoogleComputeEngineApi api, Crypto crypto, > Predicate operationDone) { > + this.api = api; > + this.crypto =

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

> + * Generate a temporary key for encrypting and decrypting the password > + * Send the RSA public key to the instance, by settings its metadata > + * Retrieve the result from the {@link SerialPortOutput} > + * Decode and decrypt the result. > + * > + */ > +public class

Re: [jclouds/jclouds] GCE ResetWindowsPassword (#949)

Closed #949. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/949#event-641459771

Re: [jclouds/jclouds] GCE ResetWindowsPassword (#949)

This PR is already made for 1.9.x in https://github.com/jclouds/jclouds-labs-google/pull/170 I had to comment out GoogleComputeEngineServiceAdapter.java:145 to compile against master. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

[jclouds/jclouds] GCE ResetWindowsPassword (#949)

- Function which tells to GCE to reset Windows password - InstanceApiLiveTest for windows - Unit test for decrypting windows password - fixed compile errors You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/949 -- Commit Summary -- *

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

@aledsage @andreaturli @nacx can you review? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/170#issuecomment-214432611

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

> + public String call() { > + String serialPortContents = ""; > + Map passwordDict = ImmutableMap.of(); > + while (!serialPortContents.startsWith("{\"ready\":true") > || passwordDict.get("encryptedPassword") ==

Re: [jclouds/jclouds-labs-google] Support shortened hardwareId in GCE (#171)

`server.enqueue(jsonResponse("/project.json"));` doesn't seem to help for tests. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/171#issuecomment-209854321

Re: [jclouds/jclouds-labs-google] Support shortened hardwareId in GCE (#171)

@aledsage test failure is older and it is because of ProjectApiLiveTest.getProject() failing. I will look after lunch how I could plug in `MachineTypeToHardware` to transform the hardwareId. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or

[jclouds/jclouds-labs-google] Support shortened hardwareId in GCE (#171)

You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs-google/pull/171 -- Commit Summary -- * Support shortened hardwareId in GCE -- File Changes -- M

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

> @@ -173,6 +181,18 @@ >// Add lookup for InstanceToNodeMetadata >diskToSourceImage.put(instance.get().disks().get(0).source(), > template.getImage().getUri()); > > + boolean windows = options.autoCreateWindowsPassword() != null > + ?

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

> +Throwables.propagate(e); > + } > + serialPortContents = > instanceApi.getSerialPortOutput(instance.get().name(), 4).contents(); > + String[] contentEntries = > serialPortContents.split("\n"); > +

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

> + logger.debug("Generating windows key for instance %s, by updating > metadata", instance.get().name()); > + final InstanceApi instanceApi = api.instancesInZone(zone); > + Metadata metadata = instance.get().metadata(); > + // If disableHtmlEscaping is not there,

Re: [jclouds/jclouds-labs-google] Implementation of password setting for windows (#170)

> +Throwables.propagate(e); > + } > + serialPortContents = > instanceApi.getSerialPortOutput(instance.get().name(), 4).contents(); > + String[] contentEntries = > serialPortContents.split("\n"); > +

Re: [jclouds/jclouds-labs-google] Draft implementation of password setting for windows (#170)

> + GoogleComputeEngineApi api = createMock(GoogleComputeEngineApi.class); > + InstanceApi instanceApi = createMock(InstanceApi.class); > + Operation operation = createMock(Operation.class); > + SerialPortOutput serialPortOutput = createMock(SerialPortOutput.class); > +

[jclouds/jclouds-labs-google] Draft implementation of password setting for windows (#170)

Draft code for setting passwords on windows. - No If(Windows) check - Not clear whether the deployment will be completed at the end of GoogleComputeEngineServiceAdapter.createNodeWithGroupEncodedIntoName You can view, comment on, or merge this pull request online at: