rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1135#issuecomment-325364388
Modify `BaseComputeService` to have similar beahvior
/cc @nacx
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1135
-- Commit Summary --
* [JCLOUDS-1332] destroyNode and destroyNodesMatchingPredicate different
semantic
-- File Chang
Andrea Turli created JCLOUDS-1332:
-
Summary: BaseComputeService.destroyNodesMatching and
BaseComputeService.destroyNode different behavior
Key: JCLOUDS-1332
URL: https://issues.apache.org/jira/browse/JCLOUDS-1332
Merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/3a63007f)
and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/6d00302c)
Thanks @duncangrant
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or vie
Closed #409.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/409#event-1221021740
@andrewgaul do you think we should update also
https://github.com/jclouds/jclouds-karaf/blob/master/pom.xml#L199 if this PR
gets merged?
Mind adding a description for this to know the rationale behind it? Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to thi
merging
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/409#issuecomment-324841031
[
https://issues.apache.org/jira/browse/JCLOUDS-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140198#comment-16140198
]
Andrea Turli commented on JCLOUDS-1329:
---
Interesting point about the retry
lgtm, have you live tested?
I'd imagine you need it in master and 2.0.x branch, yes?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/409#issuecomment-324673899
[
https://issues.apache.org/jira/browse/JCLOUDS-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140106#comment-16140106
]
Andrea Turli edited comment on JCLOUDS-1329 at 8/24/17 2:4
[
https://issues.apache.org/jira/browse/JCLOUDS-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140106#comment-16140106
]
Andrea Turli commented on JCLOUDS-1329:
---
Thanks [~duncangrant]
Reading
h
hi @duncangrant thanks for that.
Could you please clarify the problem it is trying to solve? Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/409#issuecomment-324652819
I think you can build `jclouds-plugin` using that commit or you can use daily
builds as described at http://jclouds.apache.org/start/install/. HTH
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jc
merged at
[jclouds-labs/2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/e4e8da3a)
too
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322719383
good question @nacx I'll try to apply it to jclouds-labs 2.0.x as well
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322714368
Closed #1130.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#event-1207790833
Merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/e153322e)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1130#issuecomment-322691343
thanks @cpanato! Glad to know you guys are using (and fixing) packet.net
provider
Please keep up with the great work, merging now!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/113
Closed #1128.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1128#event-1198830638
[
https://issues.apache.org/jira/browse/JCLOUDS-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrea Turli resolved JCLOUDS-1323.
---
Resolution: Fixed
see https://github.com/jclouds/jclouds/pull/1128
> Openstack: secur
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/7c58f9d7)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1128#issuecomment-321216723
thanks @neykov, merging now
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1128#issuecomment-321200716
ok thanks guys, I've fixed an expected test, good to merge now?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1128#issuecomment-321174304
@andreaturli pushed 1 commit.
9d7f729 fix NovaComputeServiceExpectTest
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1128/files/69ded18e0f13f1b77d04d8d83225930561b11330..9d7f729be91d0973352ccbf758ccc30a38612001
andreaturli commented on this pull request.
> for (String securityGroupName : templateOptions.getGroups()) {
-
checkNotNull(novaApi.getSecurityGroupApi(region).get().get(securityGroupName),
"security group %s doesn't exist", securityGroupName);
+checkState(s
[
https://issues.apache.org/jira/browse/JCLOUDS-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115827#comment-16115827
]
Andrea Turli commented on JCLOUDS-1323:
---
https://github.com/jclouds/jclouds/
This patch is to validate the `templateOption.securityGroups` passed by the
user. It accepts `securityGroupNames` as it uses to be before
https://github.com/jclouds/jclouds/pull/1117 cc @neykov @nacx
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/j
[
https://issues.apache.org/jira/browse/JCLOUDS-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096329#comment-16096329
]
Andrea Turli commented on JCLOUDS-1323:
---
Thanks Svet, I meant to do it but
[
https://issues.apache.org/jira/browse/JCLOUDS-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrea Turli resolved JCLOUDS-1318.
---
Resolution: Fixed
> Security group created for the server is not dele
[
https://issues.apache.org/jira/browse/JCLOUDS-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrea Turli updated JCLOUDS-1318:
--
Flags: Important
Affects Version/s: 2.0.0
2.0.2
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/aa11765b)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#issuecomment-315709952
Closed #1117.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#event-1166125075
merging to master only
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#issuecomment-315707761
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#issuecomment-315703315
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#issuecomment-315703226
thanks @nacx let's wait for the builder as extra-check.
Meanwhile I'm rebasing and squashing
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#issuecomment-315695894
andreaturli commented on this pull request.
>
- boolean keyPairExtensionPresent =
novaApi.getKeyPairApi(region).isPresent();
+ List inboundPorts =
Ints.asList(templateOptions.getInboundPorts());
+ if (!templateOptions.getGroups().isEmpty() && !inboundPorts.isEmpty()) {
Ops, y
andreaturli commented on this pull request.
> }
+ } else if (templateOptions.getKeyPairName() != null &&
templateOptions.getLoginPrivateKey() != null) {
I was a bit unsure as well, I'll remove the extra check
--
You are receiving this because you are subscribed to this thread.
@andreaturli pushed 1 commit.
7080237 fix unit tests
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1117/files/861275890d57f1488b28984dea49cc57f4db872e..7080237a8a3c8b123e3910ea37b21bbc96a922c8
@nacx I think the build issue is related to the PR, need to understand why
*AdapterExpectTest is soo slow now, I guess it's because the refactoring
involves somehow the injector
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHu
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1117#issuecomment-315525532
@andreaturli pushed 1 commit.
1133ddc openstack nova re-adding support for existing keypair
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1117/files/69bcd5c36ee5c3ab83aa6a2922e4f9a75f3b7f57..1133ddc2dc1bdede6e933
andreaturli commented on this pull request.
>if (templateOptions.getKeyPairName() != null) {
options.keyPairName(templateOptions.getKeyPairName());
- KeyPair keyPair =
keyPairCache.getIfPresent(RegionAndName.fromRegionAndName(template.getLocation().getId(),
templateOp
andreaturli commented on this pull request.
> - .sharedNameForGroup(group)));
- keyPairCache.asMap().put(RegionAndName.fromRegionAndName(region,
keyPair.getName()), keyPair);
- templateOptions.keyPairName(keyPair.getName());
- tagsBuilder.add(JCLOUDS_KP)
Same here it is very surprising. I agree with @neykov the default should
probably be an isolated credentials store, and give the user the ability to
override if they really know what they are doing!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directl
@andreaturli pushed 1 commit.
848125a rename cleanupServer to cleanupResources
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1117/files/c1eacfc000239aff5b0070a6a0302d75294dc0e3..848125a39600e2d9e4d791e32b988b7366
andreaturli commented on this pull request.
> @@ -95,6 +101,7 @@ public Boolean apply(String id) {
}
boolean serverDeleted =
novaApi.getServerApi(regionAndId.getRegion()).delete(regionAndId.getId());
+ checkState(nodeTerminatedPredicate.apply(id), "server was not destroyed
andreaturli commented on this pull request.
> @@ -95,6 +101,7 @@ public Boolean apply(String id) {
}
boolean serverDeleted =
novaApi.getServerApi(regionAndId.getRegion()).delete(regionAndId.getId());
+ checkState(nodeTerminatedPredicate.apply(id), "server was not destroyed
[
https://issues.apache.org/jira/browse/JCLOUDS-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077934#comment-16077934
]
Andrea Turli commented on JCLOUDS-1318:
---
see https://github.com/jclouds/jcl
- wait for server deletion, before deleting the security group
I'd like this to be backported to 2.0.x as well
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1117
-- Commit Summary --
* [JCLOUDS-1318] fix based on nodeTerminatePredica
Andrea Turli created JCLOUDS-1318:
-
Summary: Security group created for the server is not deleted
Key: JCLOUDS-1318
URL: https://issues.apache.org/jira/browse/JCLOUDS-1318
Project: jclouds
[
https://issues.apache.org/jira/browse/JCLOUDS-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064638#comment-16064638
]
Andrea Turli commented on JCLOUDS-114:
--
hi [~zack-s], [~everett-toews],
I t
[
https://issues.apache.org/jira/browse/JCLOUDS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051956#comment-16051956
]
Andrea Turli commented on JCLOUDS-1308:
---
+1 for the NetworkExtension or a jcl
[
https://issues.apache.org/jira/browse/JCLOUDS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051887#comment-16051887
]
Andrea Turli commented on JCLOUDS-1308:
---
Interesting point [~graemem], I thin
[
https://issues.apache.org/jira/browse/JCLOUDS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050753#comment-16050753
]
Andrea Turli commented on JCLOUDS-1308:
---
I think jclouds should mimic as muc
lgtm, thanks @nacx
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/397#issuecomment-308673244
andreaturli commented on this pull request.
>
+ PublicKey userKey = readPublicKey(options.getPublicKey());
+ final String fingerprint = computeFingerprint(userKey);
+
+ synchronized (CreateSshKeysThenCreateNodes.class) {
+ boolean keyExists = api.sshKeyApi().list()
andreaturli commented on this pull request.
lgtm, some minor comments
also tested `PacketComputeServiceLiveTest` which look alright.
why only against `2.0.x`?
>
+ PublicKey userKey = readPublicKey(options.getPublicKey());
+ final String fingerprint = computeFingerprint(userKey);
+
lgtm +1
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1112#issuecomment-307474960
andreaturli commented on this pull request.
> - * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the Licen
andreaturli commented on this pull request.
> - * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the Licen
[
https://issues.apache.org/jira/browse/JCLOUDS-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrea Turli closed JCLOUDS-1306.
-
Resolution: Fixed
https://github.com/jclouds/jclouds/pull/1110
> [Openstack] Deleting a
Closed #1110.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1110#event-1116987982
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/1d4cb6c3) and
backported to
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/04ff09e6)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
h
thanks @neykov
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1110#issuecomment-307350491
thanks @neykov, merging now
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1110#issuecomment-307349569
previous failure looks unrelated, let's run the builder again before merging.
@neykov do you want this to be backported to 2.0.x as well?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pu
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1110#issuecomment-307338832
andreaturli approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1110#pullrequestreview-43104256
andreaturli commented on this pull request.
> @@ -191,14 +191,20 @@ public boolean removeSecurityGroup(String id) {
return false;
}
- if (sgApi.get().get(groupId) == null) {
- return false;
+ // Would be nice to delete the group and invalidate the cache atomi
andreaturli commented on this pull request.
> @@ -191,14 +191,20 @@ public boolean removeSecurityGroup(String id) {
return false;
}
- if (sgApi.get().get(groupId) == null) {
- return false;
+ // Would be nice to delete the group and invalidate the cache atomi
andreaturli requested changes on this pull request.
thanks @neykov, this looks useful, I've just some comments
> @@ -191,14 +191,20 @@ public boolean removeSecurityGroup(String id) {
return false;
}
- if (sgApi.get().get(groupId) == null) {
- return false;
+ /
lgtm
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/395#issuecomment-304713344
[
https://issues.apache.org/jira/browse/JCLOUDS-853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024900#comment-16024900
]
Andrea Turli commented on JCLOUDS-853:
--
I think we can close this one as jcl
[
https://issues.apache.org/jira/browse/JCLOUDS-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024903#comment-16024903
]
Andrea Turli commented on JCLOUDS-839:
--
I think we can close this one as jcl
[
https://issues.apache.org/jira/browse/JCLOUDS-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024902#comment-16024902
]
Andrea Turli commented on JCLOUDS-917:
--
I think we can close this one as jcl
[
https://issues.apache.org/jira/browse/JCLOUDS-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrea Turli resolved JCLOUDS-1303.
---
Resolution: Fixed
> Cannot create VM on Azure ARM m
andreaturli commented on this pull request.
thanks @ygy -- looks really useful
some comments from my quick review, haven't executed the live tests though
> +* Windows configuration parameters
+*
+* @see https://docs.microsoft.com/en-us/rest/api/compute/virtualmachines/virtualmachines
Thanks @nacx !
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1103#issuecomment-302890686
[
https://issues.apache.org/jira/browse/JCLOUDS-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017472#comment-16017472
]
Andrea Turli commented on JCLOUDS-1303:
---
thanks [~conor.daly] for reporting
[
https://issues.apache.org/jira/browse/JCLOUDS-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrea Turli reassigned JCLOUDS-1303:
-
Assignee: Andrea Turli
> Cannot create VM on Azure ARM m
andreaturli commented on this pull request.
> + @AutoValue.Builder
+ public abstract static class Builder {
+ public abstract Builder destinationCidrBlock(String
destinationCidrBlock);
+
+ public abstract Builder gatewayId(String gatewayId);
+
+ public abstract Builder state(
[
https://issues.apache.org/jira/browse/JCLOUDS-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017015#comment-16017015
]
Andrea Turli commented on JCLOUDS-1302:
---
@zreal let us know if we can help,
I think we should edit the FormSignerV2 as well
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1102#issuecomment-302394483
andreaturli commented on this pull request.
looks really useful as we discussed on IRC.
Some minor comments, but @geomacy your impl is even cleaner than expected using
the annotation.
Thanks!
> @@ -101,7 +105,25 @@
this.serviceAndRegion = serviceAndRegion;
}
- @Override public Ht
andreaturli commented on this pull request.
thanks @geomacy -- looks quite useful.
some minor comments + I'd like to test it myself a bit more
> + @AutoValue.Builder
+ public abstract static class Builder {
+ public abstract Builder destinationCidrBlock(String
destinationCidrBlock);
+
+
[
https://issues.apache.org/jira/browse/JCLOUDS-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012048#comment-16012048
]
Andrea Turli edited comment on JCLOUDS-1298 at 5/16/17 9:1
[
https://issues.apache.org/jira/browse/JCLOUDS-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012048#comment-16012048
]
Andrea Turli commented on JCLOUDS-1298:
---
Interesting! I wonder if we c
andreaturli commented on this pull request.
thanks @jawnclarke it is really good start, some minor comments from me.
I'd like to understand better if we could avoid a generic `Response` for the
`create*` operations although the DimensionDataCloudControlResponseUtils is
well tested and may be ok
[
https://issues.apache.org/jira/browse/JCLOUDS-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrea Turli resolved JCLOUDS-1269.
---
Resolution: Fixed
Assignee: Andrea Turli
Fix Version/s: 2.0.2
[
https://issues.apache.org/jira/browse/JCLOUDS-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997908#comment-15997908
]
Andrea Turli commented on JCLOUDS-1269:
---
Cool, thanks [~yanchev] for helping
[
https://issues.apache.org/jira/browse/JCLOUDS-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996966#comment-15996966
]
Andrea Turli commented on JCLOUDS-1269:
---
[~yanchev] does this commit solve
[
https://issues.apache.org/jira/browse/JCLOUDS-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996965#comment-15996965
]
Andrea Turli commented on JCLOUDS-1120:
---
[~rjanik] does this recent commit so
thanks @aledsage! merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/a9cc10c4) and
backported to
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/a9cc10c4)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or vi
Closed #1091.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1091#event-1069179931
@aledsage mind squash the commits into one so that I can merge it easily (as
both master and 2.0.x may want this, right?)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1091#issuecomm
@nacx unless you have other comments, I think we can merge that. Ok?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1091#issuecomment-299183808
andreaturli commented on this pull request.
> +
+ Set results =
securityGroupApi().describeSecurityGroupsInRegion(DEFAULT_REGION);
+ SecurityGroup result = Iterables.getOnlyElement(results);
+ assertEquals(result.getId(), "sg-1a2b3c4d");
+ assertEquals(result.getRegion(), "u
andreaturli commented on this pull request.
> +
+ Set results =
securityGroupApi().describeSecurityGroupsInRegion(DEFAULT_REGION);
+ SecurityGroup result = Iterables.getOnlyElement(results);
+ assertEquals(result.getId(), "sg-1a2b3c4d");
+ assertEquals(result.getRegion(), "u
think you need to rebase and then it should be good to merge
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/386#issuecomment-297854424
401 - 500 of 1680 matches
Mail list logo
