Great stuff!
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/250#issuecomment-201919534
> To me,
> `AzureComputeSecurityGroupExtensionLiveTest>BaseSecurityGroupExtensionLiveTest.testAddIpPermission`
> is the real problem as that code can't work IMHO (maybe that test always
> failed?)
This test requires a clean environment; your error in fact is
`Duplicate input endpoint name(s)
@andreaturli last time I have run the whole test suite (from the master
branch), few months ago, all tests were succeeding - starting with an almost
clean environment.
I haven't checked this lately, but IMO this PR should not be merged until at
least the same results are achieved.
---
Reply
@nacx If nothing has changed since my latest comment, there are still a couple
of relevant test failures
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/197#issuecomment-146432037
@andreaturli I believe `AzureComputeServiceLiveTest#testListSizes` is
essential, but if you could also try to investigate why
`AzureComputeServiceContextLiveTest#testLaunchNodes` is failing when run with
all other tests...
---
Reply to this email directly or view it on GitHub:
@andreaturli here is my fresh results:
```
Results :
Failed tests:
AzureComputeSecurityGroupExtensionLiveTestBaseSecurityGroupExtensionLiveTest.testAddIpPermission:144
» HttpResponse
AzureComputeServiceContextLiveTest.testLaunchNodes:76 » RunNodes error
running...
I've seen the changes and they seem ok.
I had to fix
```
src/test/java/org/jclouds/azurecompute/binders/DeploymentParamsToXMLTest.java
```
by changing
```
import autovalue.shaded.com.google.common.common.collect.ImmutableSet;
```
to
```
import com.google.common.collect.ImmutableSet;
```
I have these 3 tests failing:
```
[TestNG] Test
testAddIpPermission(org.jclouds.azurecompute.compute.extensions.AzureComputeSecurityGroupExtensionLiveTest)
failed.
[TestNG] Test testList(org.jclouds.azurecompute.features.DiskApiLiveTest)
failed.
[TestNG] Test
Hi @hsbhathiya, can you please make the format changes requested by @nacx?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/171#issuecomment-101271888
Thanks @hsbhathiya - @nacx can you take a look at #171?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/154#issuecomment-99098947
@hsbhathiya Could you rebase this, please?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/154#issuecomment-98983658
@hsbhathiya fine, let's proceed this way, then. Looking forward to have all
your changes onboard!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/157#issuecomment-94653508
Hi @hsbhathiya, could you rebase this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/157#issuecomment-94409434
```
Tests run: 98, Failures: 0, Errors: 0, Skipped: 2
[...]
[INFO] Total time: 01:24 h
```
Looks good! @nacx @andreaturli could you please review this PR?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/167#issuecomment-93259276
@nacx I've applied the patch from jclouds/jclouds#724, rebuilt there then
removed the workaround from here: everything is working, cool!
Shall I wait for that PR to be merged before removing the workaround here?
---
Reply to this email directly or view it on GitHub:
@nacx Everything working as expected: looking forward for this PR to get merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/724#issuecomment-90822263
@nacx Sure! I'll try to rebase ASAP, thx for all merges.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/156#issuecomment-90405749
Rebuild, please.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/153#issuecomment-88811282
@nacx I've carried out the refactoring suggested, please have a look.
FYI at the end I've removed completely the dependency on BouncyCastle.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/153#issuecomment-88778852
@nacx Last rebuilt was successful :-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/153#issuecomment-88836620
@nacx all comments should now be addressed; still waiting for confirmation on
[this
one](https://github.com/jclouds/jclouds-labs/pull/156#discussion_r27569236).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/156#issuecomment-88778434
@@ -89,6 +89,14 @@ public void copyTo(final TemplateOptions to) {
if (storageAccountType.isPresent()) {
eTo.storageAccountType(storageAccountType.get());
}
+
+ final LoginCredentials credentials = new LoginCredentials.Builder().
+
@fmartell can you take care of this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/152#issuecomment-88379786
@fmartelli can you take care of this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/151#issuecomment-88380048
+
+ public AzureTemplateBuilderLiveTest() {
+ super();
+
+ provider = azurecompute;
+ }
+
+ @Override
+ protected ProviderMetadata createProviderMetadata() {
+ synchronized (this) {
+ if (providerMeta == null) {
+providerMeta = new
@@ -89,6 +89,14 @@ public void copyTo(final TemplateOptions to) {
if (storageAccountType.isPresent()) {
eTo.storageAccountType(storageAccountType.get());
}
+
+ final LoginCredentials credentials = new LoginCredentials.Builder().
+
@@ -89,6 +89,14 @@ public void copyTo(final TemplateOptions to) {
if (storageAccountType.isPresent()) {
eTo.storageAccountType(storageAccountType.get());
}
+
+ final LoginCredentials credentials = new LoginCredentials.Builder().
+
+
+ public AzureTemplateBuilderLiveTest() {
+ super();
+
+ provider = azurecompute;
+ }
+
+ @Override
+ protected ProviderMetadata createProviderMetadata() {
+ synchronized (this) {
+ if (providerMeta == null) {
+providerMeta = new
@@ -56,6 +56,11 @@
version${project.parent.version}/version
/dependency
dependency
+ groupIdorg.apache.jclouds.driver/groupId
+ artifactIdjclouds-sshj/artifactId
+ version${project.parent.version}/version
Without `jclouds-sshj` I don't have classes like as
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/159
-- Commit Summary --
* [JCLOUDS-846] StorageAccountApi completed + mock and live tests
* [JCLOUDS-846] SubscriptionApiMockTest
-- File Changes --
A
@andreaturli @hsbhathiya your failures should be due to to a different choice
of default location (among our subscription and yours): as you can see from
last commit, I have now explicitly set the default test image location to West
Europe: could you please launch the live tests again? Don't
@hsbhathiya Good news then! Thanks for feedback.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/158#issuecomment-87701948
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/158
-- Commit Summary --
* [JCLOUDS-849] All tests are green
-- File Changes --
M
azurecompute/src/main/java/org/jclouds/azurecompute/AzureManagementApiMetadata.java
(7)
Thx for reviewing @nacx - the additional commit should address your review,
please let me know.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/150#issuecomment-83484020
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/156
-- Commit Summary --
* [JCLOUDS-850] Providing AzureTemplateBuilderLiveTest
-- File Changes --
M
... and private key
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/153
-- Commit Summary --
* [JCLOUDS-838] Introducing InMemoryKeyManager for PEM-encoded certificate
and private key
-- File Changes --
M
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/152
-- Commit Summary --
* [JCLOUDS-837] added service certificate support
-- File Changes --
M azurecompute/src/main/java/org/jclouds/azurecompute/AzureComputeApi.java
(9)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/150
-- Commit Summary --
* [JCLOUDS-841] AffinityGroups operations implemented
-- File Changes --
M azurecompute/src/main/java/org/jclouds/azurecompute/AzureComputeApi.java
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/151
-- Commit Summary --
* [JCLOUDS-842] provided support for traffic manager operations
-- File Changes --
M
@nacx I have just removed the offending commit from master and created a
dedicated branch with it (for future PR)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/148#issuecomment-78167128
The PR looks good to me. But I'm missing the storage api mock tests.
The intent of this PR was to fix the live test execution: we can address this
need in a future PR.
It can't be merged, though, because it contains the unrelated traffic manager
operations commit
You are right, @fmartelli
@andreaturli @nacx This commit introduces `A10` / `A11` in
`org.jclouds.azurecompute.domain.RoleSize.Type` and properly defaults to
`UNRECOGNIZED` for all enum types which provides that - by adding a static
`fromString` method.
---
Reply to this email directly or view it on GitHub:
@andreaturli, we normally get no errors at all; such failures look quite
strange, especially the first one which is very basic.
Could you please check if there is something strange with the checked sources
or your subscription data (a clean situation always helps).
---
Reply to this email
Hi @andreaturli, could you please provide the whole live execution log
(including command-line) and not just the tail? Thanks.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/148#issuecomment-77755377
Closing in the attempt to provide a more manageable PR complying with JClouds
policies.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/147#issuecomment-77331138
Functionally equivalent to #147 but with only two commits as required by
JClouds policies.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/148
-- Commit Summary --
* [JCLOUDS-664] Fixing live test execution
* White noise:
This PR is quite large because it was started when PR #135 was not merged yet.
The main purpose is to allow the successful execution of live tests with real
Azure subscription, and contains several fixes.
You can view, comment on, or merge this pull request online at:
Still working on this, I'll open new one once all live tests will be passing.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/137#issuecomment-76733323
Hi @eduardkoller,
shall this issue be closed as [this
e-mail](http://www.mail-archive.com/dev@jclouds.apache.org/msg05877.html)
suggests?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/132#issuecomment-75923393
This PR provides fix for running live tests on Azure.
Warning: some white noise (mostly formatting) is also included, but in separate
commit.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/137
-- Commit Summary --
*
50 matches
Mail list logo
