[GitHub] [jclouds] gaul commented on pull request #140: Bump bcprov-ext-jdk15on from 1.60 to 1.67 in /drivers/bouncycastle

2022-06-12 Thread GitBox
gaul commented on PR #140: URL: https://github.com/apache/jclouds/pull/140#issuecomment-1153114902 I have some vague recollection of Java version issues with newer versions of BouncyCastle. Maybe not an issue now that jclouds requires Java 8? -- This is an automated message from the

[GitHub] [jclouds] gaul merged pull request #143: JCLOUDS-1602: Upgrade to Jetty 9.4.46

2022-06-12 Thread GitBox
gaul merged PR #143: URL: https://github.com/apache/jclouds/pull/143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jclouds] gaul merged pull request #144: JCLOUDS-1603: Upgrade to Guava 31.1

2022-06-12 Thread GitBox
gaul merged PR #144: URL: https://github.com/apache/jclouds/pull/144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jclouds] gaul opened a new pull request, #143: JCLOUDS-1602: Upgrade to Jetty 9.4.46

2022-06-11 Thread GitBox
gaul opened a new pull request, #143: URL: https://github.com/apache/jclouds/pull/143 Remove BaseJettyTest which BaseMockWebServerTest superseded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [jclouds] gaul merged pull request #139: Bump logback-core from 1.1.2 to 1.2.9 in /project

2022-06-11 Thread GitBox
gaul merged PR #139: URL: https://github.com/apache/jclouds/pull/139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jclouds] gaul merged pull request #137: Bump httpclient from 4.3.6 to 4.5.13 in /drivers/apachehc

2022-06-11 Thread GitBox
gaul merged PR #137: URL: https://github.com/apache/jclouds/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jclouds] gaul merged pull request #138: Bump logback-classic from 1.1.2 to 1.2.0 in /project

2022-06-11 Thread GitBox
gaul merged PR #138: URL: https://github.com/apache/jclouds/pull/138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jclouds] gaul commented on pull request #141: Update README copyright dates and AzureBlob README

2022-05-03 Thread GitBox
gaul commented on PR #141: URL: https://github.com/apache/jclouds/pull/141#issuecomment-1116850436 Thank you for your contribution @ikky888! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [jclouds] gaul merged pull request #141: Update README copyright dates and AzureBlob README

2022-05-03 Thread GitBox
gaul merged PR #141: URL: https://github.com/apache/jclouds/pull/141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jclouds] nacx commented on a diff in pull request #142: Adding access key auth support for openstack V3

2022-05-03 Thread GitBox
nacx commented on code in PR #142: URL: https://github.com/apache/jclouds/pull/142#discussion_r864274336 ## apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v3/auth/V3AuthenticationApi.java: ## @@ -57,4 +60,10 @@ public interface V3AuthenticationApi extends

[GitHub] [jclouds] smarru commented on pull request #142: Adding access key auth support for openstack V3

2022-05-02 Thread GitBox
smarru commented on PR #142: URL: https://github.com/apache/jclouds/pull/142#issuecomment-1115144366 @gaul drawing your attention, can you please review and provide us feedback, we would like to use this in Apache Airavata -- This is an automated message from the Apache Git Service. To

[GitHub] [jclouds] DImuthuUpe opened a new pull request, #142: Adding access key auth support for openstack V3

2022-05-02 Thread GitBox
DImuthuUpe opened a new pull request, #142: URL: https://github.com/apache/jclouds/pull/142 Please refer to the discussion thread [1] [1] https://lists.apache.org/thread/2p7qc20rn19r3yhsfd63p3o3h587f7oh -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [jclouds-site] nacx merged pull request #21: Conform to the new privacy policy

2022-04-27 Thread GitBox
nacx merged PR #21: URL: https://github.com/apache/jclouds-site/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jclouds] dependabot[bot] opened a new pull request, #140: Bump bcprov-ext-jdk15on from 1.60 to 1.67 in /drivers/bouncycastle

2022-04-18 Thread GitBox
dependabot[bot] opened a new pull request, #140: URL: https://github.com/apache/jclouds/pull/140 Bumps [bcprov-ext-jdk15on](https://github.com/bcgit/bc-java) from 1.60 to 1.67. Changelog Sourced from

[GitHub] [jclouds] dependabot[bot] opened a new pull request, #138: Bump logback-classic from 1.1.2 to 1.2.0 in /project

2022-04-18 Thread GitBox
dependabot[bot] opened a new pull request, #138: URL: https://github.com/apache/jclouds/pull/138 Bumps logback-classic from 1.1.2 to 1.2.0. [![Dependabot compatibility

[GitHub] [jclouds] dependabot[bot] opened a new pull request, #139: Bump logback-core from 1.1.2 to 1.2.9 in /project

2022-04-18 Thread GitBox
dependabot[bot] opened a new pull request, #139: URL: https://github.com/apache/jclouds/pull/139 Bumps logback-core from 1.1.2 to 1.2.9. [![Dependabot compatibility

[GitHub] [jclouds] dependabot[bot] opened a new pull request, #137: Bump httpclient from 4.3.6 to 4.5.13 in /drivers/apachehc

2022-04-18 Thread GitBox
dependabot[bot] opened a new pull request, #137: URL: https://github.com/apache/jclouds/pull/137 Bumps httpclient from 4.3.6 to 4.5.13. [![Dependabot compatibility

[GitHub] [jclouds] radito3 closed pull request #89: JCLOUDS-1521: Remove need for content length when using multipart upload

2022-04-11 Thread GitBox
radito3 closed pull request #89: JCLOUDS-1521: Remove need for content length when using multipart upload URL: https://github.com/apache/jclouds/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [jclouds-site] gaul merged pull request #20: Add 2.5.0 to the menu and remove jclouds-labs links

2022-03-28 Thread GitBox
gaul merged pull request #20: URL: https://github.com/apache/jclouds-site/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jclouds-site] nacx opened a new pull request #20: Add 2.5.0 to the menu and remove jclouds-labs links

2022-03-28 Thread GitBox
nacx opened a new pull request #20: URL: https://github.com/apache/jclouds-site/pull/20 The jclouds-labs links are broken because we're no longer releasing labs artifacts. This PR removes those and adds the link to the 2.5.0 release notes to the dropdown menu in the nav bar. -- This

[GitHub] [jclouds] gaul commented on pull request #136: JCLOUDS-1599 - Add support for GLACIER_IR storage class

2022-03-08 Thread GitBox
gaul commented on pull request #136: URL: https://github.com/apache/jclouds/pull/136#issuecomment-1062412430 Thank you for your contribution @theswordsmahin! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [jclouds] gaul merged pull request #136: JCLOUDS-1599 - Add support for GLACIER_IR storage class

2022-03-08 Thread GitBox
gaul merged pull request #136: URL: https://github.com/apache/jclouds/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jclouds] theswordsmahin opened a new pull request #136: JCLOUDS-1599 - Add support for GLACIER_IR storage class

2022-03-08 Thread GitBox
theswordsmahin opened a new pull request #136: URL: https://github.com/apache/jclouds/pull/136 Add new `GLACIER_IR `enum to ObjectMetadata https://issues.apache.org/jira/browse/JCLOUDS-1599 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [jclouds] gaul commented on a change in pull request #135: Do not use empty system properties for endpoint

2022-03-07 Thread GitBox
gaul commented on a change in pull request #135: URL: https://github.com/apache/jclouds/pull/135#discussion_r820593576 ## File path: core/src/main/java/org/jclouds/ContextBuilder.java ## @@ -370,7 +371,11 @@ private Properties currentStateToUnexpandedProperties() {

[GitHub] [jclouds] timuralp commented on a change in pull request #135: Do not use empty system properties for endpoint

2022-03-06 Thread GitBox
timuralp commented on a change in pull request #135: URL: https://github.com/apache/jclouds/pull/135#discussion_r820367119 ## File path: core/src/main/java/org/jclouds/ContextBuilder.java ## @@ -370,7 +371,11 @@ private Properties currentStateToUnexpandedProperties() {

[GitHub] [jclouds] gaul commented on a change in pull request #135: Do not use empty system properties for endpoint

2022-03-06 Thread GitBox
gaul commented on a change in pull request #135: URL: https://github.com/apache/jclouds/pull/135#discussion_r820301900 ## File path: core/src/main/java/org/jclouds/ContextBuilder.java ## @@ -370,7 +371,11 @@ private Properties currentStateToUnexpandedProperties() {

[GitHub] [jclouds] timuralp commented on a change in pull request #135: Do not use empty system properties for endpoint

2022-03-06 Thread GitBox
timuralp commented on a change in pull request #135: URL: https://github.com/apache/jclouds/pull/135#discussion_r820248676 ## File path: core/src/main/java/org/jclouds/ContextBuilder.java ## @@ -370,7 +371,11 @@ private Properties currentStateToUnexpandedProperties() {

[GitHub] [jclouds] gaul commented on a change in pull request #135: Do not use empty system properties for endpoint

2022-03-05 Thread GitBox
gaul commented on a change in pull request #135: URL: https://github.com/apache/jclouds/pull/135#discussion_r820088521 ## File path: core/src/main/java/org/jclouds/ContextBuilder.java ## @@ -370,7 +371,11 @@ private Properties currentStateToUnexpandedProperties() {

[GitHub] [jclouds] timuralp opened a new pull request #135: Do not use empty system properties for endpoint

2022-03-03 Thread GitBox
timuralp opened a new pull request #135: URL: https://github.com/apache/jclouds/pull/135 When configuring the endpoint, jclouds should use the default endpoint value if an empty string is passed via system properties. -- This is an automated message from the Apache Git Service. To

[GitHub] [jclouds] gaul commented on pull request #130: JCLOUDS-1587 - S3 Blobstore: Support Bucket Configuration Options - Versioning, Lifecycle, Encryption

2022-02-25 Thread GitBox
gaul commented on pull request #130: URL: https://github.com/apache/jclouds/pull/130#issuecomment-1051717290 @jiffysrc can we make progress on this PR? I would like to release jclouds 2.5.0 next month and include this functionality. -- This is an automated message from the Apache Git

[GitHub] [jclouds] nacx merged pull request #134: JCLOUDS-1598: Support Metric Alert Operation

2022-02-25 Thread GitBox
nacx merged pull request #134: URL: https://github.com/apache/jclouds/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jclouds] SATYANAN-ANAND commented on pull request #134: JCLOUDS-1598: Support Metric Alert Operation

2022-02-24 Thread GitBox
SATYANAN-ANAND commented on pull request #134: URL: https://github.com/apache/jclouds/pull/134#issuecomment-1050607766 > Thanks, @SATYANAN-ANAND !! > > We need the Mock and Live tests to be implemented for the API before we can merge the PR. Could you add those? It would be great if

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #134: JCLOUDS-1598: Support Metric Alert Operation

2022-02-24 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #134: URL: https://github.com/apache/jclouds/pull/134#discussion_r814531400 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/MetricAlert.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to

[GitHub] [jclouds] nacx commented on a change in pull request #134: JCLOUDS-1598: Support Metric Alert Operation

2022-02-24 Thread GitBox
nacx commented on a change in pull request #134: URL: https://github.com/apache/jclouds/pull/134#discussion_r814502491 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/MetricAlert.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #134: JCLOUDS-1598: Support Metric Alert Operation

2022-02-24 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #134: URL: https://github.com/apache/jclouds/pull/134#discussion_r814497649 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/MetricAlert.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to

[GitHub] [jclouds] nacx commented on a change in pull request #134: JCLOUDS-1598: Support Metric Alert Operation

2022-02-24 Thread GitBox
nacx commented on a change in pull request #134: URL: https://github.com/apache/jclouds/pull/134#discussion_r814082149 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/MetricAlert.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the

[GitHub] [jclouds] SATYANAN-ANAND opened a new pull request #134: JCLOUDS-1598: Support Metric Alert Operation

2022-02-23 Thread GitBox
SATYANAN-ANAND opened a new pull request #134: URL: https://github.com/apache/jclouds/pull/134 Please find this PR for Metric Alert operations: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [jclouds] gaul merged pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-21 Thread GitBox
gaul merged pull request #133: URL: https://github.com/apache/jclouds/pull/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jclouds] gaul commented on pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-21 Thread GitBox
gaul commented on pull request #133: URL: https://github.com/apache/jclouds/pull/133#issuecomment-1046730554 Thank you for your contribution @SATYANAN-ANAND! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [jclouds] SATYANAN-ANAND edited a comment on pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-20 Thread GitBox
SATYANAN-ANAND edited a comment on pull request #133: URL: https://github.com/apache/jclouds/pull/133#issuecomment-1046553254 > This looks fine. But I believe that you need to rebase so we can merge. I have the rebased the SATYANAN-ANAND : master Branch. Please let me know your

[GitHub] [jclouds] SATYANAN-ANAND commented on pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-20 Thread GitBox
SATYANAN-ANAND commented on pull request #133: URL: https://github.com/apache/jclouds/pull/133#issuecomment-1046553254 > This looks fine. But I believe that you need to rebase so we can merge. I have the rebased the SATYANAN-ANAND : master Branch. Please let me know your coments. --

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-20 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r810839670 ## File path: providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/ActivityLogAlertApiMockTest.java ## @@ -0,0 +1,210 @@

[GitHub] [jclouds] gaul commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-19 Thread GitBox
gaul commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r810464608 ## File path: providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/ActivityLogAlertApiMockTest.java ## @@ -0,0 +1,210 @@ +/* + *

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-18 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r809948339 ## File path: providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/ActivityLogAlertApiMockTest.java ## @@ -0,0 +1,201 @@

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-18 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r809947989 ## File path: providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/AlertApiLiveTest.java ## @@ -0,0 +1,77 @@ +/* + *

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-18 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r809947264 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/features/AlertApi.java ## @@ -0,0 +1,85 @@ +/* + * Licensed to

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-18 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r809946885 ## File path: providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/ActivityLogAlertApiLiveTest.java ## @@ -0,0 +1,123 @@

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-18 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r809947120 ## File path: providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/ActivityLogAlertApiLiveTest.java ## @@ -0,0 +1,123 @@

[GitHub] [jclouds] nacx commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-18 Thread GitBox
nacx commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r809923369 ## File path: providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/AlertApiLiveTest.java ## @@ -0,0 +1,77 @@ +/* + * Licensed to

[GitHub] [jclouds] nacx commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-18 Thread GitBox
nacx commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r809922709 ## File path: providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/AlertApiLiveTest.java ## @@ -0,0 +1,77 @@ +/* + * Licensed to

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-18 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r809905369 ## File path: providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/AlertApiLiveTest.java ## @@ -0,0 +1,77 @@ +/* + *

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-18 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r809902015 ## File path: providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/AlertApiMockTest.java ## @@ -0,0 +1,122 @@ +/* + *

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-18 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r809900575 ## File path: providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/AlertApiLiveTest.java ## @@ -0,0 +1,77 @@ +/* + *

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-18 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r809900575 ## File path: providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/AlertApiLiveTest.java ## @@ -0,0 +1,77 @@ +/* + *

[GitHub] [jclouds] nacx commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-18 Thread GitBox
nacx commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r809781331 ## File path: providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/ActivityLogAlertApiMockTest.java ## @@ -0,0 +1,201 @@ +/* + *

[GitHub] [jclouds] SATYANAN-ANAND commented on pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-17 Thread GitBox
SATYANAN-ANAND commented on pull request #133: URL: https://github.com/apache/jclouds/pull/133#issuecomment-1043917016 > Is it possible to add any integration tests? ApiMockTest and ApiLiveTest added -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [jclouds] SATYANAN-ANAND closed pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-17 Thread GitBox
SATYANAN-ANAND closed pull request #133: URL: https://github.com/apache/jclouds/pull/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jclouds] SATYANAN-ANAND commented on pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-17 Thread GitBox
SATYANAN-ANAND commented on pull request #133: URL: https://github.com/apache/jclouds/pull/133#issuecomment-1043916202 > Is it possible to add any integration tests? ApiMockTest and ApiLiveTest added -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [jclouds] SATYANAN-ANAND commented on pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-17 Thread GitBox
SATYANAN-ANAND commented on pull request #133: URL: https://github.com/apache/jclouds/pull/133#issuecomment-1043189463 > Is there any way to integration test this? Added ActivityLogAlertApiMockTest.java ActivityLogAlertApiLiveTest.java AlertApiMockTest.java

[GitHub] [jclouds] SATYANAN-ANAND commented on pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-17 Thread GitBox
SATYANAN-ANAND commented on pull request #133: URL: https://github.com/apache/jclouds/pull/133#issuecomment-1043188067 > Thanks @SATYANAN-ANAND! This is looking much better! > > > Is it possible to add any integration tests? > > As @gaul says, it is important to add the

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-17 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r809268831 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/options/AlertRequestOptions.java ## @@ -0,0 +1,268 @@ +/* + *

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-11 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r804764637 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/AlertProperties.java ## @@ -0,0 +1,58 @@ +/* + *

[GitHub] [jclouds] nacx commented on pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-11 Thread GitBox
nacx commented on pull request #133: URL: https://github.com/apache/jclouds/pull/133#issuecomment-1035972414 Thanks @SATYANAN-ANAND! This is looking much better! >Is it possible to add any integration tests? As @gaul says, it is important to add the corresponding tests to this

[GitHub] [jclouds] gaul commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-11 Thread GitBox
gaul commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r804426723 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/options/AlertRequestOptions.java ## @@ -0,0 +1,268 @@ +/* + * Licensed to

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-10 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r803700442 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/ActionStatus.java ## @@ -0,0 +1,36 @@ +/* + * Licensed

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-10 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r803698029 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/AlertSummaryGroup.java ## @@ -0,0 +1,64 @@ +/* + *

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-10 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r803697362 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/features/AlertApi.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-10 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r803695797 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/Essentials.java ## @@ -0,0 +1,104 @@ +/* + * Licensed to

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-10 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r803695014 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/Essentials.java ## @@ -0,0 +1,104 @@ +/* + * Licensed to

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-08 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r801879741 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/Essentials.java ## @@ -0,0 +1,104 @@ +/* + * Licensed to

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-08 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r801868805 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/AlertProperties.java ## @@ -0,0 +1,58 @@ +/* + *

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-08 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r801868805 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/AlertProperties.java ## @@ -0,0 +1,58 @@ +/* + *

[GitHub] [jclouds] nacx commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-08 Thread GitBox
nacx commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r801695450 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/features/AlertApi.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the

[GitHub] [jclouds] gaul commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-08 Thread GitBox
gaul commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r801650689 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/AlertProperties.java ## @@ -0,0 +1,58 @@ +/* + * Licensed to the

[GitHub] [jclouds] gaul commented on a change in pull request #133: JCLOUDS-1597: Support for Alerts

2022-02-07 Thread GitBox
gaul commented on a change in pull request #133: URL: https://github.com/apache/jclouds/pull/133#discussion_r801171604 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/AlertRuleAnyOfOrLeafCondition.java ## @@ -0,0 +1,67 @@ +/* + *

[GitHub] [jclouds] gaul commented on a change in pull request #130: JCLOUDS-1587 - S3 Blobstore: Support Bucket Configuration Options - Versioning, Lifecycle, Encryption

2022-02-06 Thread GitBox
gaul commented on a change in pull request #130: URL: https://github.com/apache/jclouds/pull/130#discussion_r800174777 ## File path: blobstore/src/main/java/org/jclouds/blobstore/options/ListContainerOptions.java ## @@ -58,6 +59,12 @@ public ListContainerOptions() {

[GitHub] [jclouds] gaul commented on pull request #132: JCLOUDS-1596

2022-02-05 Thread GitBox
gaul commented on pull request #132: URL: https://github.com/apache/jclouds/pull/132#issuecomment-1030572860 Thank you for your contribution @SATYANAN-ANAND! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [jclouds] gaul merged pull request #132: JCLOUDS-1596

2022-02-05 Thread GitBox
gaul merged pull request #132: URL: https://github.com/apache/jclouds/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jclouds] SATYANAN-ANAND commented on pull request #132: JCLOUDS-1596

2022-02-03 Thread GitBox
SATYANAN-ANAND commented on pull request #132: URL: https://github.com/apache/jclouds/pull/132#issuecomment-1029061263 Any feedback/corrections on this implementation. Please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [jclouds] SATYANAN-ANAND commented on a change in pull request #132: JCLOUDS-1596

2022-02-01 Thread GitBox
SATYANAN-ANAND commented on a change in pull request #132: URL: https://github.com/apache/jclouds/pull/132#discussion_r796651249 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/AzureComputeApi.java ## @@ -54,244 +55,291 @@ import

[GitHub] [jclouds] gaul commented on a change in pull request #132: JCLOUDS-1596

2022-02-01 Thread GitBox
gaul commented on a change in pull request #132: URL: https://github.com/apache/jclouds/pull/132#discussion_r796564888 ## File path: providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/AzureComputeApi.java ## @@ -54,244 +55,291 @@ import

[GitHub] [jclouds] gaul commented on pull request #131: JCLOUDS-1595: Add URL encoding to string vals in ListBucketOptions.

2022-01-21 Thread GitBox
gaul commented on pull request #131: URL: https://github.com/apache/jclouds/pull/131#issuecomment-1019087029 Thanks for checking the double-quoting. Note that we only merge PRs against the master branch and do not plan further 2.4.x releases. -- This is an automated message from the

[GitHub] [jclouds] JimSermersheim commented on pull request #131: JCLOUDS-1595: Add URL encoding to string vals in ListBucketOptions.

2022-01-21 Thread GitBox
JimSermersheim commented on pull request #131: URL: https://github.com/apache/jclouds/pull/131#issuecomment-1019063815 Declined after discovering a case where values were already url encoded. The simplistic fix causes these values to be double-encoded. I'll probably submit again where the

[GitHub] [jclouds] JimSermersheim closed pull request #131: JCLOUDS-1595: Add URL encoding to string vals in ListBucketOptions.

2022-01-21 Thread GitBox
JimSermersheim closed pull request #131: URL: https://github.com/apache/jclouds/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jclouds] JimSermersheim opened a new pull request #131: JCLOUDS-1595: Add URL encoding to string vals in ListBucketOptions.

2022-01-21 Thread GitBox
JimSermersheim opened a new pull request #131: URL: https://github.com/apache/jclouds/pull/131 https://issues.apache.org/jira/browse/JCLOUDS-1595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [jclouds] jiffysrc commented on pull request #125: JCLOUDS-1587 S3 Blobstore: Support Bucket Configuration Options - Versioning, Lifecycle, Encryption

2022-01-12 Thread GitBox
jiffysrc commented on pull request #125: URL: https://github.com/apache/jclouds/pull/125#issuecomment-1011870469 Raised Separate PR for Bucket Configuration Options, Hence closing this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [jclouds] jiffysrc closed pull request #125: JCLOUDS-1587 S3 Blobstore: Support Bucket Configuration Options - Versioning, Lifecycle, Encryption

2022-01-12 Thread GitBox
jiffysrc closed pull request #125: URL: https://github.com/apache/jclouds/pull/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jclouds] jiffysrc opened a new pull request #130: JCLOUDS-1587 - S3 Blobstore: Support Bucket Configuration Options - Versioning, Lifecycle, Encryption

2022-01-12 Thread GitBox
jiffysrc opened a new pull request #130: URL: https://github.com/apache/jclouds/pull/130 Changes included in - https://issues.apache.org/jira/browse/JCLOUDS-1587 after removing noise changes. Support following features in jclouds s3 blobstore Configure the bucket for

[GitHub] [jclouds] jiffysrc commented on a change in pull request #125: JCLOUDS-1587 S3 Blobstore: Support Bucket Configuration Options - Versioning, Lifecycle, Encryption

2022-01-12 Thread GitBox
jiffysrc commented on a change in pull request #125: URL: https://github.com/apache/jclouds/pull/125#discussion_r783075639 ## File path: apis/s3/src/main/java/org/jclouds/s3/config/S3HttpApiModule.java ## @@ -184,7 +184,7 @@ protected void bindErrorHandlers() { }

[GitHub] [jclouds] gaul commented on pull request #129: JCLOUDS-1594: Allow overriding S3 signer

2022-01-12 Thread GitBox
gaul commented on pull request #129: URL: https://github.com/apache/jclouds/pull/129#issuecomment-1011042949 Seems to pass most integration test for s3 and aws-s3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [jclouds] gaul merged pull request #129: JCLOUDS-1594: Allow overriding S3 signer

2022-01-12 Thread GitBox
gaul merged pull request #129: URL: https://github.com/apache/jclouds/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jclouds] JnRouvignac closed pull request #102: Replace uses of AbstractFuture by CompletableFuture

2022-01-12 Thread GitBox
JnRouvignac closed pull request #102: URL: https://github.com/apache/jclouds/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jclouds] gaul commented on pull request #129: JCLOUDS-1594: Allow overriding S3 signer

2022-01-10 Thread GitBox
gaul commented on pull request #129: URL: https://github.com/apache/jclouds/pull/129#issuecomment-1009490963 @jiffysrc please test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [jclouds] gaul commented on a change in pull request #125: JCLOUDS-1587 S3 Blobstore: Support Bucket Configuration Options - Versioning, Lifecycle, Encryption

2022-01-10 Thread GitBox
gaul commented on a change in pull request #125: URL: https://github.com/apache/jclouds/pull/125#discussion_r781234023 ## File path: apis/s3/src/main/java/org/jclouds/s3/config/S3HttpApiModule.java ## @@ -184,7 +184,7 @@ protected void bindErrorHandlers() { }

[GitHub] [jclouds] gaul opened a new pull request #129: JCLOUDS-1594: Allow overriding S3 signer

2022-01-10 Thread GitBox
gaul opened a new pull request #129: URL: https://github.com/apache/jclouds/pull/129 Previously s3 always used v2 and aws-s3 always used v4. Now s3 defaults to v2 and can override to v4. Note that this does not change BlobRequestSigner. -- This is an automated message from the

[GitHub] [jclouds] gaul commented on a change in pull request #125: JCLOUDS-1587 S3 Blobstore: Support Bucket Configuration Options - Versioning, Lifecycle, Encryption

2022-01-10 Thread GitBox
gaul commented on a change in pull request #125: URL: https://github.com/apache/jclouds/pull/125#discussion_r781234023 ## File path: apis/s3/src/main/java/org/jclouds/s3/config/S3HttpApiModule.java ## @@ -184,7 +184,7 @@ protected void bindErrorHandlers() { }

[GitHub] [jclouds] nacx commented on a change in pull request #125: JCLOUDS-1587 S3 Blobstore: Support Bucket Configuration Options - Versioning, Lifecycle, Encryption

2022-01-10 Thread GitBox
nacx commented on a change in pull request #125: URL: https://github.com/apache/jclouds/pull/125#discussion_r780968370 ## File path: apis/s3/src/main/java/org/jclouds/s3/config/S3HttpApiModule.java ## @@ -184,7 +184,7 @@ protected void bindErrorHandlers() { }

[GitHub] [jclouds] jiffysrc commented on a change in pull request #125: JCLOUDS-1587 S3 Blobstore: Support Bucket Configuration Options - Versioning, Lifecycle, Encryption

2022-01-09 Thread GitBox
jiffysrc commented on a change in pull request #125: URL: https://github.com/apache/jclouds/pull/125#discussion_r780900083 ## File path: apis/s3/src/main/java/org/jclouds/s3/config/S3HttpApiModule.java ## @@ -184,7 +184,7 @@ protected void bindErrorHandlers() { }

[GitHub] [jclouds] jiffysrc commented on a change in pull request #125: JCLOUDS-1587 S3 Blobstore: Support Bucket Configuration Options - Versioning, Lifecycle, Encryption

2022-01-09 Thread GitBox
jiffysrc commented on a change in pull request #125: URL: https://github.com/apache/jclouds/pull/125#discussion_r780900083 ## File path: apis/s3/src/main/java/org/jclouds/s3/config/S3HttpApiModule.java ## @@ -184,7 +184,7 @@ protected void bindErrorHandlers() { }

[GitHub] [jclouds] gaul commented on a change in pull request #125: JCLOUDS-1587 S3 Blobstore: Support Bucket Configuration Options - Versioning, Lifecycle, Encryption

2021-12-31 Thread GitBox
gaul commented on a change in pull request #125: URL: https://github.com/apache/jclouds/pull/125#discussion_r776981746 ## File path: apis/s3/src/main/java/org/jclouds/s3/config/S3HttpApiModule.java ## @@ -184,7 +184,7 @@ protected void bindErrorHandlers() { }

<    1   2   3   4   5   6   7   8   9   10   >