nacx commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-715197168
So, the general idea of this is to move to the BND plugin (which I'm OK
with) and to address the issue of GSON unexported packages by exporting them
from our jclouds-core module.
geomacy commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-714704006
> Should I do a rebase and squash?
Just a suggestion, I think it's easier to follow the history and comments if
it is just left as-is. But I don't know what the conventions
ahgittin commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-714696642
Seems to me like this PR is introducing two significant changes:
* use `bnd` instead of `jclouds.osgi.{im,ex}port` maven properties
* change how `gson` is
gurkerl83 commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-712657957
Should I do a rebase and squash?
This is an automated message from the Apache Git Service.
To respond to the
gaul merged pull request #85:
URL: https://github.com/apache/jclouds/pull/85
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gurkerl83 commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-711096391
The work of this branch is ready for review.
There is an additional feature in the Apache JCloud Lab project waiting
which syncs the OSGi handling due to the shared Maven
gurkerl83 opened a new pull request #5:
URL: https://github.com/apache/jclouds-labs/pull/5
This project, the lab version of Apache JCloud, share the exact build
instructions as the primary Apache JCloud project with all its modules.
Apache JCloud is shifting its strategy in handling
gurkerl83 commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-711058485
@geomacy My assessment of whether the change is a critical change is as
follows.
The main area of concern is the way Apache JClouds is used within Apache
Brooklyn?
geomacy commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-708636833
hi all, just regarding Ignasi's
[comment](https://github.com/apache/jclouds/pull/78#issuecomment-650507931) and
Alex's
nacx commented on pull request #84:
URL: https://github.com/apache/jclouds/pull/84#issuecomment-708374713
>for now, only GET and HEAD requests will be rejected if they have a body.
But there is another validation that forced me to slightly modified the
production code: rejecting requests
korlov42 commented on pull request #84:
URL: https://github.com/apache/jclouds/pull/84#issuecomment-707714150
> Have you tried running against a real provider when overriding the
transport to OkHttp?
Unfortunately, I don't have possibility to test this on real-world
environment, so
gaul commented on pull request #84:
URL: https://github.com/apache/jclouds/pull/84#issuecomment-706513786
@korlov42 Thank you for taking on this large task! The change looks good.
How can we best test this so that we have confidence that it works? Have you
tried running against a real
korlov42 commented on pull request #84:
URL: https://github.com/apache/jclouds/pull/84#issuecomment-706498753
The IDEA decided to put changes of one particular file to another change
list, thus locally there is no problem, but these changes have missed in remote
repo.
gaul commented on pull request #84:
URL: https://github.com/apache/jclouds/pull/84#issuecomment-706448176
This now fails with a compile error:
```
/home/travis/build/apache/jclouds/providers/profitbricks/src/test/java/org/jclouds/profitbricks/features/ImageApiMockTest.java:20:
korlov42 commented on pull request #84:
URL: https://github.com/apache/jclouds/pull/84#issuecomment-706289116
@nacx, for now, only GET and HEAD requests will be rejected if they have a
body. But there is another validation that forced me to slightly modified the
production code: rejecting
gaul opened a new pull request #85:
URL: https://github.com/apache/jclouds/pull/85
Fixed via:
```
find -executable -not -type d -name \*.java -exec chmod -x {} \;
```
This is an automated message from the Apache
nacx commented on pull request #84:
URL: https://github.com/apache/jclouds/pull/84#issuecomment-706210284
I remember quite some time ago I had a look at OkHttp3, but found that some
of the APIs some providers have conflicted with validations in OkHttp3, such as
rejecting DELETE operations
gaul commented on pull request #84:
URL: https://github.com/apache/jclouds/pull/84#issuecomment-706185421
@korlov42 Can you look at the CI failure?
```
Caused by: java.lang.UnsupportedOperationException:
clientBuilder.sslSocketFactory(SSLSocketFactory) not supported on JDK 9+
gaul commented on pull request #71:
URL: https://github.com/apache/jclouds/pull/71#issuecomment-706114180
Superseded by #84.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
gaul closed pull request #71:
URL: https://github.com/apache/jclouds/pull/71
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gaul closed pull request #71:
URL: https://github.com/apache/jclouds/pull/71
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gaul commented on pull request #71:
URL: https://github.com/apache/jclouds/pull/71#issuecomment-706114180
Superseded by #84.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
korlov42 opened a new pull request #84:
URL: https://github.com/apache/jclouds/pull/84
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gurkerl83 commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-701197844
Thank you for checking the status of the Feature Branch, which has been
pushed into the background a bit because of other things.
The Feature Branch is not complete, the
gaul merged pull request #83:
URL: https://github.com/apache/jclouds/pull/83
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gaul commented on pull request #83:
URL: https://github.com/apache/jclouds/pull/83#issuecomment-699442040
> We may want to update our [jclouds-compat build
matrix](https://ci-builds.apache.org/job/JClouds/job/jclouds-compat/) to better
reflect what we support now.
Done.
gaul opened a new pull request #83:
URL: https://github.com/apache/jclouds/pull/83
Release notes:
https://github.com/google/guice/wiki/Guice423
This is an automated message from the Apache Git Service.
To respond to
gaul commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-699260926
@gurkerl83 @nacx Do we have a path forward on this PR? I would like to
include it in the next release.
This is an
nacx commented on pull request #82:
URL: https://github.com/apache/jclouds/pull/82#issuecomment-696127269
Cherry-picked to 2.2.x as well.
This is an automated message from the Apache Git Service.
To respond to the message,
nacx merged pull request #82:
URL: https://github.com/apache/jclouds/pull/82
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
nacx commented on pull request #82:
URL: https://github.com/apache/jclouds/pull/82#issuecomment-696127269
Cherry-picked to 2.2.x as well.
This is an automated message from the Apache Git Service.
To respond to the message,
nacx merged pull request #82:
URL: https://github.com/apache/jclouds/pull/82
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cstamas commented on a change in pull request #82:
URL: https://github.com/apache/jclouds/pull/82#discussion_r490751367
##
File path: apis/sts/src/test/java/org/jclouds/aws/util/AWSUtilsTest.java
##
@@ -88,6 +95,20 @@ public void testNoExceptionParsingTextPlain() {
nacx commented on a change in pull request #82:
URL: https://github.com/apache/jclouds/pull/82#discussion_r490171464
##
File path: apis/sts/src/test/java/org/jclouds/aws/util/AWSUtilsTest.java
##
@@ -88,6 +95,20 @@ public void testNoExceptionParsingTextPlain() {
cstamas commented on a change in pull request #82:
URL: https://github.com/apache/jclouds/pull/82#discussion_r489376596
##
File path: apis/sts/src/test/java/org/jclouds/aws/util/AWSUtilsTest.java
##
@@ -88,6 +95,20 @@ public void testNoExceptionParsingTextPlain() {
cstamas commented on a change in pull request #82:
URL: https://github.com/apache/jclouds/pull/82#discussion_r489376596
##
File path: apis/sts/src/test/java/org/jclouds/aws/util/AWSUtilsTest.java
##
@@ -88,6 +95,20 @@ public void testNoExceptionParsingTextPlain() {
nacx commented on a change in pull request #82:
URL: https://github.com/apache/jclouds/pull/82#discussion_r487221374
##
File path: apis/sts/src/test/java/org/jclouds/aws/util/AWSUtilsTest.java
##
@@ -88,6 +95,20 @@ public void testNoExceptionParsingTextPlain() {
nacx commented on a change in pull request #82:
URL: https://github.com/apache/jclouds/pull/82#discussion_r487221374
##
File path: apis/sts/src/test/java/org/jclouds/aws/util/AWSUtilsTest.java
##
@@ -88,6 +95,20 @@ public void testNoExceptionParsingTextPlain() {
nacx commented on a change in pull request #82:
URL: https://github.com/apache/jclouds/pull/82#discussion_r487221374
##
File path: apis/sts/src/test/java/org/jclouds/aws/util/AWSUtilsTest.java
##
@@ -88,6 +95,20 @@ public void testNoExceptionParsingTextPlain() {
nacx commented on a change in pull request #82:
URL: https://github.com/apache/jclouds/pull/82#discussion_r487221374
##
File path: apis/sts/src/test/java/org/jclouds/aws/util/AWSUtilsTest.java
##
@@ -88,6 +95,20 @@ public void testNoExceptionParsingTextPlain() {
cstamas opened a new pull request #82:
URL: https://github.com/apache/jclouds/pull/82
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gaul commented on pull request #75:
URL: https://github.com/apache/jclouds/pull/75#issuecomment-682237714
Probably a few months. We are still working on the OkHttp and gson
dependencies.
This is an automated message from
cdancy commented on pull request #75:
URL: https://github.com/apache/jclouds/pull/75#issuecomment-681975285
@gaul @nacx any chance we can get a new release with this fix?
This is an automated message from the Apache Git
demobox commented on pull request #15:
URL: https://github.com/apache/jclouds-site/pull/15#issuecomment-676845501
Thanks for taking a look, @gaul!
This is an automated message from the Apache Git Service.
To respond to the
demobox opened a new pull request #15:
URL: https://github.com/apache/jclouds-site/pull/15
builds.a.o -> ci-builds.a.o
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
gaul merged pull request #80:
URL: https://github.com/apache/jclouds/pull/80
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gaul merged pull request #81:
URL: https://github.com/apache/jclouds/pull/81
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gaul opened a new pull request #81:
URL: https://github.com/apache/jclouds/pull/81
Previously this allocated a byte array for every call.
This is an automated message from the Apache Git Service.
To respond to the message,
gaul opened a new pull request #80:
URL: https://github.com/apache/jclouds/pull/80
This avoids an unneeded call to `ByteStreams2.toByteArrayAndClose` in
`getBlob` for range requests and elides a large memory allocation.
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-654650576
> So, the idea is that the JClouds-core OSGi module can export the GSON
package we want instead of directly shipped by the GSON dependency itself?
Yes!
> Have
gurkerl83 commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-654650576
> So, the idea is that the JClouds-core OSGi module can export the GSON
package we want instead of directly shipped by the GSON dependency itself?
Yes!
> Have you
nacx commented on pull request #79:
URL: https://github.com/apache/jclouds/pull/79#issuecomment-653941854
Thanks! :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
nacx merged pull request #79:
URL: https://github.com/apache/jclouds/pull/79
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
nacx commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-653941801
So, the idea is that the jclouds-core OSGi module can export the son package
we want instead of having them directly exported by the gson dependency itself?
As long as that is enough
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-652886362
Hi, I would love some feedback about latest changes made in the last commit
about the handling of GSON, the provided approach and the change of strategy of
maintaining
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-652886362
Hi, I would love some feedback about latest changes made in the last commit
about the handling of GSON, the provided approach and the change of strategy of
maintaining
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-652886362
Hi, I would love some feedback about latest changes made in the last commit
about the handling of GSON, the provided approach and the change of strategy of
maintaining
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-652886362
Hi, I would love some feedback about latest changes made in the last commit
about the handling of GSON, the provided approach and the change of strategy of
maintaining
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-652886362
Hi, I would love some feedback about latest changes made in the last commit
about the handling of GSON, the provided approach and the change of strategy of
maintaining
gurkerl83 commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-652886362
Hi, I would love some feedback about latest changes made in the last commit
about the handling of GSON, the provided approach and the change of strategy of
maintaining OSGi
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-651885426
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
nacx commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-650507931
As @gaul said, I'm not against this PR either, but it is a breaking change
that can have significant impact. We know other projects are using our
OSGi/Karaf support (such as Apache
gaul commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-650440462
> In any case, this deserves a proper discussion in the jclouds dev/users
mailing lists so the community is aware of the impact of the change. It would
be great too, to trigger such a
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-650395849
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-650395849
The integration of OSGi into JClouds is really only superficial. Not OSGi
near component models like Declarative Services or Blueprint were chosen as CDI
but simply Guice.
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-650395849
The integration of OSGi into JClouds is really only superficial. Not OSGi
near component models like Declarative Services or Blueprint were chosen as CDI
but simply Guice.
gurkerl83 commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-650395849
The integration of OSGi into JClouds is really only superficial. Not OSGi
near component models like Declarative Services or Blueprint were chosen as CDI
but simply Guice.
JnRouvignac opened a new pull request #79:
URL: https://github.com/apache/jclouds/pull/79
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
JnRouvignac edited a comment on pull request #76:
URL: https://github.com/apache/jclouds/pull/76#issuecomment-650299955
No problem. Thank you for taking the time to review it!
I'll follow up with the another PR with the `!canAccess()` when this one is
merged.
nacx commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-650318652
So, with the last update, this PR reverts back to the official gson library,
which makes jclouds incompatible with OSGi.
As mentioned in the different JIRA issues, we need to
nacx merged pull request #76:
URL: https://github.com/apache/jclouds/pull/76
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
nacx commented on pull request #76:
URL: https://github.com/apache/jclouds/pull/76#issuecomment-650315218
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
JnRouvignac commented on pull request #76:
URL: https://github.com/apache/jclouds/pull/76#issuecomment-650299955
No problem. Thank you for taking the time to review it!
I'll follow up with the another Pr with the `!canAccess()` when this one is
merged.
JnRouvignac commented on a change in pull request #76:
URL: https://github.com/apache/jclouds/pull/76#discussion_r446048154
##
File path: core/src/main/java/org/jclouds/reflect/Reflection2.java
##
@@ -153,15 +153,23 @@
.newBuilder().build(new CacheLoader, Set>>() {
nacx commented on a change in pull request #76:
URL: https://github.com/apache/jclouds/pull/76#discussion_r446095291
##
File path: core/src/main/java/org/jclouds/reflect/Reflection2.java
##
@@ -153,15 +153,23 @@
.newBuilder().build(new CacheLoader, Set>>() {
JnRouvignac commented on a change in pull request #76:
URL: https://github.com/apache/jclouds/pull/76#discussion_r446048154
##
File path: core/src/main/java/org/jclouds/reflect/Reflection2.java
##
@@ -153,15 +153,23 @@
.newBuilder().build(new CacheLoader, Set>>() {
demobox commented on a change in pull request #76:
URL: https://github.com/apache/jclouds/pull/76#discussion_r445884200
##
File path: core/src/main/java/org/jclouds/reflect/Reflection2.java
##
@@ -153,15 +153,23 @@
.newBuilder().build(new CacheLoader, Set>>() {
demobox commented on a change in pull request #76:
URL: https://github.com/apache/jclouds/pull/76#discussion_r445884200
##
File path: core/src/main/java/org/jclouds/reflect/Reflection2.java
##
@@ -153,15 +153,23 @@
.newBuilder().build(new CacheLoader, Set>>() {
JnRouvignac commented on a change in pull request #76:
URL: https://github.com/apache/jclouds/pull/76#discussion_r445868817
##
File path: core/src/main/java/org/jclouds/reflect/Reflection2.java
##
@@ -153,15 +153,23 @@
.newBuilder().build(new CacheLoader, Set>>() {
JnRouvignac commented on a change in pull request #76:
URL: https://github.com/apache/jclouds/pull/76#discussion_r445865014
##
File path: core/src/main/java/org/jclouds/reflect/Reflection2.java
##
@@ -153,15 +153,23 @@
.newBuilder().build(new CacheLoader, Set>>() {
gurkerl83 commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-649727007
All done, can you please review again, thx!
This is an automated message from the Apache Git Service.
To respond
gurkerl83 commented on a change in pull request #78:
URL: https://github.com/apache/jclouds/pull/78#discussion_r445691911
##
File path: project/pom.xml
##
@@ -86,6 +86,16 @@
+
+ gitlab-maven
+ https://gitlab.com/api/v4/projects/19575612/packages/maven
gurkerl83 commented on a change in pull request #78:
URL: https://github.com/apache/jclouds/pull/78#discussion_r445691911
##
File path: project/pom.xml
##
@@ -86,6 +86,16 @@
+
+ gitlab-maven
+ https://gitlab.com/api/v4/projects/19575612/packages/maven
nacx commented on a change in pull request #78:
URL: https://github.com/apache/jclouds/pull/78#discussion_r445662552
##
File path: project/pom.xml
##
@@ -86,6 +86,16 @@
+
+ gitlab-maven
+ https://gitlab.com/api/v4/projects/19575612/packages/maven
nacx commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-649639166
I think this is not correct. The project depends on pulling a dependency
from a specific repository, otherwise, it will break.
The main issue here is releasing under the same
nacx commented on a change in pull request #76:
URL: https://github.com/apache/jclouds/pull/76#discussion_r445645864
##
File path: core/src/main/java/org/jclouds/reflect/Reflection2.java
##
@@ -153,15 +153,23 @@
.newBuilder().build(new CacheLoader, Set>>() {
gaul commented on a change in pull request #78:
URL: https://github.com/apache/jclouds/pull/78#discussion_r445582853
##
File path: project/pom.xml
##
@@ -86,6 +86,16 @@
+
+ gitlab-maven
+ https://gitlab.com/api/v4/projects/19575612/packages/maven
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-649557100
This is the first in a series of merge requests, which tries to mitigate the
somewhat difficult behavior when dealing with OSGi incompatible libraries.
Basically GSON is
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-649557100
This is the first in a series of merge requests, which tries to mitigate the
somewhat difficult behavior when dealing with OSGi incompatible libraries.
Basically GSON is
gurkerl83 commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-649557100
This is the first in a series of merge requests, which tries to mitigate the
somewhat difficult behavior when dealing with OSGi incompatible libraries.
Basically GSON is
gurkerl83 opened a new pull request #78:
URL: https://github.com/apache/jclouds/pull/78
Replace substituted GSON package names with those provided from the vendor.
Reduce OSGi-metadata declaration of core-module because the artificial
package org.jclouds.json.gson.internal was removed.
gaul commented on pull request #71:
URL: https://github.com/apache/jclouds/pull/71#issuecomment-649156109
Never mind -- I was using an older version of OkHttp, 2.7.5. Let me work
forward...
This is an automated message
gaul commented on pull request #71:
URL: https://github.com/apache/jclouds/pull/71#issuecomment-649148516
I looked into this a little further. OkHttp uses bcprov-jdk15on 1.65 but
aligning our version doesn't resolve the symptoms.
gaul merged pull request #77:
URL: https://github.com/apache/jclouds/pull/77
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gaul merged pull request #75:
URL: https://github.com/apache/jclouds/pull/75
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ottenhoff opened a new pull request #77:
URL: https://github.com/apache/jclouds/pull/77
To solve the following stacktrace:
`java.lang.IllegalArgumentException: No enum constant
org.jclouds.s3.domain.ObjectMetadata.StorageClass.INTELLIGENT_TIERING
at
nacx commented on pull request #75:
URL: https://github.com/apache/jclouds/pull/75#issuecomment-649026516
Nope, LGTM. Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
gaul commented on pull request #75:
URL: https://github.com/apache/jclouds/pull/75#issuecomment-648842815
@nacx Any further comments?
This is an automated message from the Apache Git Service.
To respond to the message,
JnRouvignac opened a new pull request #76:
URL: https://github.com/apache/jclouds/pull/76
With Java 11, an illegal reflective access is output for the google cloud
storage blobstore.
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective
gaul commented on pull request #75:
URL: https://github.com/apache/jclouds/pull/75#issuecomment-644772816
> Hello, we use your JClouds in our OSGi project. Actually OSGi and all the
regulations around packet exports is a difficult topic. Especially when an OSGi
compatibility is set by a
501 - 600 of 1083 matches
Mail list logo
