[jira] [Commented] (JCLOUDS-1428) Support for SAS token based Authentication for Azure Blob Storage

2019-03-31 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806226#comment-16806226 ] Ignasi Barrera commented on JCLOUDS-1428: - It is called [here|h

Re: [jclouds/jclouds-labs] JCLOUDS-1407 Add dimensiondata server API v2.7 supportServer API 2.7 support (#447)

2019-03-31 Thread Ignasi Barrera
Thanks. The last comments I posted seem to not be addressed yet. Can you take care of them, and also squash the commits into a single one for a clean merge? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/

[jira] [Commented] (JCLOUDS-693) Support OpenStack Orchestration (Heat) API

2019-03-19 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795789#comment-16795789 ] Ignasi Barrera commented on JCLOUDS-693: That looks good. Since the param

[jira] [Commented] (JCLOUDS-693) Support OpenStack Orchestration (Heat) API

2019-03-19 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795775#comment-16795775 ] Ignasi Barrera commented on JCLOUDS-693: Do you want to ty add it yourself

[jira] [Reopened] (JCLOUDS-1428) Support for SAS token based Authentication for Azure Blob Storage

2019-03-13 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera reopened JCLOUDS-1428: - Thanks [~swatijain1101] for the detailed feedback. We'll get that fixed. > Sup

[jira] [Commented] (JCLOUDS-1428) Support for SAS token based Authentication for Azure Blob Storage

2019-03-11 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789344#comment-16789344 ] Ignasi Barrera commented on JCLOUDS-1428: - If the case is the one [~Horu

[jira] [Commented] (JCLOUDS-1428) Support for SAS token based Authentication for Azure Blob Storage

2019-03-11 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789336#comment-16789336 ] Ignasi Barrera commented on JCLOUDS-1428: - Please, don't do that.

[jira] [Commented] (JCLOUDS-1428) Support for SAS token based Authentication for Azure Blob Storage

2019-03-11 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789328#comment-16789328 ] Ignasi Barrera commented on JCLOUDS-1428: - Looks like the stacktrace is

[jira] [Commented] (JCLOUDS-1490) Azure destroyNode try to delete a NIC in use

2019-03-04 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783836#comment-16783836 ] Ignasi Barrera commented on JCLOUDS-1490: - Can you provide the comp

[jira] [Resolved] (JCLOUDS-1428) Support for SAS token based Authentication for Azure Blob Storage

2019-02-27 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1428. - Resolution: Fixed > Support for SAS token based Authentication for Azure Blob Stor

[jira] [Updated] (JCLOUDS-1428) Support for SAS token based Authentication for Azure Blob Storage

2019-02-27 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1428: Fix Version/s: 2.1.3 2.2.0 > Support for SAS token ba

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-27 Thread Ignasi Barrera
Merged #1270 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1270#event-2167675278

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-26 Thread Ignasi Barrera
@ak58588 Looks good. In order for us to cleanly merge, could you squash the commits into a single one? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1270#issuecomment-467653588

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-20 Thread Ignasi Barrera
>I tested this locally and it does not introduce any regressions. Is it >possible to write an integration test for this or is that not possible because >of the way SAS tokens work? As far as I understand it, SAS tokens are just another kind of credentials. In that case, I'd say no extra IT is n

Re: [jclouds/jclouds] JCLOUDS-893: Support compute API extension "Servers with scheduler hints" (#740)

2019-02-19 Thread Ignasi Barrera
This has been closed but not merged. We would be happy to include this if someone continues the work and contributes it! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/740#issuecommen

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-18 Thread Ignasi Barrera
@gaul Anything you'd like to see before we merge this? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1270#issuecomment-464661110

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-15 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1270#pullrequestreview-204143481

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-15 Thread Ignasi Barrera
nacx requested changes on this pull request. This is in a much more good shape. Almost there! :) @gaul I think the actual unit tests cover the filter functionality, so I don't think we need special live/integration tests for that? It should be up to the user running the live tests to use normal

[jira] [Commented] (JCLOUDS-1426) Jclouds does not return all private ip address of aws ec2 instance

2019-02-14 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768116#comment-16768116 ] Ignasi Barrera commented on JCLOUDS-1426: - Yes. The {{RunningInstance}} ob

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-14 Thread Ignasi Barrera
nacx commented on this pull request. > + assertEquals(module.authSAS(supplier), true); + } + + @Test + void testAuthSasServiceSAS(){ + Credentials creds = new Credentials(identity, "sp=rl&st=2019-02-14T08:50:26Z&se=2019-02-15T08:50:26Z&sv=2018-03-28&sig=Ukow8%2GtpQpAiVZBLcWp

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-13 Thread Ignasi Barrera
nacx requested changes on this pull request. > } - + + /** +* this is an updated filter method, which decides whether the SAS or SharedKeyLite +* is used and applies the right filtering. +* ```suggestion ``` >utils.logRequest(signatureLog, request, "<<");

[jira] [Comment Edited] (JCLOUDS-1426) Jclouds does not return all private ip address of aws ec2 instance

2019-02-13 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767043#comment-16767043 ] Ignasi Barrera edited comment on JCLOUDS-1426 at 2/13/19 10:5

[jira] [Commented] (JCLOUDS-1426) Jclouds does not return all private ip address of aws ec2 instance

2019-02-13 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767043#comment-16767043 ] Ignasi Barrera commented on JCLOUDS-1426: - As [~andreaturli] said, curre

[jira] [Comment Edited] (JCLOUDS-1426) Jclouds does not return all private ip address of aws ec2 instance

2019-02-13 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767043#comment-16767043 ] Ignasi Barrera edited comment on JCLOUDS-1426 at 2/13/19 10:5

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-13 Thread Ignasi Barrera
nacx commented on this pull request. > @@ -63,6 +64,17 @@ protected final String guiceProvideTimeStamp(@TimeStamp > Supplier cache) protected String provideTimeStamp(@TimeStamp Supplier cache) { return cache.get(); } + + /** + * checks which Authentication type is used +

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-12 Thread Ignasi Barrera
nacx commented on this pull request. > @@ -63,6 +64,17 @@ protected final String guiceProvideTimeStamp(@TimeStamp > Supplier cache) protected String provideTimeStamp(@TimeStamp Supplier cache) { return cache.get(); } + + /** + * checks which Authentication type is used +

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-11 Thread Ignasi Barrera
nacx commented on this pull request. > public HttpRequest filter(HttpRequest request) throws HttpException { + request = this.isSAS ? filterSAS(request, this.credential) : filterKey(request); + return request; ```suggestion utils.logRequest(signatureLog, request, "<<");

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-11 Thread Ignasi Barrera
nacx commented on this pull request. > + } + utils.logRequest(signatureLog, request, "<<"); + return request; + } + + /** + * this filter method is applied only for the cases with SAS Authentication. + * + */ + public HttpRequest filterSAS(HttpRequest request, St

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-11 Thread Ignasi Barrera
nacx requested changes on this pull request. Formatting is still an issue to merge the PR. Please format all your code to use a 3 space indent. > public HttpRequest filter(HttpRequest request) throws HttpException { + if (this.isSAS){ + request = filterSAS(request, this.credentia

[jira] [Assigned] (JCLOUDS-104) Change labs/cli/karaf to have their own parent POMs separate from the top-level POM

2019-02-06 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera reassigned JCLOUDS-104: -- Assignee: (was: Ignasi Barrera) > Change labs/cli/karaf to have their own par

[jira] [Assigned] (JCLOUDS-104) Change labs/cli/karaf to have their own parent POMs separate from the top-level POM

2019-02-06 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera reassigned JCLOUDS-104: -- Assignee: Ignasi Barrera (was: Zack Shoylev) > Change labs/cli/karaf to have th

Re: [jclouds/jclouds-labs] JCLOUDS-1407 Add dimensiondata server API v2.7 supportServer API 2.7 support (#447)

2019-02-03 Thread Ignasi Barrera
This PR was in pretty good shape. Any chance it can be updated? 😄 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/447#issuecomment-460091094

Re: [jclouds/jclouds] Upgrade to modernizer-maven-plugin 1.8.0 (#1272)

2019-02-03 Thread Ignasi Barrera
Hmmm dows it allow to fork again and keep 2 different forks? If not, another opttion is to push all your branches to the ASF remote and open the PRs from there? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.

Re: [jclouds/jclouds] Upgrade to modernizer-maven-plugin 1.8.0 (#1272)

2019-02-03 Thread Ignasi Barrera
nacx approved this pull request. Lgtm. Mind reopening against the Apache org repo as PR builds are configured there now? Not a big deal. Feel free to merge directly anyway :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

Re: [jclouds/jclouds] Remove JavaScript from footer (#1271)

2019-02-02 Thread Ignasi Barrera
nacx commented on this pull request. > @@ -1120,19 +1120,6 @@ http://download.oracle.com/javase/6/docs/api/ -

Re: [jclouds/jclouds] Remove JavaScript from footer (#1271)

2019-02-01 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1271#pullrequestreview-199339368

[jira] [Commented] (JCLOUDS-1419) Missing StorageClass REGIONAL for GCS buckets

2019-02-01 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758406#comment-16758406 ] Ignasi Barrera commented on JCLOUDS-1419: - We are expecting to have our K

Re: [jclouds/jclouds] [JCLOUDS-1428] Support for SAS token based Authentication for Azure Blob Storage (#1270)

2019-02-01 Thread Ignasi Barrera
nacx requested changes on this pull request. Thanks, @ak58588! Please take another look at fixing indentation. > public HttpRequest filter(HttpRequest request) throws HttpException { + this.sasAuthentication = authSAS(this.credential); This could be set in the constructor instead of che

[jira] [Commented] (JCLOUDS-1472) Multipart upload for AzureBlob fails when using InputStream for files greater than 32MB

2019-01-31 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757222#comment-16757222 ] Ignasi Barrera commented on JCLOUDS-1472: - [~hisnamewasjaan] the best wa

Re: [jclouds/jclouds] JCLOUDS-1371: JCLOUDS-1488: list optimize prefix (#1268)

2019-01-29 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1268#pullrequestreview-197508785

[jira] [Commented] (JCLOUDS-1478) Error with multipart upload when blob uses byteArrayInputStream as payload

2019-01-28 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753839#comment-16753839 ] Ignasi Barrera commented on JCLOUDS-1478: - [~gaul] I think we could perfe

Re: [jclouds/jclouds] JCLOUDS-769: streaming putBlob (#1129)

2019-01-18 Thread Ignasi Barrera
Hm, I see where you're going. The main issue I see with this approach is that a client won't know actually when a streaming request has finished, and won't have access to the response code, which might be important... How are we handling streaming requests to endpoints return a redirect (3xx

Re: [jclouds/jclouds-labs] JCLOUDS-1407 Add dimensiondata server API v2.7 supportServer API 2.7 support (#447)

2019-01-18 Thread Ignasi Barrera
Also please rebase to make sure there are no conflicts. And apologies for the delay in the review. We've been busy with jclouds housekeeping stuff these months. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github

Re: [jclouds/jclouds-labs] JCLOUDS-1407 Add dimensiondata server API v2.7 supportServer API 2.7 support (#447)

2019-01-18 Thread Ignasi Barrera
nacx approved this pull request. There are just minor and cosmetic comments. Model looks very good and clean. Thanks! I'll merge the PR as soon as comments are addressed. > +import java.util.List; + +@AutoValue +public abstract class IdeController { + + public abstract String id(); + + publi

Re: [jclouds/jclouds-labs] JCLOUDS-1486 - Fix NPE and Remove Nullable osImageKey From OsImage (#453)

2019-01-18 Thread Ignasi Barrera
Thanks @jawnclarke! Merged to master and 2.1.x. Please open further PRs in the [apache org repo](https://github.com/apache/jclouds-labs). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-lab

Re: [jclouds/jclouds-labs] JCLOUDS-1486 - Fix NPE and Remove Nullable osImageKey From OsImage (#453)

2019-01-18 Thread Ignasi Barrera
Closed #453. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/453#event-2083184604

Re: [jclouds/jclouds-labs] JCLOUDS-1486 - Fix NPE and Remove Nullable osImageKey From OsImage (#453)

2019-01-18 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/453#pullrequestreview-194139976

[jira] [Commented] (JCLOUDS-1428) Support for SAS token based Authentication for Azure Blob Storage

2019-01-18 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746375#comment-16746375 ] Ignasi Barrera commented on JCLOUDS-1428: - {quote} Anyway, I would be re

Re: [jclouds/jclouds-labs] Use State enum instead of String state in Domain classes (#452)

2019-01-14 Thread Ignasi Barrera
Closed #452. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/452#event-2071253686

Re: [jclouds/jclouds-labs] Use State enum instead of String state in Domain classes (#452)

2019-01-14 Thread Ignasi Barrera
Merged to master and 2.1.x. Thanks! See; https://github.com/apache/jclouds-labs -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/452#issuecomment-453941750

Re: [jclouds/jclouds-labs] Use State enum instead of String state in Domain classes (#452)

2019-01-14 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/452#pullrequestreview-192058642

Re: [jclouds/jclouds-examples] Expose wait for predicates on relevant API (#96)

2019-01-14 Thread Ignasi Barrera
Closed #96. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/96#event-2071226774

Re: [jclouds/jclouds-examples] Expose wait for predicates on relevant API (#96)

2019-01-14 Thread Ignasi Barrera
Merged to master. See https://github.com/apache/jclouds-examples/ -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/96#issuecomment-453938192

Re: [jclouds/jclouds-labs] Expose wait for predicates on relevant API (#451)

2019-01-14 Thread Ignasi Barrera
Merged to master and 2.1.x. Thanks! We are migrating our repos to the apache org: https://github.com/apache/jclouds-labs Please, update your remotes and open upcoming PRs there. Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [jclouds/jclouds-labs] Expose wait for predicates on relevant API (#451)

2019-01-14 Thread Ignasi Barrera
Closed #451. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/451#event-2071222365

Re: [jclouds/jclouds-labs] Expose wait for predicates on relevant API (#451)

2019-01-11 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/451#pullrequestreview-191690808

Re: [jclouds/jclouds] [JCLOUDS-1474] [ARM] Enable Standard SKUs for Load Balancers and PublicIPsg (#1264)

2018-12-20 Thread Ignasi Barrera
nacx approved this pull request. > @SerializedNames({ "id", "name", "location", "etag", "tags", "properties", "sku"}) public static LoadBalancer create(String id, final String name, final String location, final String etag, - final Map tags, final LoadBalancerProperties prop

[jira] [Updated] (JCLOUDS-1474) [ARM] Enable Standard SKUs for Load Balancers and PublicIPs

2018-12-16 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1474: Affects Version/s: 2.1.1 > [ARM] Enable Standard SKUs for Load Balancers and Public

[jira] [Updated] (JCLOUDS-1474) [ARM] Enable Standard SKUs for Load Balancers and PublicIPs

2018-12-16 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1474: Fix Version/s: (was: 2.1.2) > [ARM] Enable Standard SKUs for Load Balancers

Re: [jclouds/jclouds] [JCLOUDS-1474] [ARM] Enable Standard SKUs for Load Balancers and PublicIPsg (#1264)

2018-12-16 Thread Ignasi Barrera
nacx commented on this pull request. > +import org.jclouds.json.SerializedNames; + +import com.google.auto.value.AutoValue; + +@AutoValue +public abstract class LoadBalancerSKU { + + public static enum LoadBalancerSKUName { + Basic, Standard, Unrecognized; + + public static LoadBalan

Re: [jclouds/jclouds] support aliyun oss and chinese region of aws s3 on jclouds 1.9.1 (#1263)

2018-12-16 Thread Ignasi Barrera
It is _very_ unlikely that we release another 1.9 version, so I'd suggest you open the pull request to the master branch, then we can cherry-pick it to 2.1.x. This said, there are things that are fundaamentally wrong in this pull request such as hardcoding endpoint logic in jclouds-core (RestAnn

[jira] [Updated] (JCLOUDS-1474) [ARM] Enable Standard SKUs for Load Balancers and PublicIPs

2018-12-16 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1474: Labels: azurecompute-arm (was: ) > [ARM] Enable Standard SKUs for Load Balancers

[jira] [Resolved] (JCLOUDS-1468) Add missing fields on CloudStack usage API

2018-12-05 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1468. - Resolution: Fixed Fix Version/s: 2.1.2 2.2.0 > Add miss

Re: [jclouds/jclouds] [JCLOUDS-1468] Adding missing options for the ListUsageRecords API call. (#1259)

2018-12-05 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/25f2bcd8) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/a8b8c9dd). Thanks @mcdonnell-john! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it o

Re: [jclouds/jclouds] [JCLOUDS-1468] Adding missing options for the ListUsageRecords API call. (#1259)

2018-12-05 Thread Ignasi Barrera
Closed #1259. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1259#event-2007963943

[jira] [Commented] (JCLOUDS-1470) Vulnarable Guava dependency dragged from jclouds-driver

2018-12-05 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710469#comment-16710469 ] Ignasi Barrera commented on JCLOUDS-1470: - By default jclouds uses Guav

[jira] [Updated] (JCLOUDS-1470) Vulnarable Guava dependency dragged from jclouds-driver

2018-12-05 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1470: Labels: guava (was: ) > Vulnarable Guava dependency dragged from jclouds-dri

[jira] [Updated] (JCLOUDS-1470) Vulnarable Guava dependency dragged from jclouds-driver

2018-12-05 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1470: Component/s: (was: jclouds-drivers) jclouds-core > Vulnarable Gu

Re: [jclouds/jclouds] [JCLOUDS-1468] Adding missing options for the ListUsageRecords API call. (#1259)

2018-12-05 Thread Ignasi Barrera
nacx commented on this pull request. > @@ -476,7 +595,7 @@ public String getIpAddress() { return this.ipAddress; } - public boolean isSourceNAT() { + public Boolean isSourceNAT() { @mcdonnell-john looks like this still needs to be addressed -- You are receiving this because

[jira] [Updated] (JCLOUDS-1467) Newly added c5 instanceType do not supports c5d series of AWS

2018-12-04 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1467: Labels: aws-ec2 (was: ) > Newly added c5 instanceType do not supports c5d series of

[jira] [Resolved] (JCLOUDS-1467) Newly added c5 instanceType do not supports c5d series of AWS

2018-12-04 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1467. - Resolution: Fixed Fix Version/s: 2.1.2 2.2.0 > Newly ad

Re: [jclouds/jclouds] [JCLOUDS-1468] Adding missing options for the ListUsageRecords API call. (#1259)

2018-12-03 Thread Ignasi Barrera
nacx approved this pull request. Just one minor comment left. Mind addressing it and squash the commits so I can cleanly merge the PR? Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jcl

Re: [jclouds/jclouds] [JCLOUDS-1468] Adding missing options for the ListUsageRecords API call. (#1259)

2018-12-03 Thread Ignasi Barrera
nacx commented on this pull request. > @@ -476,7 +595,7 @@ public String getIpAddress() { return this.ipAddress; } - public boolean isSourceNAT() { + public Boolean isSourceNAT() { Add the `@Nullable` annotation, for consistency. -- You are receiving this because you are subs

[jira] [Updated] (JCLOUDS-1468) Add missing fields on CloudStack usage API

2018-11-28 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1468: Labels: cloudstack (was: ) > Add missing fields on CloudStack usage

[jira] [Updated] (JCLOUDS-1468) Add missing fields on CloudStack usage API

2018-11-28 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1468: Component/s: jclouds-compute > Add missing fields on CloudStack usage

Re: [jclouds/jclouds] [JCLOUDS-1468] Adding missing options for the ListUsageRecords API call. (#1259)

2018-11-28 Thread Ignasi Barrera
nacx commented on this pull request. Just one comment. Otherwise looks good. Thanks, @mcdonnell-john! > @@ -400,6 +510,15 @@ protected UsageRecord(String id, @Nullable String > description, @Nullable String this.usageType = usageType; this.project = project; this.projectId =

Re: [jclouds/jclouds] Fix/azure resource removal (#1240)

2018-11-23 Thread Ignasi Barrera
nacx commented on this pull request. > @@ -171,9 +216,12 @@ public boolean cleanupSecurityGroupIfOrphaned(String > resourceGroup, String group logger.debug(">> deleting orphaned security group %s from %s...", name, resourceGroup); try { delete

Re: [jclouds/jclouds] Fix/azure resource removal (#1240)

2018-11-23 Thread Ignasi Barrera
> Hi, thanks for the feedback. I've addressed a couple of the comments above, > and pushed a couple of changes to address the others Looks like the changes are note pushed? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ht

Re: [jclouds/jclouds] Fix for FileSystem blob store clearContainer with options (#1258)

2018-11-22 Thread Ignasi Barrera
Failures in the PR build are due to an incorrect encoding configuration of Jenkins. I've fixed that and hopefully next one will succeed. Closing and reopening to trigger the build again. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [jclouds/jclouds] Fix for FileSystem blob store clearContainer with options (#1258)

2018-11-22 Thread Ignasi Barrera
Reopened #1258. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1258#event-1982735293

Re: [jclouds/jclouds] Fix for FileSystem blob store clearContainer with options (#1258)

2018-11-22 Thread Ignasi Barrera
Closed #1258. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1258#event-1982735204

[jira] [Commented] (JCLOUDS-1466) Azurecompute-arm listNodes doesn't work

2018-11-20 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693276#comment-16693276 ] Ignasi Barrera commented on JCLOUDS-1466: - It looks like there is a mis

Re: [jclouds/jclouds-labs] JCLOUDS-1454 Implement ServerToServerWithExternalIp function for dimensiondata (#448)

2018-11-19 Thread Ignasi Barrera
Closed #448. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/448#event-1975852024

[jira] [Resolved] (JCLOUDS-1454) Implement ServerToServerWithExternalIp function for dimensiondata

2018-11-19 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1454. - Resolution: Fixed > Implement ServerToServerWithExternalIp function for dimensiond

Re: [jclouds/jclouds-labs] JCLOUDS-1454 Implement ServerToServerWithExternalIp function for dimensiondata (#448)

2018-11-19 Thread Ignasi Barrera
Pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/424f358e) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/8ca49411). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: http

Re: [jclouds/jclouds-examples] Dimension Data - Added cleanServer call to NetworkDomainTearDown (#95)

2018-11-19 Thread Ignasi Barrera
Closed #95. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/95#event-1975804945

Re: [jclouds/jclouds-examples] Dimension Data - Added cleanServer call to NetworkDomainTearDown (#95)

2018-11-19 Thread Ignasi Barrera
Merged to master as [748058c3](http://git-wip-us.apache.org/repos/asf/jclouds-examples/commit/748058c3). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/95#issuecomment-440049

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-11-15 Thread Ignasi Barrera
Merged and published -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/220#issuecomment-439219335

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

2018-11-15 Thread Ignasi Barrera
Closed #222. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/222#event-1969963994

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-11-15 Thread Ignasi Barrera
Closed #220. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/220#event-1969963497

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

2018-11-15 Thread Ignasi Barrera
Addressed comments, merged and published. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/222#issuecomment-439219409

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

2018-11-15 Thread Ignasi Barrera
nacx commented on this pull request. > {% comment %} +{% include supportapache.html %} Yep, and we also have a link in the footer. There is no need for such a big disclaimer. -- You are receiving this because you are subscribed to this thread. Reply to this email dir

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

2018-11-15 Thread Ignasi Barrera
@nacx pushed 1 commit. 6b42e9f Move events to Apache menu -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-site/pull/222/files/c15171e679300a18082832be8979e905f7f6f575..6b42e9fd5c0ca13674d0afe4153007e7d43de69e

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

2018-11-15 Thread Ignasi Barrera
Closed #222. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/222#event-1968827572

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

2018-11-15 Thread Ignasi Barrera
Reopened #222. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/222#event-1968827727

[jclouds/jclouds-site] Fix events and CI links (#222)

2018-11-15 Thread Ignasi Barrera
* Removed banned from the top of the site. * Update the link to our new CI builds. * Replace the stale link to the meetups page with a link to the upcoming Apache events as per http://events.apache.org/README.txt You can view, comment on, or merge this pull request online at: https://github.com

Re: [jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
Closed #221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/221#event-1963847340

Re: [jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
Closed #221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/221#event-1963708174

Re: [jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
Reopened #221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/221#event-1963708276

Re: [jclouds/jclouds-site] DO NOT MERGE: Testing PR builds (#221)

2018-11-13 Thread Ignasi Barrera
Reopened #221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/221#event-1963702238

<    1   2   3   4   5   6   7   8   9   10   >