[
https://issues.apache.org/jira/browse/JCLOUDS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-1339.
-
Resolution: Fixed
> Support launching an x1 EC2 insta
[
https://issues.apache.org/jira/browse/JCLOUDS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1339:
Fix Version/s: 2.1.2
2.2.0
> Support launching an x1 EC2 insta
Closed #1235.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1235#event-1806022560
Merged to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/88f44a6d) and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/ca063d8b). Thanks
@lemmy!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
Closed #1234.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1234#event-1806020959
Amended the commit message to include the JIRA issue ref and merged to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/bcc6a264) and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/591fe84d). Thanks
@tormath1!
--
You are receiving this because you are subscribed
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1235#pullrequestreview-149036803
nacx commented on this pull request.
> @@ -290,6 +290,19 @@ private EC2HardwareBuilder hs1() {
virtualizationTypes(VirtualizationType.HVM,
VirtualizationType.PARAVIRTUAL);
return this;
}
+
+ private EC2HardwareBuilder x1() {
+
[
https://issues.apache.org/jira/browse/JCLOUDS-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589805#comment-16589805
]
Ignasi Barrera edited comment on JCLOUDS-1444 at 8/23/18 8:44 AM
[
https://issues.apache.org/jira/browse/JCLOUDS-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589805#comment-16589805
]
Ignasi Barrera commented on JCLOUDS-1444:
-
As a workaround you can configure the {{jclouds
I think so, let's get this merged and backported
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1234#issuecomment-415130329
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1234#pullrequestreview-147806402
nacx commented on this pull request.
> @@ -573,7 +573,11 @@ static URI addHostIfMissing(URI original, URI withHost) {
return null;
if (original.getHost() != null)
return original;
- return withHost.resolve(original);
+ URI baseURI = withHost;
Better use an
[
https://issues.apache.org/jira/browse/JCLOUDS-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584026#comment-16584026
]
Ignasi Barrera commented on JCLOUDS-1442:
-
Thanks [~s...@apache.org]. I've just pushed the fix
[
https://issues.apache.org/jira/browse/JCLOUDS-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera reassigned JCLOUDS-1442:
---
Assignee: Ignasi Barrera
> Please use HTTPS for KEYS, sigs and has
[
https://issues.apache.org/jira/browse/JCLOUDS-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1407:
Fix Version/s: (was: 2.1.1)
2.1.2
> Add dimensiondata server
[
https://issues.apache.org/jira/browse/JCLOUDS-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1331:
Fix Version/s: (was: 2.1.1)
2.1.2
> Azure ARM orphaned resou
[
https://issues.apache.org/jira/browse/JCLOUDS-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1330:
Fix Version/s: (was: 2.1.1)
2.1.2
> Azure ARM orphaned netwo
[
https://issues.apache.org/jira/browse/JCLOUDS-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1440:
Fix Version/s: (was: 2.1.1)
2.1.2
> Add support for r5 insta
[
https://issues.apache.org/jira/browse/JCLOUDS-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1431:
Fix Version/s: (was: 2.1.1)
2.1.2
> Support AU geo for Live Te
[
https://issues.apache.org/jira/browse/JCLOUDS-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1386:
Fix Version/s: (was: 2.1.1)
2.1.2
> 1&1 Baremetal
nacx commented on this pull request.
> +## Credits
+
+jclouds would like to thank everyone who contributed time and effort in order
to make this release happen:
+
+* [Vikas Rangarajan](https://github.com/VRanga000) for his contribution to the
new instance types supported in the AWS ec2
[
https://issues.apache.org/jira/browse/JCLOUDS-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580769#comment-16580769
]
Ignasi Barrera commented on JCLOUDS-1415:
-
Invite sent. I'll be mostly offlinetoday, but we can
[
https://issues.apache.org/jira/browse/JCLOUDS-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580211#comment-16580211
]
Ignasi Barrera commented on JCLOUDS-1415:
-
Do you have a branch somewhere we could have a look
nacx commented on this pull request.
> +1. [Known Issues](#knownissues)
+1. [Credits](#credits)
+1. [Test Results](#test)
+
+## Introduction
+
+Apache jclouds 2.1.1 is the first bugfix release after jclouds 2.1 and comes
with several bugfixes and performance improvements.
+You can [read the
[
https://issues.apache.org/jira/browse/JCLOUDS-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-1439.
-
> How to connect AWS environment through Multi factor authentication(MFA) in
>
[
https://issues.apache.org/jira/browse/JCLOUDS-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578370#comment-16578370
]
Ignasi Barrera commented on JCLOUDS-1439:
-
To make it work with MFA, you need to first get
nacx commented on this pull request.
> @@ -50,7 +51,11 @@ public void handleError(HttpCommand command, HttpResponse
> response) {
break;
case 401:
case 403:
-exception = new AuthorizationException(message, exception);
+if
nacx commented on this pull request.
> +// public String apply(Map.Entry input) {
+//return String.format(PORT_RANGE_FORMAT, input.getKey(),
input.getValue());
+// }
+// }));
+//
+// for (SecurityGroup securityGroup :
nacx commented on this pull request.
> +
+ public DependencyViolationException() {
+ super();
+ }
+
+ public DependencyViolationException(String arg0, Throwable arg1) {
+ super(arg0, arg1);
+ }
+
+ public DependencyViolationException(String arg0) {
+ super(arg0);
+ }
nacx commented on this pull request.
> +* [JCLOUDS-1410] - SoftLayer cannot provision with private image
+* [JCLOUDS-1422] - LocalBlobStore.list ignores recursive flag when prefix set
+* [JCLOUDS-1427] - NPE when deserializing Elastic IPs that have tags
+* [JCLOUDS-1433] -
[
https://issues.apache.org/jira/browse/JCLOUDS-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574751#comment-16574751
]
Ignasi Barrera commented on JCLOUDS-1439:
-
I don't really know how MFA works in AWS
[
https://issues.apache.org/jira/browse/JCLOUDS-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1439:
Labels: aws-ec2 aws-s3 (was: )
> How to connect AWS environment through Multi fac
nacx requested changes on this pull request.
> @@ -104,11 +117,39 @@ protected
> CreateResourcesThenCreateNodes(CreateNodeWithGroupEncodedIntoName addN
String regionId = template.getLocation().getId();
ECSServiceTemplateOptions options =
nacx commented on this pull request.
> } catch (Exception ex) {
logger.warn(ex, "Error cleaning up resources for node %s",
deadNode);
}
+
+ List securityGroups =
cleanupResources.findOrphanedSecurityGroups(regionAndId.regionId(),
deadNode.getGroup());
nacx commented on this pull request.
> @@ -54,6 +46,7 @@ protected Properties setupProperties() {
Properties properties = super.setupProperties();
vpcId = setIfTestSystemPropertyPresent(properties, provider + ".vpcId");
vSwitchId =
nacx requested changes on this pull request.
> +annotations-java5
+RELEASE
+compile
+
+
+org.jetbrains
+annotations-java5
+RELEASE
+compile
+
+
+org.jetbrains
+
nacx commented on this pull request.
> + vSwitchId = setIfTestSystemPropertyPresent(properties, provider +
> ".vSwitchId");
+ return properties;
+ }
+
+ @Override
+ protected TemplateBuilder templateBuilder() {
+ return super.templateBuilder()
+
nacx commented on this pull request.
> + this.instanceSuspendedPredicate = instanceSuspendedPredicate;
+ this.regionIds = regionIds;
+ this.cleanupResources = cleanupResources;
+ }
+
+ @Override
+ public NodeAndInitialCredentials
createNodeWithGroupEncodedIntoName(String
nacx commented on this pull request.
Thanks, @andreaturli!
There are many comments but in general, it looks pretty good.
Apart from the comments, we need proper tests for most of the things.
Basically, every class in the `compute/functions` package needs to have a
proper unit test.
Also, add
[
https://issues.apache.org/jira/browse/JCLOUDS-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1436:
Fix Version/s: (was: 2.1.1)
2.2.0
> Add support for m5 insta
[
https://issues.apache.org/jira/browse/JCLOUDS-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1387:
Fix Version/s: (was: 2.1.0)
2.2.0
> Add support for c5 insta
Closed #442.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/442#event-1763379395
Squashed and merged to master as
[d74d7f62](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/d74d7f62).
There were conflicts when cherry-picking to 2.1.x. If you want it backported
there please, open a PR against that branch.
Thanks!
--
You are receiving this because you are
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/441#pullrequestreview-142069469
nacx commented on this pull request.
> @@ -84,7 +84,7 @@ public static TagOptions keys(Set keys) {
private void validateInput(final String input, int maxLength) {
checkNotNull(input);
checkState(input.length() <= maxLength, String.format("input must be <=
%d chars",
nacx commented on this pull request.
Just one minor comment, otherwise LGTM. Does this PR depend on any other open
PR?
> @@ -260,4 +260,14 @@ public static OSImageType fromValue(String v) {
}
}
+
+ public enum FirewallRuleAction {
+ allow,
+ deny,
+ UNRECOGNIZED;
nacx commented on this pull request.
> ICMP, GRE, TCP, UDP, ALL;
+ public static IpProtocol fromValue(String value) {
+ Optional ipProtocol = Enums.getIfPresent(IpProtocol.class,
value.toUpperCase());
+ checkArgument(ipProtocol.isPresent(), "Expected one of %s but was %s",
nacx commented on this pull request.
First review done (not checked the tests).
I'll go through the tests review once the current comments are addressed.
> + * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS"
[
https://issues.apache.org/jira/browse/JCLOUDS-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-1432.
-
Resolution: Fixed
Fix Version/s: (was: 2.1.1)
> API Client expects 404 c
merged to master as
[2d9cb407](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/2d9cb407).
Thanks @FileIOUtility!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #439.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/439#event-1738328709
Closed #1231.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1231#event-1732679475
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/92076d6b) and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/4d1f64d7). Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1231#pullrequestreview-136854963
nacx commented on this pull request.
> + public void checkIpAvailable() throws InterruptedException {
+ server.enqueue(jsonResponse("/ipavailable.json"));
+
+ final VirtualNetworkApi vnApi = api.getVirtualNetworkApi(resourcegroup);
+ IpAddressAvailabilityResult checkResult =
nacx commented on this pull request.
> + public void checkIpAvailable() throws InterruptedException {
+ server.enqueue(jsonResponse("/ipavailable.json"));
+
+ final VirtualNetworkApi vnApi = api.getVirtualNetworkApi(resourcegroup);
+ IpAddressAvailabilityResult checkResult =
nacx commented on this pull request.
> + */
+package org.jclouds.azurecompute.arm.domain;
+
+import java.util.List;
+
+import org.jclouds.javax.annotation.Nullable;
+import org.jclouds.json.SerializedNames;
+
+import com.google.auto.value.AutoValue;
+import
No need for a new PR. Just squash and push+force here.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/439#issuecomment-404577707
Closed #1229.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1229#event-1730749986
Merged to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/e45c262f) and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/cc3ad739). Thanks
@danielestevez!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it
Merged to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/566ac233) and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/2bddbd51). Thanks
@danielestevez!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it
Closed #1225.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1225#event-1730748311
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1229#pullrequestreview-136728682
And build is back to green! @FileIOUtility mind squashing the commits so I
can cleanly merge the PR?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/439#issuecomment-404567165
nacx commented on this pull request.
> @@ -1280,7 +1280,10 @@
org.gaul
modernizer-maven-plugin
+
Everything should be in place now in jclouds-core: rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/439#issuecomment-404305499
Closed #1227.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1227#event-1728432145
Merged to master and 2.1.x
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1227#issuecomment-404237820
Merged to master
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1224#issuecomment-404236734
Closed #1224.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1224#event-1728425037
[
https://issues.apache.org/jira/browse/JCLOUDS-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-1401.
-
Resolution: Fixed
Fix Version/s: 2.1.1
2.2.0
>
Closed #1226.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1226#event-1728411664
Thanks for the patch and for taking your time to run the live tests @jglick!
Merged to master and 2.1.x.
I'll have a look at the failing tests, as if you run just the S3 ones and pass
the endpoint, all succeed. There must be some minor mess about the endpoints in
the aws-s3 tests.
--
You are
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1226#pullrequestreview-136323635
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1225#pullrequestreview-136029939
[
https://issues.apache.org/jira/browse/JCLOUDS-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-1433.
-
Resolution: Fixed
Fix Version/s: 2.1.1
2.2.0
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/c34935dc) and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/9f999617). Thanks
@jglick!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
Closed #1228.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1228#event-1726643033
nacx commented on this pull request.
> @SelectJson("value")
@GET
@Fallback(EmptyListOnNotFoundOr404.class)
List list();
+ @Named("networkinterfacecard:list_all")
+ @Path("/providers/Microsoft.Network/networkInterfaces")
+ @SelectJson("value")
+ @GET
+
Thanks, @jglick!
I'd say before running live tests you could add a small unit test that just
verifies the `createStringToSign` method so we don't break it accidentally in
the future.
You can also add a mock unit test to the
Depends on https://github.com/jclouds/jclouds/pull/1224
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1227
-- Commit Summary --
* Adds ConcurrentModificationException to the list of propagatable types
-- File Changes --
M
nacx commented on this pull request.
> @SelectJson("value")
@GET
@Fallback(EmptyListOnNotFoundOr404.class)
List list();
+ @Named("networkinterfacecard:list_all")
+ @Path("/providers/Microsoft.Network/networkInterfaces")
+ @SelectJson("value")
+ @GET
+
nacx commented on this pull request.
Thanks @danielestevez!
> @@ -105,6 +105,12 @@ public void listNetworkInterfaceCards() {
assertTrue(nicList.contains(api().get(nicName)));
}
+ @Test(dependsOnMethods = "createNetworkInterfaceCard")
+ public void listAllNetworkInterfaceCards()
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/1bd3b8f9) and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/467501fd). Thanks
@danielestevez!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it
Closed #1220.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1220#event-1723703416
FTR: https://github.com/jclouds/jclouds/pull/1224 should fix this build once
merged.
There is one checkstyle violation in this branch though:
```
[WARNING]
src/test/java/org/jclouds/dimensiondata/cloudcontrol/features/ServerApiMockTest.java[31:8]
(imports) UnusedImports: Unused import -
There is already https://github.com/jclouds/jclouds/pull/1197, but while we
complete the work to properly support Java 8 in every project (just
jclouds-karaf pending) we should not block contributions from using Java 7
stuff.
You can view, comment on, or merge this pull request online at:
It's because the default build config. No need to close the PR. I'll bump the
source and target versions in the build config and it should be fine.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1220#pullrequestreview-135491806
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/439#issuecomment-403472574
nacx commented on this pull request.
> @@ -56,7 +57,7 @@ public void testDeployServerReturnsUnexpectedError() throws
> InterruptedException
serverApi().deployServer(ServerApiMockTest.class.getSimpleName(),
"imageId", true, networkInfo,
"administratorPassword");
>EDIT: in Java language level 6, ConcurrentModificationException cannot take
>cause exception, so after all, I don't want to use it.
jclouds needs at least Java 7 to work. We've been trying to keep backward
compatibility in our builds, but we are about to move to Java 8 in the next
major
nacx commented on this pull request.
> @@ -56,7 +57,7 @@ public void testDeployServerReturnsUnexpectedError() throws
> InterruptedException
serverApi().deployServer(ServerApiMockTest.class.getSimpleName(),
"imageId", true, networkInfo,
"administratorPassword");
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/440#pullrequestreview-134980120
Yes, LGTM, although I'd keep the "action" parameter separate and use the map
just for the additional ones. The assertions would look more consistent with
the methods that don't have extra params.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly
nacx requested changes on this pull request.
>RecordedRequest request = server.takeRequest();
assertEquals(request.getMethod(), method);
Map queryParameters =
Splitter.on('&').trimResults().withKeyValueSeparator("=").split(request.getPath());
nacx commented on this pull request.
> + assertSent(server, "GET", "DescribeRegions");
+ }
+
+ public void testListRegionsReturns404() {
+ server.enqueue(response404());
+ List regions = api.regionAndZoneApi().describeRegions();
+ assertTrue(isEmpty(regions));
+
nacx commented on this pull request.
> + Map> networkTypes)
> {
+ return new AutoValue_ResourceInfo(ioOptimized, systemDiskCategories ==
null ?
+ImmutableMap.>of() :
+ImmutableMap.copyOf(systemDiskCategories),
+
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/975aca53) and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/00b6697d).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
301 - 400 of 6767 matches
Mail list logo
