nacx commented on this pull request.
>return floatingIP;
}
+
+ private List getNetworksFromPoolNames(String regionId, final
Optional poolNames) {
+ return getNetworkApi(regionId).list().concat().filter(new
Predicate() {
if the pool name set is absent or empty, just
nacx commented on this pull request.
> + }
+ });
+ return floatingIPOptional;
+ }
+
+ private org.jclouds.openstack.neutron.v2.domain.FloatingIP
createFloatingIpUsingNeutron(org.jclouds.openstack.neutron.v2.features.FloatingIPApi
neutronFloatingApi, NodeMetadata node,
nacx commented on this pull request.
> + Optional
> floatingIPOptional = tryFindExistingFloatingIp(neutronFloatingApi,
> availabilityZone);
+ org.jclouds.openstack.neutron.v2.domain.FloatingIP floatingIP;
+ if (floatingIPOptional.isPresent()) {
+
nacx commented on this pull request.
> + Optional networkOptional =
> getNetworkApi(regionId).list().concat().firstMatch(new Predicate() {
+ @Override
+ public boolean apply(@Nullable Network input) {
+return input.getExternal() &&
https://issues.apache.org/jira/browse/JCLOUDS-1381
/cc @aledsage
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1179
-- Commit Summary --
* JCLOUDS-1381: Fix NPE in GCE DiskURIToImage
-- File Changes --
M
[
https://issues.apache.org/jira/browse/JCLOUDS-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1381:
Labels: google-compute-engine (was: )
> NullPointerException provisioning VM in
nacx commented on this pull request.
Thanks @andreaturli!
>
try {
-network = networkApi.create(
-
Network.createBuilder("jclouds-network-test").external(true).networkType(NetworkType.LOCAL).build());
-assertNotNull(network);
-
-
I agree with @demobox comments, and I'm almost done editing the blog post
according to them. I think we should publish a blog post that is understandable
and as better as we can, so I'll complete the work and merge it once we're all
happy with it. It is our public image!
I think we'd better
nacx commented on this pull request.
> + .overrides(neutronProperties)
+ .modules(ImmutableSet.of(new SLF4JLoggingModule()))
+ .build();
+
+// Create the connection to OpenStack nova and link it to Neutron
+NovaApi nova = ContextBuilder.newBuilder("openstack-nova")
+
nacx commented on this pull request.
> +date: 2018-02-06 07:00:00+00:00
+layout: post
+slug: nova-neutron
+title: OpenStack Nova and Neutron
+---
+
+One of the limitations of the jclouds implementation of the OpenStack Nova API
is that is was not able to directly talk to the Neutron service.
nacx commented on this pull request.
> @@ -0,0 +1,43 @@
+---
+author: https://twitter.com/IgnasiBarrera;>Ignasi Barrera
+comments: true
+date: 2018-02-06 07:00:00+00:00
+layout: post
+slug: nova-neutron
+title: OpenStack Nova and Neutron
+---
+
+One of the limitations of the j
nacx commented on this pull request.
> @@ -2,9 +2,13 @@
This repository supports the GitHub Pages site for jclouds. See and read more
at [http://www.jclouds.org](http://www.jclouds.org).
+To test the site locally:
+
+jekyll _1.5.1_ serve --safe
Not italics, but the Ruby syntax to use
The blog post describes the context linking feature that is used starting from
2.1.0 to allow OpenStack Nova APIs use a given Neutron deployment for
networking operations.
This blog should be linked from the 2.1.0 release notes.
You can view, comment on, or merge this pull request online at:
[
https://issues.apache.org/jira/browse/JCLOUDS-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1258:
Fix Version/s: (was: 2.0.3)
(was: 2.1.0)
> Amazon Ch
[
https://issues.apache.org/jira/browse/JCLOUDS-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1234:
Fix Version/s: (was: 2.1.0)
> openstack-nova - Indeterminate/invalid group refere
[
https://issues.apache.org/jira/browse/JCLOUDS-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1069:
Fix Version/s: (was: 2.1.0)
> Add instance type t2.nano for
[
https://issues.apache.org/jira/browse/JCLOUDS-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1378:
Fix Version/s: (was: 2.1.0)
> NullPointerException in NovaComputeServiceAdapter w
[
https://issues.apache.org/jira/browse/JCLOUDS-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-1152.
-
Resolution: Fixed
> Update README
> -
>
> Key:
[
https://issues.apache.org/jira/browse/JCLOUDS-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1152:
Labels: azurecompute-arm (was: )
> Update README
> -
>
>
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1177#pullrequestreview-94017424
[
https://issues.apache.org/jira/browse/JCLOUDS-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352380#comment-16352380
]
Ignasi Barrera commented on JCLOUDS-1379:
-
I'd say there are two ways to fix this:
* Let
[
https://issues.apache.org/jira/browse/JCLOUDS-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1379:
Affects Version/s: 2.0.3
> incompatible instance types selected in new AWS regi
[
https://issues.apache.org/jira/browse/JCLOUDS-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1379:
Component/s: jclouds-compute
> incompatible instance types selected in new AWS regi
[
https://issues.apache.org/jira/browse/JCLOUDS-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1379:
Labels: aws-ec2 (was: )
> incompatible instance types selected in new AWS regi
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/107#pullrequestreview-93654879
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1175#pullrequestreview-93641279
nacx commented on this pull request.
> - @Provides
- @Singleton
- @Named("SECURITYGROUP_PRESENT")
- protected final Predicate
securityGroupEventualConsistencyDelay(
-FindSecurityGroupWithNameAndReturnTrue in,
-
nacx commented on this pull request.
> + return ImmutableSet.of();
+ }
+ return
getSecurityGroupApi(region).listSecurityGroups().concat().transform(neutronSecurityGroupToSecurityGroup.create(location)).toSet();
+ }
+
+ @Override
+ public Set
nacx requested changes on this pull request.
I've debugged the failure and it turns to be a test concurrency issue with the
two tests that verify the behavior of the SG cache. If you apply this patch to
make sure both tests don't use the same security group, tests should pass:
```diff
diff
Time is not an issue. Live tests are assumed to take their time.
What about my comment on creating the machine using the compute service? Could
it be then created using the compute service defaults, and extract the subnet
and address from the created instance?
--
You are receiving this because
Thanks for the explanation. Would it make sense to do like we do in the [Azure
ARM load balancer live
test](https://github.com/jclouds/jclouds/blob/master/providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/LoadBalancerApiLiveTest.java#L250)
and use the ComputeService
Thanks @swaqos!
>The users are expected to set variables subnetId, servicePrices, and
>testInstancePrivateIp for LoadBalancerApiLiveTest.
What are those properties needed for?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
nacx commented on this pull request.
Just one comment. Apart from that looks good.
Could you share the results of the live tests for the Nova and Neutron SG
extensions?
> + if (region == null) {
+ return ImmutableSet.of();
+ }
+ return
[
https://issues.apache.org/jira/browse/JCLOUDS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-949.
Resolution: Fixed
> Add the t2.large instance type to aws-
[
https://issues.apache.org/jira/browse/JCLOUDS-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1378:
Labels: openstack-nova (was: )
> NullPointerException in NovaComputeServiceAdapter w
nacx requested changes on this pull request.
Thanks @andreaturli! Looks like a great starting point.
Apart from the comments I've made I found it difficult to understand the
duplicated "Create/FindSecurityGroup" classes. For a proper review, could you
please:
* Explain what is each new class,
[
https://issues.apache.org/jira/browse/JCLOUDS-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1377:
Component/s: jclouds-compute
> Support Neutron-based Openstack installation from N
[
https://issues.apache.org/jira/browse/JCLOUDS-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1377:
Labels: openstack-neutron openstack-nova (was: )
> Support Neutron-based Openst
[
https://issues.apache.org/jira/browse/JCLOUDS-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1377:
Affects Version/s: 2.0.3
> Support Neutron-based Openstack installation from N
Ignasi Barrera created JCLOUDS-1376:
---
Summary: Packet hardware profiles are not properly scoped to the
locations
Key: JCLOUDS-1376
URL: https://issues.apache.org/jira/browse/JCLOUDS-1376
Project
Pushed to master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1174#issuecomment-358235040
Closed #1174.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1174#event-1427778415
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1174
-- Commit Summary --
* Adds rackspace cloudnetworks-us provider
* Use AutoService for creation of Service Loader Metadata
* Updated service type from "networks" to "network"
*
Merged to master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1173#issuecomment-358227888
Closed #1173.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1173#event-1427732129
The OpenStack neutron API has been stable for a long time and it's been used in
production for more than a year. It's time to promote it to the main repo, as
this will allow us to implement some cool stuff to combine it with OpenStack
Nova.
/cc @andreaturli
You can view, comment on, or merge
[
https://issues.apache.org/jira/browse/JCLOUDS-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327503#comment-16327503
]
Ignasi Barrera commented on JCLOUDS-1333:
-
I had a quick WIP where I fixed the failures
[
https://issues.apache.org/jira/browse/JCLOUDS-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-1373.
-
Resolution: Fixed
Fix Version/s: 2.0.4
2.1.0
> Add the
Merged to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/6fd7c7c3) and
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/4329c897).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
[
https://issues.apache.org/jira/browse/JCLOUDS-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327137#comment-16327137
]
Ignasi Barrera commented on JCLOUDS-1373:
-
Pull request: https://github.com/jclouds/jclouds/pull
https://issues.apache.org/jira/browse/JCLOUDS-1373
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1172
-- Commit Summary --
* JCLOUDS-1373: Add eu-west-3 (Paris) AWS region
-- File Changes --
M
[
https://issues.apache.org/jira/browse/JCLOUDS-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-1372.
-
Resolution: Fixed
Fix Version/s: 2.0.4
2.1.0
> Add supp
Closed #1171.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1171#event-1425991042
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/d50acd5e) and
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/ec20f05b).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
[
https://issues.apache.org/jira/browse/JCLOUDS-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327032#comment-16327032
]
Ignasi Barrera commented on JCLOUDS-1372:
-
Pull request: https://github.com/jclouds/jclouds/pull
https://issues.apache.org/jira/browse/JCLOUDS-1372
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1171
-- Commit Summary --
* JCLOUDS-1372: Add support for R4 instance types
-- File Changes --
M
[
https://issues.apache.org/jira/browse/JCLOUDS-806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-806.
Resolution: Fixed
> Support OpenStack Poppy
[
https://issues.apache.org/jira/browse/JCLOUDS-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-114.
Resolution: Fixed
Fix Version/s: 2.1.0
> Support OpenStack Keystone v3
Merged and published. Thanks @demobox!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/206#issuecomment-357922399
Closed #206.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/206#event-1425876044
See https://github.com/jclouds/jclouds/pull/1170
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs-openstack/pull/210
-- Commit Summary --
* Add support for Keystone V3
-- File Changes --
M .gitignore (2)
M
nacx commented on this pull request.
> * The `KeystoneAuthenticationModule` and the `AuthenticationApiModule` have
> been refactored and generalised into:
* `AuthenticationModule` - Providing authentication services to all
OpenStack APIs and providers.
* `ServiceCatalogModule` -
Closed #1170.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1170#event-1425618092
Squashed and pushed to master as
[dd73410d](http://git-wip-us.apache.org/repos/asf/jclouds/commit/dd73410d). Yay!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
nacx commented on this pull request.
> * The `KeystoneAuthenticationModule` and the `AuthenticationApiModule` have
> been refactored and generalised into:
* `AuthenticationModule` - Providing authentication services to all
OpenStack APIs and providers.
* `ServiceCatalogModule` -
[
https://issues.apache.org/jira/browse/JCLOUDS-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326355#comment-16326355
]
Ignasi Barrera commented on JCLOUDS-114:
And we have finally the pull request!
https
https://issues.apache.org/jira/browse/JCLOUDS-114
Adds support for OpenStack Keystone V3. This has been live tested against
Fujitsu and DevStack, and also verified with the jclouds-cli. Once this is
merged the OpenStack APIs in the labs repos need to be updated too.
Kudos to @andreaturli too!
nacx commented on this pull request.
> * The `KeystoneAuthenticationModule` and the `AuthenticationApiModule` have
> been refactored and generalised into:
* `AuthenticationModule` - Providing authentication services to all
OpenStack APIs and providers.
* `ServiceCatalogModule` -
[
https://issues.apache.org/jira/browse/JCLOUDS-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1375:
Affects Version/s: 2.0.3
> Security Group API set feature add to SoftLayer provi
[
https://issues.apache.org/jira/browse/JCLOUDS-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1374:
Labels: softlayer (was: )
> LoadBalancer API set feature add to SoftLayer provi
[
https://issues.apache.org/jira/browse/JCLOUDS-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1374:
Affects Version/s: 2.0.3
> LoadBalancer API set feature add to SoftLayer provi
[
https://issues.apache.org/jira/browse/JCLOUDS-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1375:
Labels: softlayer (was: )
> Security Group API set feature add to SoftLayer provi
This is a WIP for a blog post describing the new OpenStack Keystone V3 feature.
Please use it as a reference if you want to test the
https://github.com/jclouds/jclouds/tree/keystonev3 branch.
@andreaturli @demobox I've pushed the branch to the ASF remote (not my fork) so
you can directly make
[
https://issues.apache.org/jira/browse/JCLOUDS-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera updated JCLOUDS-1372:
Labels: aws-ec2 (was: )
> Add support for R4 instance types in AWS
[
https://issues.apache.org/jira/browse/JCLOUDS-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321825#comment-16321825
]
Ignasi Barrera commented on JCLOUDS-1372:
-
Thanks for reporting. Would you like to try
Ignasi Barrera created JCLOUDS-1373:
---
Summary: Add the new Paris region to aws-ec2
Key: JCLOUDS-1373
URL: https://issues.apache.org/jira/browse/JCLOUDS-1373
Project: jclouds
Issue Type
Pushed to master!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1169#issuecomment-355987454
Closed #1169.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1169#event-1413759997
Closing this. With the recent addition of the keyvault API and the
configuration of the custom data in a different PR this should be better done
in a new one.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #398.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/398#event-1413702436
Promote Azure ARM out of labs, keeping the commit history.
/cc @jmspring
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1169
-- Commit Summary --
* JCLOUDS-664 Azurecompute-arm ResourceGroupApi
* Azure ARM fixes
* Updated
Closed #430.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/430#event-1413180583
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/036c68f2)
and
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/f3fff863).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #1165.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1165#event-1413180106
[
https://issues.apache.org/jira/browse/JCLOUDS-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-1362.
-
Resolution: Fixed
Fix Version/s: 2.0.4
2.1.0
> Rando
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/9fef6ed0) and
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/22209966).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
[
https://issues.apache.org/jira/browse/JCLOUDS-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311967#comment-16311967
]
Ignasi Barrera commented on JCLOUDS-1219:
-
Providers in labs are also part of jclouds releases
Depends on https://github.com/jclouds/jclouds/pull/1165, but opening it now
just for early feedback.
@jmspring comments and tests welcome! :)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/430
-- Commit Summary --
*
The failure looks like a Jenkins internal issue; rebuild, please!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1165#issuecomment-355171375
The failure looks like a Jenkins internal issue; rebuild please!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1165#issuecomment-355171443
Closed #416.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/416#event-1408793861
Finally merged to
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/fa63f6b1)
and
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/50d71c8e).
Many thanks for this huge effort @jmspring!
--
You are receiving this because you are subscribed to this thread.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1165
-- Commit Summary --
* JCLOUDS-1362: Better password generation utility
-- File Changes --
A core/src/main/java/org/jclouds/util/PasswordGenerator.java (194)
D
Closed #429.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/429#event-1399962863
I'm still working on this @trevorflanagan. I'll ping you when it is ready to
test.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/429#issuecomment-353624589
This configures the locations for DimensionData. Users won't have to configure
the `endpoint` when creating the context, as jclouds will already know all
region endpoints.
The configured suppliers preconfigure all the region endpoints, and for each
one, it retrieves the list of available
nacx commented on this pull request.
> +import static com.google.inject.internal.util.$Preconditions.checkNotNull;
+
+@Singleton
+public class DatacenterToLocation implements Function {
+
+ private final JustProvider justProvider;
+
+ @Inject
+ public
nacx approved this pull request.
Finally! Thanks for the huge effort @jmspring! LGTM. Could you squash the
changes and rebase the branch for a clean merge?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/5a3b5991)
and
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/0351481d).
I've added [a
commit](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/199e7789) in
2.0.x to fix the Guava
Closed #426.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/426#event-1399239056
601 - 700 of 6767 matches
Mail list logo