Re: [jclouds/jclouds] [JCLOUDS-1360] add support for block device mappings to Nova (#1159)

2017-11-22 Thread Ignasi Barrera
nacx commented on this pull request. > @@ -131,7 +131,8 @@ public NovaComputeServiceAdapter(NovaApi novaApi, @Region > Supplier if (templateOptions.getKeyPairName() != null) { options.keyPairName(templateOptions.getKeyPairName()); } - + if

[jira] [Commented] (JCLOUDS-1359) minDisk has no effect

2017-11-21 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260568#comment-16260568 ] Ignasi Barrera commented on JCLOUDS-1359: - It really depends on the hardware profile

[jira] [Resolved] (JCLOUDS-1342) Azure-ARM Virtual Machine Scale Set Support

2017-11-21 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1342. - Resolution: Fixed Fix Version/s: 2.0.3 2.1.0 > Azure-

Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)

2017-11-21 Thread Ignasi Barrera
Closed #412. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/412#event-1351615646

Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)

2017-11-21 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/30a500f8) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/96fca7eb). The commit in this PR contained changes not related to this PR (it has 108 files) because the branch was not properly

[jira] [Commented] (JCLOUDS-1359) minDisk has no effect

2017-11-21 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260452#comment-16260452 ] Ignasi Barrera commented on JCLOUDS-1359: - The {{minDisk}} attribute is used for image

[jira] [Resolved] (JCLOUDS-1355) Enable VM to be created without externally facing IP address

2017-11-21 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1355. - Resolution: Fixed Fix Version/s: 2.1.0 > Enable VM to be created with

Re: [jclouds/jclouds] JCLOUDS-1355: Enable VM creation without external IP address. (#1157)

2017-11-21 Thread Ignasi Barrera
Merged to master as [5d82a3df](http://git-wip-us.apache.org/repos/asf/jclouds/commit/5d82a3df). Thanks, @nelsonjr! Although changes are backward-compatible I haven't cherry-picked it to 2.0.x because there are conflicts. 2.0.x only supports legacy networks and there is no a clean merge. --

Re: [jclouds/jclouds] JCLOUDS-1355: Enable VM creation without external IP address. (#1157)

2017-11-21 Thread Ignasi Barrera
Closed #1157. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1157#event-1351520717

Re: [jclouds/jclouds] JCLOUDS-1355: Enable VM creation without external IP address. (#1157)

2017-11-21 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1157#pullrequestreview-78036013

[jira] [Commented] (JCLOUDS-1356) jclouds occasionally can't log in to AWS EC2 instance

2017-11-16 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255137#comment-16255137 ] Ignasi Barrera commented on JCLOUDS-1356: - Many thanks [~alex.heneveld] for the detailed report

Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)

2017-11-14 Thread Ignasi Barrera
This is a good and small tutorial on rebasing and squashing commits: https://help.github.com/articles/about-git-rebase/ I'm not confident on rebasing the PR myself, as it now lists 103 commits and I don't know exactly which ones should I cherry-pick to properly merge the feature. I'd suggest

Re: [jclouds/jclouds] [JCLOUDS-1354] avoid memory leak by reusing BouncyCastleProvider (#1156)

2017-11-13 Thread Ignasi Barrera
Thanks for the detailed bug report and for the PR @thomasgl-orange! Although I fully understand the memory leak, I'm a bit concerned about introducing a cross-context instance. If at some point the JDK bug gets fixed, users might expect all context-scoped resources to be released when the

Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)

2017-11-13 Thread Ignasi Barrera
@code4clouds the PR still has 89 commits, whilst after squashing and rebasing it should have just one. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/412#issuecomment-343856776

Re: [jclouds/jclouds] Utilising MD5 hash present in payload metadata (#1155)

2017-11-10 Thread Ignasi Barrera
Closed #1155. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1155#event-1335684225

Re: [jclouds/jclouds] Utilising MD5 hash present in payload metadata (#1155)

2017-11-10 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/c468c60d) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/f4ecb785). Thanks @kirankhopade! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)

2017-11-10 Thread Ignasi Barrera
I know @code4clouds, but I always prefer the contributors to do it, so they can write their commit message and properly explain the contents of the contribution in a single commit. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [jclouds/jclouds] Utilising MD5 hash present in payload metadata (#1155)

2017-11-10 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1155#pullrequestreview-75695468

Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)

2017-11-09 Thread Ignasi Barrera
Many thanks @code4clouds for all the fixes and the continued effort. Ready to merge! Mind squashing all the commits into a single one and get it rebased to the latest version of master so I can cleanly merge the PR? Thanks! -- You are receiving this because you are subscribed to this thread.

Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)

2017-11-09 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/412#pullrequestreview-75370449

Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)

2017-11-08 Thread Ignasi Barrera
nacx requested changes on this pull request. > + } + + public void testGet_NetworkProfile() throws InterruptedException { + server.enqueue(jsonResponse("/virtualmachinescalesetget.json").setResponseCode(200)); + final VirtualMachineScaleSetApi vmssAPI =

Re: [jclouds/jclouds-labs] Add tags to virtual network creation (#417)

2017-11-06 Thread Ignasi Barrera
Pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/c9cd6eaf) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/fd22d3ad). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] Add tags to virtual network creation (#417)

2017-11-06 Thread Ignasi Barrera
nacx commented on this pull request. > @@ -159,7 +159,7 @@ protected synchronized void > createDefaultNetworkIfNeeded(String group, String lo logger.debug(">> network options have not been configured. Creating network %s(%s) and subnet %s(%s)", name,

Re: [jclouds/jclouds-labs] Add tags to virtual network creation (#417)

2017-11-06 Thread Ignasi Barrera
nacx commented on this pull request. > @@ -159,7 +159,7 @@ protected synchronized void > createDefaultNetworkIfNeeded(String group, String lo logger.debug(">> network options have not been configured. Creating network %s(%s) and subnet %s(%s)", name,

Re: [jclouds/jclouds-labs] Add Azure KeyVault support -- vault management and certificate/key/secret operations (#416)

2017-11-06 Thread Ignasi Barrera
nacx commented on this pull request. Thanks @jmspring! Huge effort! I'm adding some general comments after a first review, but I still have to go in deeper detail through the entire PR again: * In the model classes, enforce immutable lists. * Also try to use non-null collections and enforce

[jclouds/jclouds-labs] Add tags to virtual network creation (#417)

2017-11-06 Thread Ignasi Barrera
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/417 -- Commit Summary -- * Add tags to virtual network creation -- File Changes -- M

[jira] [Updated] (JCLOUDS-1351) AWS CentOS marketplace AMI misdetecting OS type

2017-11-03 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1351: Fix Version/s: 2.0.3 > AWS CentOS marketplace AMI misdetecting OS t

Re: [jclouds/jclouds] JCLOUDS-1351: fixes to correctly recognise and boot the official CentOS images from the AWS Marketplace (#1153)

2017-11-03 Thread Ignasi Barrera
Merged to 2.0.x. Thanks again! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1153#issuecomment-341683558

Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)

2017-11-03 Thread Ignasi Barrera
nacx commented on this pull request. > + String subnetName = String.format("s-%s-%s", > this.getClass().getSimpleName().toLowerCase(), > System.getProperty("user.name")); + this.subnet = createDefaultSubnet(resourceGroupName, subnetName, virtualNetworkName, "10.2.0.0/23"); +

Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)

2017-11-03 Thread Ignasi Barrera
nacx commented on this pull request. > + /** +* The private IP address version of the Virtual Machine Scale Set Ip Configuration Properties +*/ + @Nullable + public abstract String privateIPAddressVersion(); + + /** +* The load balancer backend address pools of the Virtual

[jira] [Resolved] (JCLOUDS-1351) AWS CentOS marketplace AMI misdetecting OS type

2017-11-03 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1351. - Resolution: Fixed Fix Version/s: 2.1.0 > AWS CentOS marketplace AMI misdetect

[jira] [Updated] (JCLOUDS-1351) AWS CentOS marketplace AMI misdetecting OS type

2017-11-03 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1351: Labels: aws-ec2 (was: ) > AWS CentOS marketplace AMI misdetecting OS t

Re: [jclouds/jclouds] JCLOUDS-1351: fixes to correctly recognise and boot the official CentOS images from the AWS Marketplace (#1153)

2017-11-03 Thread Ignasi Barrera
Merged to master. Thanks @rdowner! Worth (and safe) to backport to 2.0.x? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1153#issuecomment-341655207

Re: [jclouds/jclouds] JCLOUDS-1351: fixes to correctly recognise and boot the official CentOS images from the AWS Marketplace (#1153)

2017-11-03 Thread Ignasi Barrera
Closed #1153. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1153#event-1324521329

Re: [jclouds/jclouds] JCLOUDS-1351: fixes to correctly recognise and boot the official CentOS images from the AWS Marketplace (#1153)

2017-11-03 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1153#pullrequestreview-74024311

Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)

2017-11-02 Thread Ignasi Barrera
nacx requested changes on this pull request. Thanks @code4clouds! We're almost there. There are a couple annotations still to be removed and I've tried to detail what tests should verify and how. > + + /** +* The subnet of the Virtual Machine Scale Set Ip Configuration Properties +*/

[jira] [Updated] (JCLOUDS-1350) AWS EC2 mis-detecting OS version of image

2017-11-02 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1350: Labels: aws-ec2 (was: ) > AWS EC2 mis-detecting OS version of im

[jira] [Updated] (JCLOUDS-1350) AWS EC2 mis-detecting OS version of image

2017-11-02 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1350: Component/s: jclouds-compute > AWS EC2 mis-detecting OS version of im

[jira] [Updated] (JCLOUDS-1348) CloudStack - template(image) IDs not unique

2017-11-02 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1348: Labels: cloudstack (was: ) > CloudStack - template(image) IDs not uni

[jira] [Updated] (JCLOUDS-1348) CloudStack - template(image) IDs not unique

2017-11-02 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1348: Component/s: (was: jclouds-drivers) jclouds-compute > CloudSt

Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)

2017-10-31 Thread Ignasi Barrera
nacx commented on this pull request. > +package org.jclouds.azurecompute.arm.domain; + +import com.google.auto.value.AutoValue; +import com.google.common.collect.ImmutableList; +import org.jclouds.javax.annotation.Nullable; +import org.jclouds.json.SerializedNames; + +import java.util.List; +

Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)

2017-10-26 Thread Ignasi Barrera
nacx commented on this pull request. > +package org.jclouds.azurecompute.arm.domain; + +import com.google.auto.value.AutoValue; +import com.google.common.collect.ImmutableList; +import org.jclouds.javax.annotation.Nullable; +import org.jclouds.json.SerializedNames; + +import java.util.List; +

Re: [jclouds/jclouds-labs] Azure ARM fix OSProfile domain object (#415)

2017-10-26 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/415#pullrequestreview-72137239

[jira] [Comment Edited] (JCLOUDS-1349) Backward compatibility report for Jclouds Compute Core

2017-10-26 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220222#comment-16220222 ] Ignasi Barrera edited comment on JCLOUDS-1349 at 10/26/17 9:35 AM

[jira] [Commented] (JCLOUDS-1349) Backward compatibility report for Jclouds Compute Core

2017-10-26 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220222#comment-16220222 ] Ignasi Barrera commented on JCLOUDS-1349: - Thanks! These reports are great. I see

Re: [jclouds/jclouds-labs] fix domain object (#414)

2017-10-25 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/414#pullrequestreview-71838067

Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)

2017-10-25 Thread Ignasi Barrera
nacx requested changes on this pull request. Thanks @code4clouds! Final comments added. Mostly related to the general comments I made about the use of the nullable annotation and tags field. I pointed out every item that still needs to be addressed, and added a comment about the mock tests. >

Re: [jclouds/jclouds] Exclude tier tests on OSX (#1150)

2017-10-25 Thread Ignasi Barrera
Closed #1150. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1150#event-1309207208

Re: [jclouds/jclouds] Exclude tier tests on OSX (#1150)

2017-10-25 Thread Ignasi Barrera
Merged to master as [f7b74d95](http://git-wip-us.apache.org/repos/asf/jclouds/commit/f7b74d95). -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1150#issuecomment-339231822

Re: [jclouds/jclouds] Define the JDK version in a Maven property (#1152)

2017-10-25 Thread Ignasi Barrera
If this works, the profile must also be defined in `jclouds-karaf` and `jclouds-cli`. I forgot those projects when merging the first PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[jclouds/jclouds] Define the JDK version in a Maven property (#1152)

2017-10-25 Thread Ignasi Barrera
This changes how we reference the toolchain to use a Maven property. This will allow us to be more flexible and generic when configuring builds in Jenkins and we can avoid having a dedicated maven profile for each JDK version we want to support. A property can be overridden in the command-line,

Re: [jclouds/jclouds] Exclude tier tests on OSX (#1150)

2017-10-24 Thread Ignasi Barrera
Ok, I've cleaned up the commits and the code, leaving just the proper test skip, as the other methods were already ok. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1150#issuecomment-339019323

Re: [jclouds/jclouds] Exclude tier tests on OSX (#1150)

2017-10-24 Thread Ignasi Barrera
> I think it is better to throw SkipException Done! -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1150#issuecomment-338887045

Re: [jclouds/jclouds] Exclude tier tests on OSX (#1150)

2017-10-24 Thread Ignasi Barrera
@nacx pushed 1 commit. 6e5357f Throw skip exceptions instead of silently passing tests -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1337: other putBlob portable storage tiers (#1151)

2017-10-24 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1151#pullrequestreview-71406314

[jclouds/jclouds] Exclude tier tests on OSX (#1150)

2017-10-23 Thread Ignasi Barrera
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1150 -- Commit Summary -- * Exclude tier tests on OSX -- File Changes -- M apis/filesystem/src/test/java/org/jclouds/filesystem/integration/FilesystemBlobIntegrationTest.java

Re: [jclouds/jclouds] Add Jenkins profile to use Maven toolchains (#1149)

2017-10-23 Thread Ignasi Barrera
Done: https://github.com/jclouds/jclouds/pull/1150 -- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1149#issuecomment-338790224

Re: [jclouds/jclouds] Add Jenkins profile to use Maven toolchains (#1149)

2017-10-23 Thread Ignasi Barrera
Sure I'll do. I was just guessing and asking before diving into the code :) I'll open a PR in short. Thanks for confirming! -- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Add Jenkins profile to use Maven toolchains (#1149)

2017-10-23 Thread Ignasi Barrera
And looks like everything is back to green! Thanks @gaul! It looks like failures only happen on my machine (but consistently). Is it possible that they fail on Mac? I recall some tests failing in the past because it did not support file attributes. Is the tier information stored there? That

Re: [jclouds/jclouds-labs] fix domain object (#414)

2017-10-23 Thread Ignasi Barrera
@andreaturli Apart from the Tier test failures it looks like there are actual test failures related to this change. Mind having a look? @gaul It looks like there are test failure sin jclouds-labs regarding the Tiers change. Mind having a look? -- You are receiving this because you are

Re: [jclouds/jclouds-labs] fix domain object (#414)

2017-10-23 Thread Ignasi Barrera
Builds should now be fixed, rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/414#issuecomment-338618947

Re: [jclouds/jclouds] Add Jenkins profile to use Maven toolchains (#1149)

2017-10-23 Thread Ignasi Barrera
I added one additional profile, jenkins-jdk8 to preconfigure the JDK8 toolchain. It's needed by how we have configured the "jclouds-compat" build, but I'm pretty sure we can clean that by using variables to define the jdk version and vendor instead of having two profiles. I'll have a look at

Re: [jclouds/jclouds] Add Jenkins profile to use Maven toolchains (#1149)

2017-10-23 Thread Ignasi Barrera
Ok. I think we're OK with the toolchains approach. I tried to script the scripts to bulk-update all the jobs in Jenkins but I got permission errors; I don't have permissions to run scripts and did not found where to configure that, so I've manually updated all HEAD, 2.0.x, live test and pull

Re: [jclouds/jclouds] Add Jenkins profile to use Maven toolchains (#1149)

2017-10-16 Thread Ignasi Barrera
Back to green. Thanks @demobox! WDYT about the toolchain approach? Shall we go for it? @gaul are the Tier fixes OK? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-site] Fix link for a Stack Overflow answer relating to Java HTTP clients and POODLE (#201)

2017-10-16 Thread Ignasi Barrera
The branch needs to be pushed to the ASF remote :) Anyway, LGTM, so feel free to push it directly to master! -- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Add Jenkins profile to use Maven toolchains (#1149)

2017-10-16 Thread Ignasi Barrera
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1149#issuecomment-336810594

Re: [jclouds/jclouds] Add Jenkins profile to use Maven toolchains (#1149)

2017-10-16 Thread Ignasi Barrera
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1149#issuecomment-336799667

Re: [jclouds/jclouds] Add Jenkins profile to use Maven toolchains (#1149)

2017-10-16 Thread Ignasi Barrera
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1149#issuecomment-336798769

Re: [jclouds/jclouds] Add Jenkins profile to use Maven toolchains (#1149)

2017-10-16 Thread Ignasi Barrera
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1149#issuecomment-336798479

Re: [jclouds/jclouds] Add Jenkins profile to use Maven toolchains (#1149)

2017-10-16 Thread Ignasi Barrera
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1149#issuecomment-336797003

Re: [jclouds/jclouds] Add Jenkins profile to use Maven toolchains (#1149)

2017-10-16 Thread Ignasi Barrera
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1149#issuecomment-336796459

[jclouds/jclouds] Add Jenkins profile to use Maven toolchains (#1149)

2017-10-16 Thread Ignasi Barrera
This is a PR to experiment with Maven toolchains approach to let Jenkins use the right JDK to build jclouds. Do not merge yet. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1149 -- Commit Summary -- * Add Jenkins profile to use

Re: [jclouds/jclouds-labs] fix domain object (#414)

2017-10-13 Thread Ignasi Barrera
@demobox have you seen this issue before? Looks like a bug in CloudBees we could report? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/414#issuecomment-336401374

Re: [jclouds/jclouds-labs] fix domain object (#414)

2017-10-13 Thread Ignasi Barrera
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/414#issuecomment-336372593

Re: [jclouds/jclouds-labs] JCLOUDS-1304: add azure customdata, JCLOUDS-1305: add support for ssh keys in keyvault (#398)

2017-10-10 Thread Ignasi Barrera
>Do you have thoughts on externalizing the tenantId which is hard coded in the >live test? I don't have the context of the discussion, but isn't it part of the `oauth.endpoint` property? It could be parsed and exposed, for example in a provider method in the AzureHttpApiModule so it can be

Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)

2017-10-09 Thread Ignasi Barrera
nacx commented on this pull request. > +VirtualMachineScaleSetDNSSettings dnsSettings = > VirtualMachineScaleSetDNSSettings.create(dnsList); + +NetworkInterfaceConfigurationProperties networkInterfaceConfigurationProperties = +

Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)

2017-10-09 Thread Ignasi Barrera
nacx requested changes on this pull request. Thanks for the fixes @code4clouds! Still some comments to address. Also, in general, remove the `@Nullable` annotation from all the collection fields where we enforce presence and immutability. The annotation should only be present where users can

Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)

2017-10-09 Thread Ignasi Barrera
>Do you take the changes from the amends added or should I create a new PR? No need to open a new PR. Thanks for the fixes! I'll review it now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Token based authentication in openstack-keystone (#433)

2017-10-05 Thread Ignasi Barrera
Apologies for the huge delay @pimenas . The original reviewers are not active in the project and the PR got unattended. The changes LGTM. @andreaturli Mind having a look? If you approve the changes I'll merge the PR. -- You are receiving this because you are subscribed to this thread. Reply to

Re: [jclouds/jclouds-labs] JCLOUDS-1342 : Azure-ARM Virtual Machine Scale Set Support (#412)

2017-10-05 Thread Ignasi Barrera
nacx requested changes on this pull request. Thanks, @code4clouds! Just some general considerations apart from the existing comments: * jclouds uses a 3 space indent. Please, format the code using our [coding standards](https://cwiki.apache.org/confluence/display/JCLOUDS/Coding+Standards). *

Re: [jclouds/jclouds-labs] JCLOUDS-1304: add azure customdata, JCLOUDS-1305: add support for ssh keys in keyvault (#398)

2017-09-29 Thread Ignasi Barrera
I've extracted the `customData` stuff and pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/c9f272b9) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/eec594dd). Should we better close this pull request and work on keyvault in a new one? --

[jira] [Resolved] (JCLOUDS-1282) Support custom-data in Azure ARM template options

2017-09-29 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1282. - Resolution: Fixed Fix Version/s: 2.0.3 2.1.0 > Support cus

Re: [jclouds/jclouds] JCLOUDS-769: streaming putBlob (#1129)

2017-09-18 Thread Ignasi Barrera
I've finally had some time to look at this. Thanks for starting this proposal! I like the idea of having the API methods return a stream clients can write to, but I'm not sure about several things that are needed to have that. It's weird for me to have an OutputStream in the HttpResponse. If I

Re: [jclouds/jclouds-labs] [ARM] IpOption will allocate a public ip when a network is specified (#411)

2017-09-13 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/411#pullrequestreview-62401089

[jira] [Commented] (JCLOUDS-1330) Azure ARM orphaned networks not cleaned up when node deleted

2017-09-12 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162686#comment-16162686 ] Ignasi Barrera commented on JCLOUDS-1330: - I'd say, when deleting a node, we should delete

[jira] [Resolved] (JCLOUDS-1304) Azure: Support for custom data during VM creation to support the injection of cloud-init user-data

2017-09-12 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1304. - Resolution: Fixed Thanks, [~jmspring], it is a duplicate. > Azure: Support for cus

[jira] [Updated] (JCLOUDS-1282) Support custom-data in Azure ARM template options

2017-09-12 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1282: Affects Version/s: 2.0.2 > Support custom-data in Azure ARM template opti

Re: [jclouds/jclouds-labs] JCLOUDS-1328 Update ProfitBricks to the latest API version (#408)

2017-09-12 Thread Ignasi Barrera
I meant, auth failures when tests try to access the nodes. Credentials are working fine. Aren't you using a custom image? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1340: Disable BackoffLimitedRetryHandlerTest (#1145)

2017-09-12 Thread Ignasi Barrera
nacx approved this pull request. LGTM. I don't think these tests provide *real* value to the functionality of the class. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] JCLOUDS-1328 Update ProfitBricks to the latest API version (#408)

2017-09-08 Thread Ignasi Barrera
> all tests passes now. @alibazlamit have you executed them with any custom parameter? I've run them just providing the credentials and I get authentication failures. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] JCLOUDS-1328 Update ProfitBricks to the latest API version (#408)

2017-09-08 Thread Ignasi Barrera
Closed #408. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/408#event-1240211444

[jira] [Resolved] (JCLOUDS-1328) Update ProfitBricks to the latest API version

2017-09-08 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1328. - Resolution: Fixed Fix Version/s: 2.0.3 2.1.0 > Upd

[jira] [Updated] (JCLOUDS-1328) Update ProfitBricks to the latest API version

2017-09-08 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1328: Labels: profitbricks (was: ) > Update ProfitBricks to the latest API vers

[jira] [Updated] (JCLOUDS-1328) Update ProfitBricks to the latest API version

2017-09-08 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1328: Affects Version/s: 2.0.2 > Update ProfitBricks to the latest API vers

[jira] [Resolved] (JCLOUDS-1258) Amazon China Beijing Region Support

2017-09-08 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1258. - Resolution: Fixed Fix Version/s: (was: 2.0.2) 2.0.3

Re: [jclouds/jclouds] JCLOUDS-1258: Allow China endpoints in FormSignerV4 (#1142)

2017-09-08 Thread Ignasi Barrera
Squashed and merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/1c1f81c3) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/cfdbc810). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1258: Allow China endpoints in FormSignerV4 (#1142)

2017-09-07 Thread Ignasi Barrera
@nacx pushed 1 commit. 1a8f45e Remove check -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1142/files/0f536f4f48bcb38b594f455c4826de39c023e136..1a8f45e40ae22fab167298be8a145d5b203f32d9

Re: [jclouds/jclouds] JCLOUDS-1258: Allow China endpoints in FormSignerV4 (#1142)

2017-09-07 Thread Ignasi Barrera
Done. Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1142#issuecomment-327826026

Re: [jclouds/jclouds-labs] JCLOUDS-1328 Update ProfitBricks to the latest API version (#408)

2017-09-07 Thread Ignasi Barrera
That's great, thanks @alibazlamit! Mind squashing the commits so we can cleanly merge the PR? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/408#issuecomment-327812113

[jira] [Commented] (JCLOUDS-1258) Amazon China Beijing Region Support

2017-09-07 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156992#comment-16156992 ] Ignasi Barrera commented on JCLOUDS-1258: - Fix for the FormSignerV4: https://github.com/jclouds

<    4   5   6   7   8   9   10   11   12   13   >