Thx for the quick patch, btw! :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/24#issuecomment-41394507
>your first comment is a very good spot: maybe better to remove the
>checkNotNull, ok?
I'm not sure. I'd prefer to wait for some more feedback in the [discussion in
mailing list](http://markmail.org/message/2mt3ijd4u7lbkwpz).
>For you second comment: would it make sense to add a tag to the hard
> @@ -36,6 +36,11 @@
>
>
>
> +
How will this look like if there are quick news? If they show as two separate
boxes, will that be good-looking?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89/file
> @@ -36,6 +36,11 @@
>
>
>
> +
> +The latest version is {{ site.latest_version }} released
> on {{ site.latest_version_date }}! Read the release notes.
Make the "latest version" a link to the install page? When looking at the
staging
Thx @everett-toews ! Looks great to have the latest release in the main page!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89#issuecomment-41415813
I think the cleanest way will be to create your own
[MapBinder](https://github.com/jclouds/jclouds/blob/master/core/src/main/java/org/jclouds/rest/MapBinder.java):
You'll have to create a class that implements that interface (usually also
subclassing the
[BindToJsonPayload](https://github.com/j
Closed #44.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/44
[Merged](https://git-wip-us.apache.org/repos/asf?p=jclouds-examples.git;a=commit;h=82f3903e089ca081c74e4288da4d4a7f38ba9abf).
Thanks @mikolajz!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/44#issuecomment-41508715
> @@ -13,7 +13,7 @@
>
>
>
> - href="https://wiki.apache.org/jclouds/How%20to%20Contribute%20Documentation";>Fix
> This Page
> + href="https://github.com/jclouds/jclouds-site/edit/master/{{ page.path
> }}">Fix This Page href="https:
Looks nice! Thx!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/89#issuecomment-41646430
Sorry for the delay; it's been a crazy week! Finally I've had some time to test
this and it works :)
I've compiled your pull request and then the CLI, and I've run the following
test with it:
* Created a new node in DigitalOcean with a newly generated (and
password-protected) key. I created it
+1!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/43#issuecomment-42159397
The artifact [exists in the Apache snapshot
repo](http://repository.apache.org/content/groups/snapshots/org/apache/jclouds/labs/management/management-core/1.7.3-SNAPSHOT/).
Can it be something about the build config?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclou
Thanks for the update @Phanatic!
Is the v2 the only version available for **new accounts**, or have existing v1
accounts already been upgraded to v2?
If existing accounts still can use the v1 version, then changing the provider
metadata might break existing code. If the v1 offering does no long
Yep, LGTM! Thx!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/45#issuecomment-42314102
In that case I think we should better change now the default in the metadata.
Thanks for the feedback @Phanatic!
All contributions are assumed to be under the Apache ICLA (see the [how to
contribute wiki page](https://wiki.apache.org/jclouds/How%20to%20Contribute)),
so you don't need to explici
> + for (Entry header : canonicalizedHeadersMap.entries())
> {
> + String key = header.getKey();
> + canonicalizedHeadersBuffer.append(String.format("%s:%s\n",
> key.toLowerCase(), header.getValue()));
> + }
> + return canonicalizedHeadersBuffer.toString();
> + }
Reopened #59.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/59#event-118688656
It's good to see progress on this and that you're getting familiar with the
jclouds internals. Don't get intimidated by the reviews!
Nice job @rcoedo!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/3#issuecomment-42649933
Addressed the comments and added a unit test. Will amend the typo in the commit
message when squashing the commits before merging.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/59#issuecomment-42521849
> @@ -107,7 +107,7 @@ public SSHClientConnection build() {
>
>protected Builder fromSSHClientConnection(SSHClientConnection in) {
> return
> hostAndPort(in.getHostAndPort()).connectTimeout(in.getConnectTimeout()).loginCredentials(
> - in.getLoginCredentials());
> +import java.io.IOException;
> +import java.net.URL;
> +import java.util.Properties;
> +import java.util.Set;
> +
> +import org.jclouds.ContextBuilder;
> +import org.jclouds.concurrent.config.ExecutorServiceModule;
> +import org.testng.annotations.Test;
> +
> +import com.google.common.collect.Imm
> + } catch (IOException e) {
> + throw new HttpException("Error signing request", e);
> + }
> + return hashedPayload;
> + }
> +
> + private byte[] hmacSha256(byte[] key, String s) {
> + try {
> + Mac hmacSHA256 = crypto.hmacSHA256(key);
> + return hm
Closed #59.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/59#event-118663905
Just removed the unnecessary calls to `verify`. If someone changes the
predicate in such a way, we can discuss the details and the proper tests in the
review :) Let's keep this test just testing the expected functionality.
---
Reply to this email directly or view it on GitHub:
https://github.com
Yep. You can't have parameterized classes in the annotations, as the type of
the generic parameter belongs to the instance of the object and not the
definition of the class, which is what you need in the annotations.
I don't like the idea of returning `null`, as the api will behave different
th
Pushed to
[master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=aef9fc8d8399483cca9a874bc60327c70cca74c4)
and
[1.7.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=9398373f94c1e31eb49ef056e07f877b85ce9854).
---
Reply to this email directly or view it on Gi
This implicitly updates the RAT plugin from 0.8 to 0.10, which is not throwing
the thread-safe warnings when building modules concurrently.
You can merge this Pull Request by running:
git pull https://github.com/nacx/jclouds parent-pom
Or you can view, comment on it, or merge it online at:
jclouds-karaf and jclouds-chef will also need to be updated.
```bash
$ find . -name pom.xml | grep -v target | xargs grep -nH '13' -B2
jclouds-chef/project/pom.xml-23-org.apache
jclouds-chef/project/pom.xml-24-apache
jclouds-chef/project/pom.xml:25:13
--
jclouds-karaf/pom.xml-22-or
You can merge this Pull Request by running:
git pull https://github.com/nacx/jclouds-karaf parent-pom
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-karaf/pull/46
-- Commit Summary --
* JCLOUDS-563: Upgrade parent pom to version 14
-- File Cha
Here are the related PRs:
https://github.com/jclouds/jclouds-chef/pull/44
https://github.com/jclouds/jclouds-karaf/pull/46
Will merge all them together once all builds have passed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/361#issuecomment-4283
Closed #331.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/331#event-120162125
GitHub does not seem to properly detect the rebased commits after reopening.
Will open a new pull request.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/331#issuecomment-42845738
You can merge this Pull Request by running:
git pull https://github.com/nacx/jclouds-chef parent-pom
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-chef/pull/44
-- Commit Summary --
* JCLOUDS-563: Upgrade parent pom to version 14
-- File Chang
Pushed to
[master](https://git-wip-us.apache.org/repos/asf?p=jclouds-karaf.git;a=commit;h=53cde3c2c680142a93f8637aef263165c631d704).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/46#issuecomment-42850522
Closed #46.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/46#event-120178935
Just checkstyle. Will merge in a while.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/46#issuecomment-42849687
Amended the commit message and
[merged](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=2bbbe1d5fdf7849bcb9ff5c4cf1868c0afd5ec8f).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/361#issuecomment-42850376
This PR is a follow-up for https://github.com/jclouds/jclouds/pull/331 and adds
all fixed and suggested improvements. /cc @demobox @AudriusButkevicius
TL;DR: ElasticHosts providers use an API call to get the list of images except
ServerLove, which runs an old api, that still hardcodes it. Also a
I'm not sure. It won't affect the code but could affect the release process,
although I'm sure nothing will break.
I'm OK to backport it, do you think it is worth it?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/361#issuecomment-42855965
Pushed to
[master](https://git-wip-us.apache.org/repos/asf?p=jclouds-chef.git;a=commit;h=aed1c5371c199d5ddf448c50c4cdcf494e1310e8).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/44#issuecomment-42850438
Closed #44.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/44#event-120178652
> +
> +1. [Introduction](#intro)
> +2. [Authentification](#auth)
> +2. [Running examples](#examples)
> +
> +
> +## Introduction
> +This guide helps you to get started with [Google Cloud
> Platform](https://cloud.google.com/) development using jclouds.
> +
> +Currently, [Google Compute Engine](http
> @@ -0,0 +1,40 @@
> +---
> +layout: page
There is a `toc` layout that will automatically add the TOC at the top of the
page. The TOC list uses bullets instead of a numbered list (and the TOC system
is still in progress).
There's no need to change to change the layout, it is just FYI :) Use it i
> +This guide helps you to get started with [Google Cloud
> Platform](https://cloud.google.com/) development using jclouds.
> +
> +Currently, [Google Compute Engine](https://developers.google.com/compute/)
> is covered. This is a service that allows you to run vitual machines on
> Google's infra
It's great to have documentation contributions. Thanks @mikolajz!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/98#issuecomment-42882030
> @@ -107,7 +107,7 @@ public SSHClientConnection build() {
>
>protected Builder fromSSHClientConnection(SSHClientConnection in) {
> return
> hostAndPort(in.getHostAndPort()).connectTimeout(in.getConnectTimeout()).loginCredentials(
> - in.getLoginCredentials());
> @@ -176,6 +177,7 @@ String replace(@PathParam("objectName") String
> objectName, @BinderParam(SetPaylo
> @POST
> @Fallback(FalseOnNotFoundOr404.class)
> @Path("/{objectName}")
> + @RequestFilters(FixContentTypeHeader.class)
Out of curiosity. **Must** the Content-Type header be an
>I am unsure if a live test makes sense though.
I think the mock test is enough to verify the change.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/97#issuecomment-42925880
>There are eight Checkstyle warnings in DO, by the way, but none related to
>this PR, I think.
Will address them in a new PR. Thanks @demobox !
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/59#issuecomment-42928272
Pushed to
[master](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs.git;a=commit;h=e255b82ce80f1abb0cf5440498b70692982e2612).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/59#issuecomment-42928966
Merge to 1.7.x didn't present conflicts and build passed. Pushed
[there](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs.git;a=commit;h=1b04f7076213a457a6ca2d671e6106559c907865)
too.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/59#iss
Addressed checkstyle violations (most caused by imports for class references in
javadocs) and removed deprecated methods usage.
/cc @demobox
You can merge this Pull Request by running:
git pull https://github.com/nacx/jclouds-labs checkstyle
Or you can view, comment on it, or merge it online
> @@ -176,6 +177,7 @@ String replace(@PathParam("objectName") String
> objectName, @BinderParam(SetPaylo
> @POST
> @Fallback(FalseOnNotFoundOr404.class)
> @Path("/{objectName}")
> + @Produces("")
This is how all jclouds apis work. They're widely used so I don't think a
comment here
Thanks for thw ping @demobox! I started this but completely forgot! :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/58#issuecomment-43013772
The changes LGTM now. Just one minor thing @andreaturli. Can you remove the
wild card import, please?
@demobox @mikolajz If you don't have any other comments, I'll merge this as
soon as the wildcard imports are removed.
---
Reply to this email directly or view it on GitHub:
https://github.com/j
I plan to merge the checkstyle PR tomorrow and then open a new one adding the
test classes. So in a day or two everything should be in place to make it
trivial to add the missing tests!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/58#issueco
> +
> + public static final String AUTH_TAG = "AWS4";
> + public static final String HEADER_TAG = "x-amz-";
> + public static final String ALGORITHM = AUTH_TAG + "-HMAC-SHA256";
> + public static final String TERMINATION_STRING = "aws4_request";
> + public static final String REGION = "us
>Do we need any (unit) tests for this?
I'm not sure if they will provide any value or just make them difficult to
maintain. Tests won't detect this case, where a new property added to the
builder is missing when copying it. I thought about adding the test, but
thinking about it, testing the "fr
Closed #358.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/358#event-119025508
> + Properties overrides = new Properties();
> + // prevent expect-100 bug
> http://code.google.com/p/mockwebserver/issues/detail?id=6
> + overrides.setProperty(PROPERTY_SO_TIMEOUT, "0");
> + overrides.setProperty(PROPERTY_MAX_RETRIES, "1");
> + return ContextBuilder.newBu
> +
> + public EventDonePredicate(DigitalOceanApi api) {
> + this.api = checkNotNull(api, "api must not be null");
> + }
> +
> + @Override
> + public boolean apply(Integer input) {
> + Event event = api.getEventApi().get(input);
> + switch (event.getStatu
> @@ -148,12 +134,31 @@ public boolean apply(Integer input) {
> @Named(TIMEOUT_IMAGE_AVAILABLE)
> protected Predicate provideImageAvailablePredicate(final
> DigitalOceanApi api, Timeouts timeouts,
> PollPeriod pollPeriod) {
> - return Predicates2.retry(new Predicate() {
> -
Refactored the event status predicates to reuse the code. Also made them abort
the polling if the error state is reached, in the same way the default Atomic*
predicates of the ComputeService do it, to keep the behavior consistent.
Also updated the default image, as DigitalOcean recently changed
> +${test.aws.identity}
> +${test.aws.credential}
> +
> +
> org.jclouds.glacier*;version="${project.version}"
> +
> +org.jclouds.labs*;version="${project.version}",
> +org.jclouds*;version="${project.version}",
> +*
> +
> +
> +
> +
> +
> + co
> + .buildApi(GlacierClient.class);
> + }
> +
> + public void experiments() throws IOException, InterruptedException {
> + MockWebServer server = new MockWebServer();
> + server.enqueue(new MockResponse().addHeader(ETAG, "Testing"));
> + // hangs on Java
> +public class EventDonePredicateTest {
> +
> + public void testEventProgress() {
> + EventApi eventApi = EasyMock.createMock(EventApi.class);
> + DigitalOceanApi api = EasyMock.createMock(DigitalOceanApi.class);
> +
> + expect(eventApi.get(1)).andReturn(event(Status.DONE));
> +
> +
> + @Resource
> + @Named(Constants.LOGGER_SIGNATURE)
> + Logger signatureLog = Logger.NULL;
> +
> + private final Provider timeStampProvider;
> + private final HttpUtils utils;
> +
> + @Inject
> + public RequestAuthorizeSignature(
> + @TimeStamp Provider timeStampProvider,
> + utils.logRequest(signatureLog, request, ">>");
> + request = this.signer.sign(request);
> + utils.logRequest(signatureLog, request, "<<");
> + return request;
> + }
> +
> + HttpRequest replaceDateHeader(HttpRequest request) {
> + request = request.toBuilder().remove
Fix for: https://issues.apache.org/jira/browse/JCLOUDS-544
A backport to 1.7.x would be appreciated
You can merge this Pull Request by running:
git pull https://github.com/nacx/jclouds-labs error-enum
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-l
Fix for https://issues.apache.org/jira/browse/JCLOUDS-561
Will need to be backported to 1.7.x
You can merge this Pull Request by running:
git pull https://github.com/nacx/jclouds sshagent-npe
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/358
@demobox @cobbzilla I've just opened
https://github.com/jclouds/jclouds-labs/pull/62 adding the missing tests.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/58#issuecomment-43331423
You can merge this Pull Request by running:
git pull https://github.com/nacx/jclouds-labs unittests
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs/pull/62
-- Commit Summary --
* Added unit tests for compute functions
-- File Changes --
Neat! Pushed to
[master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=a623e68d08b89bb2af952153912ba669108ffb77).
Thanks @ccustine!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/376#issuecomment-43454841
>Needs a single space before the end tag
You commented while I was running the build locally. I've already added the
space and removed the trailing ones.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/376#issuecomment-43454919
@demobox good to go?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/98#issuecomment-43455111
Thanks @aledsage! The change LGTM.
Reading the code, I don't think it makes sense to have two getters for the
credentials, one returning an object and another one returning the object
itself. I think it would make sense to remove the `@Nullable` annotation from
the "optional" method, because ev
This is also affecting the Jenkins plugin:
https://issues.jenkins-ci.org/browse/JENKINS-22963
As commented in the issue there, now that thay've addwd support for slugs
everywhere I think the right fix would be to use them everywhere instead of the
ids. I'll try to have a PR for that soon if you
> + @Override
> + public String apply(Image input) {
> + return input.getId();
> + }
> +});
> + }
> + };
> +
> + GroupNamingConvention.Factory namingConvention =
> Guice.createInjector(new AbstractModule() {
>
> + public void testPublicKeyDoesNotGenerateStatement() {
> + Map keys = SshKeys.generate();
> + TemplateOptions options =
> TemplateOptions.Builder.authorizePublicKey(keys.get("public"));
> +
> + TemplateOptionsToStatementWithoutPublicKey function = new
> TemplateOptionsToStatem
I think there are not unhappy paths here. The mocks contain what the DO API
returns, and it is always the same. The API always returns the expected fields,
so I think we just have to test the conversion itself.
The only unhappy path I can come up with is the `null` image id, but that case
shoul
> +.volume(new
> VolumeBuilder().size(20f).type(Type.LOCAL).build()).build());
> +
> + locations = ImmutableSet.of(new LocationBuilder()
> +.id("1")
> +.description("1/mock location")
> +.scope(LocationScope.REGION)
> +.parent(
> +
> +import com.google.common.base.Suppliers;
> +import com.google.common.collect.ImmutableSet;
> +
> +/**
> + * Unit tests for the {@link RegionToLocation} class.
> + *
> + * @author Ignasi Barrera
> + */
> +@Test(groups = "unit", testName = &q
> + * Unit tests for the {@link TemplateOptionsToStatementWithoutPublicKey}
> class.
> + *
> + * @author Ignasi Barrera
> + */
> +@Test(groups = "unit", testName =
> "TemplateOptionsToStatementWithoutPublicKeyTest")
> +public class Te
@demobox could have a quick look at this? I've already created
https://github.com/nacx/jclouds-labs/commit/da9c8a2a50941845d0548f81cd7a43663dca1e37
to fix [JCLOUDS-543](https://issues.apache.org/jira/browse/JCLOUDS-543) and
[JCLOUDS-572](https://issues.apache.org/jira/browse/JCLOUDS-572), but it
> + public void testPublicKeyDoesNotGenerateStatement() {
> + Map keys = SshKeys.generate();
> + TemplateOptions options =
> TemplateOptions.Builder.authorizePublicKey(keys.get("public"));
> +
> + TemplateOptionsToStatementWithoutPublicKey function = new
> TemplateOptionsToStatem
> + assertEquals(statement.render(OsFamily.UNIX), "uptime\n");
> + }
> +
> + @Test
> + public void
> testPublicAndPrivateKeyAndRunScriptDoesNotGenerateAuthorizationStatement() {
> + Map keys = SshKeys.generate();
> + TemplateOptions options =
> TemplateOptions.Builder.authori
> + public void testPublicKeyDoesNotGenerateStatement() {
> + Map keys = SshKeys.generate();
> + TemplateOptions options =
> TemplateOptions.Builder.authorizePublicKey(keys.get("public"));
> +
> + TemplateOptionsToStatementWithoutPublicKey function = new
> TemplateOptionsToStatem
Thanks for the quick review!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/62#issuecomment-43521164
Pushed to [master](c6ec944901d449ff7ca626d721902577f5756fb1) and
[1.7.x](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs.git;a=commit;h=3bb5e5cae65fb6673f84041ce57d4ff090fb1abf).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/62#issuecom
Use slugs as IDs and assume a node can have a `null` image if it used an
imageId that has been removed.
With this change the objects in the portable model will have the
"slug" in the ID field and the real ID in the "providerId"
field. Private images, which don't have a slug, will also have the
I've just opened https://github.com/jclouds/jclouds-labs/pull/63 adding support
for using the "slug" values as IDs to properly fix the entire thing, now that
we know more a bit more about the DO api. It was not as straightforward as I
had initially supposed (now methods have been added to the ap
> @@ -116,7 +117,14 @@ public boolean
> apply(org.jclouds.digitalocean.domain.Image input) {
> @Override
> public boolean deleteImage(String id) {
>try {
> - api.getImageApi().delete(Integer.parseInt(id));
> + // The id of the image can be an id or a slug. Use the
> @@ -116,7 +117,14 @@ public boolean
> apply(org.jclouds.digitalocean.domain.Image input) {
> @Override
> public boolean deleteImage(String id) {
>try {
> - api.getImageApi().delete(Integer.parseInt(id));
> + // The id of the image can be an id or a slug. Use the
> @@ -113,4 +111,43 @@ public boolean apply(Location location) {
>
>return builder.build();
> }
> +
> + private Optional findImage(Integer id) {
> + // Try to find the image by ID in the cache. The cache is indexed by
> slug (for public images) and by id (for
> + // priva
> @@ -169,7 +170,10 @@ public boolean apply(Droplet droplet) {
>
> @Override
> public Image getImage(String id) {
> - return api.getImageApi().get(Integer.parseInt(id));
> + // The id of the image can be an id or a slug. Use the corresponding
> method of the API depending on wh
I've addressed the comments and added a couple improvements:
* Extracted the region id+name encoding logic into a `LocationNamingUtils`
class, to avoid exposing it in many places.
* Removed an unnecessary call to the provider in the `ComputeServiceAdapter` to
get the details of the location, and
You can merge this Pull Request by running:
git pull https://github.com/nacx/jclouds compute-teardown
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/377
-- Commit Summary --
* JCLOUDS-573: Make sure to destroy all nodes created in the test
>jclouds-pull-requests #816 FAILURE
It seems a Java 6 compilation error. The Java 7 build seems to be fine.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/377#issuecomment-43613520
I'll let the Java 7 build finish and then submit a fix to make it work in both
versions.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/377#issuecomment-43613812
901 - 1000 of 2366 matches
Mail list logo
