[jira] [Commented] (JCLOUDS-296) Remove async interface from cloudservers (legacy rackspace API/providers)

2014-09-09 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127940#comment-14127940 ] Jeremy Daggett commented on JCLOUDS-296: PR Master: https://github.com/jclouds

[jira] [Created] (JCLOUDS-716) Remove Rackspace First-Gen Cloud Servers

2014-09-09 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-716: -- Summary: Remove Rackspace First-Gen Cloud Servers Key: JCLOUDS-716 URL: https://issues.apache.org/jira/browse/JCLOUDS-716 Project: jclouds Issue Type

[jira] [Resolved] (JCLOUDS-296) Remove async interface from cloudservers (legacy rackspace API/providers)

2014-09-09 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett resolved JCLOUDS-296. Resolution: Done Fix Version/s: 1.8.1 The Rackspace First-Gen Cloud Servers Product

[jclouds-examples] Explicitly specify region in Rackspace GenerateTempURL example (#65)

2014-09-08 Thread Jeremy Daggett
This PR updates the `GenerateTempURL` example to specifically use the `RegionScopedBlobStoreContext` APIs that take a region argument, i.e. `RegionScopedBlobStoreContext.getBlobStore()` -gt; `RegionScopedBlobStoreContext.getBlobStore(REGION)` Imports have been cleaned up, and the creation of a

[jira] [Commented] (JCLOUDS-592) GenerateTempURL example logs warning when using RegionScopedBlobStoreContext

2014-09-08 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125853#comment-14125853 ] Jeremy Daggett commented on JCLOUDS-592: https://github.com/jclouds/jclouds

Re: [jclouds] Add copyBlob to portable abstraction and add S3-optimized variant (#511)

2014-09-06 Thread Jeremy Daggett
@@ -307,4 +314,31 @@ public boolean apply(String in) { */ protected abstract boolean deleteAndVerifyContainerGone(String container); + @Override + public ListenableFutureString copyBlob(String fromContainer, String fromName, String toContainer, String toName, +

[jira] [Assigned] (JCLOUDS-683) Promote oauth API

2014-09-05 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett reassigned JCLOUDS-683: -- Assignee: Jeremy Daggett Promote oauth API - Key

[jira] [Updated] (JCLOUDS-683) Promote oauth API

2014-09-05 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett updated JCLOUDS-683: --- Assignee: Chris Custine (was: Jeremy Daggett) Promote oauth API

Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-05 Thread Jeremy Daggett
Closed #503. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503#event-161785237

Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-05 Thread Jeremy Daggett
Reopened #503. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503#event-161785249

Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-05 Thread Jeremy Daggett
Closed #503. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503#event-161799439

Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-05 Thread Jeremy Daggett
Pushed to master 15d8166 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/503#issuecomment-54638739

[jira] [Resolved] (JCLOUDS-699) Properly deprecate zonescoped domain objects

2014-09-05 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett resolved JCLOUDS-699. Resolution: Fixed Fix Version/s: 1.8.1 Properly deprecate zonescoped domain

[jira] [Updated] (JCLOUDS-669) jclouds-cli support for openstack-swift

2014-09-05 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett updated JCLOUDS-669: --- Summary: jclouds-cli support for openstack-swift (was: openstack-swift is not supported

[jira] [Resolved] (JCLOUDS-341) testPublicAccess fails against openstack-swift

2014-09-05 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett resolved JCLOUDS-341. Resolution: Not a Problem Fix Version/s: 1.8.1 testPublicAccess fails against

[jira] [Commented] (JCLOUDS-341) testPublicAccess fails against openstack-swift

2014-09-05 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14123081#comment-14123081 ] Jeremy Daggett commented on JCLOUDS-341: This specific test will not work against

Re: [jclouds] Configures Checkstyle plugin to fail build on warnings (#464)

2014-09-05 Thread Jeremy Daggett
The submission of [JIRA-709](https://issues.apache.org/jira/browse/JCLOUDS-709) provides the necessary motivation to merge this PR today. If I don't hear anything by 2pm today, its going into the build. :+1: --- Reply to this email directly or view it on GitHub:

[jira] [Created] (JCLOUDS-710) OpenStack Keystone should use Guava MediaType

2014-09-05 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-710: -- Summary: OpenStack Keystone should use Guava MediaType Key: JCLOUDS-710 URL: https://issues.apache.org/jira/browse/JCLOUDS-710 Project: jclouds Issue

[jira] [Created] (JCLOUDS-711) Improve 409 Exception handling in SwiftErrorHandler

2014-09-05 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-711: -- Summary: Improve 409 Exception handling in SwiftErrorHandler Key: JCLOUDS-711 URL: https://issues.apache.org/jira/browse/JCLOUDS-711 Project: jclouds

Re: [jclouds-labs-openstack] OpenStack Heat Support (#138)

2014-09-04 Thread Jeremy Daggett
@nacx I made your suggested changes, thx! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/138#issuecomment-54504007

Re: [jclouds] Nova API Updates (#505)

2014-09-04 Thread Jeremy Daggett
Closed #505. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/505#event-161308844

Re: [jclouds-labs-openstack] Glance API ListImageOptions should support changesSince() (#137)

2014-09-04 Thread Jeremy Daggett
Closed #137. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/137#event-161314564

Re: [jclouds] JCLOUDS-686: Remove changesSince() query from base PaginationOptions (#499)

2014-09-04 Thread Jeremy Daggett
@@ -44,7 +42,12 @@ public PaginationOptions queryParameters(MultimapString, String queryParams) { /** * Only return objects changed since this time. +* +* @deprecated The {@code changes-since} query does not apply to all OpenStack APIs. Please refer to the OpenStack +

Re: [jclouds-labs-openstack] Glance API ListImageOptions should support changesSince() (#137)

2014-09-04 Thread Jeremy Daggett
Pushed to master 9782342 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/137#issuecomment-54510551

[jira] [Created] (JCLOUDS-705) Support OpenStack Swift Storage Policies

2014-09-04 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-705: -- Summary: Support OpenStack Swift Storage Policies Key: JCLOUDS-705 URL: https://issues.apache.org/jira/browse/JCLOUDS-705 Project: jclouds Issue Type

Re: [jclouds-labs-openstack] Cleans up neutron code (#139)

2014-09-03 Thread Jeremy Daggett
@@ -38,7 +38,7 @@ public String toString() { return name(); } - /** + /* Same as above! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/139/files#r17063978

Re: [jclouds-labs-openstack] Cleans up neutron code (#139)

2014-09-03 Thread Jeremy Daggett
@@ -40,7 +40,7 @@ public String toString() { return name; } - /** `/**` was OK here, so why the change? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/139/files#r17063974

Re: [jclouds-labs-openstack] Cleans up neutron code (#139)

2014-09-03 Thread Jeremy Daggett
- Rule newSecGroupRule = null; - for(Rule sgr : securityGroup.getRules()) { -if(sgr.getId().equals(rule.getId())) { - newSecGroupRule = sgr; - break; -} - } - assertNotNull(newSecGroupRule, Did not find

Re: [jclouds-labs-openstack] Cleans up neutron code (#139)

2014-09-03 Thread Jeremy Daggett
There are other instances where `/**` changed to `/*` and if you could revert those changes that would be awesome! +1 once the changes and other comments have been addressed. --- Reply to this email directly or view it on GitHub:

Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-03 Thread Jeremy Daggett
@everett-toews The `AvailabilityZone` domain classes are also in the incorrect location I created [JCLOUDS-700](https://issues.apache.org/jira/browse/JCLOUDS-700) to track those necessary changes. --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-openstack] OpenStack Heat Support (#138)

2014-09-03 Thread Jeremy Daggett
@everett-toews I updated the read me with instructions on running the live tests. We should do this for all of the other APIs! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/138#issuecomment-54336413

Re: [jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-03 Thread Jeremy Daggett
@@ -35,7 +35,7 @@ !-- keystone endpoint -- test.openstack-nova.endpointhttp://localhost:5000/v2.0//test.openstack-nova.endpoint !-- keystone version -- -test.openstack-nova.api-version1.1/test.openstack-nova.api-version +

Re: [jclouds] Token based authentication in openstack-keystone (#433)

2014-09-03 Thread Jeremy Daggett
@demobox What are you thinking here? `${credential}` ? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/433#issuecomment-54337052

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

2014-09-03 Thread Jeremy Daggett
@jasdeep-hundal Ping! Is there anything else that needs to be done with this PR? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment-54337653

Re: [jclouds] Implemented compute attach interfaces extension. (#497)

2014-09-03 Thread Jeremy Daggett
@@ -261,6 +262,13 @@ Optional? extends ConsolesApi getConsolesApi( @EndpointParam(parser = RegionToEndpoint.class) String region); + /** + * Provides access to attach interface features. + */ + @Delegate + Optional? extends AttachInterfaceApi

[jclouds] Nova API Updates (#505)

2014-09-03 Thread Jeremy Daggett
This PR updates the `api-versionUpdated api-version and removed upper bounds wildcards for extension APIs You can merge this Pull Request by running: git pull https://github.com/rackspace/jclouds nova/update Or you can view, comment on it, or merge it online at:

[jclouds-labs-openstack] OpenStack Heat Support (#138)

2014-09-02 Thread Jeremy Daggett
This PR provides the initial skeleton for the OpenStack Orchestration Heat API. The `ResourceApi` exposes a single `listTypes()` method and provides mock/live tests. JIRA: https://issues.apache.org/jira/browse/JCLOUDS-693 You can merge this Pull Request by running: git pull

[jira] [Assigned] (JCLOUDS-695) Support OpenStack Heat Resource API

2014-09-02 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett reassigned JCLOUDS-695: -- Assignee: Jeremy Daggett Support OpenStack Heat Resource API

[jira] [Created] (JCLOUDS-700) OpenStack Nova AvailabilityZone class missing hosts field

2014-09-02 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-700: -- Summary: OpenStack Nova AvailabilityZone class missing hosts field Key: JCLOUDS-700 URL: https://issues.apache.org/jira/browse/JCLOUDS-700 Project: jclouds

[jclouds] JCLOUDS-699: Properly deprecate OpenStack Nova zonescoped package (#503)

2014-09-02 Thread Jeremy Daggett
This PR deprecates the `org.jclouds.openstack.nova.v2_0.domain.zonescoped` package in favor of the `org.jclouds.openstack.nova.v2_0.domain.regionscoped` package and provides some other minor cleanup. JIRA: https://issues.apache.org/jira/browse/JCLOUDS-699 You can merge this Pull Request by

[jira] [Created] (JCLOUDS-693) Support OpenStack Orchestration (Heat) API

2014-09-01 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-693: -- Summary: Support OpenStack Orchestration (Heat) API Key: JCLOUDS-693 URL: https://issues.apache.org/jira/browse/JCLOUDS-693 Project: jclouds Issue Type

[jira] [Created] (JCLOUDS-694) Support OpenStack Heat Stack API

2014-09-01 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-694: -- Summary: Support OpenStack Heat Stack API Key: JCLOUDS-694 URL: https://issues.apache.org/jira/browse/JCLOUDS-694 Project: jclouds Issue Type: Sub-task

[jira] [Created] (JCLOUDS-695) Support OpenStack Heat Resource API

2014-09-01 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-695: -- Summary: Support OpenStack Heat Resource API Key: JCLOUDS-695 URL: https://issues.apache.org/jira/browse/JCLOUDS-695 Project: jclouds Issue Type: Sub

[jira] [Updated] (JCLOUDS-696) Support OpenStack Heat Event API

2014-09-01 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett updated JCLOUDS-696: --- Summary: Support OpenStack Heat Event API (was: Support OpenStack Head Event API) Support

[jira] [Created] (JCLOUDS-696) Support OpenStack Head Event API

2014-09-01 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-696: -- Summary: Support OpenStack Head Event API Key: JCLOUDS-696 URL: https://issues.apache.org/jira/browse/JCLOUDS-696 Project: jclouds Issue Type: Sub-task

[jira] [Created] (JCLOUDS-697) Support OpenStack Heat Template API

2014-09-01 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-697: -- Summary: Support OpenStack Heat Template API Key: JCLOUDS-697 URL: https://issues.apache.org/jira/browse/JCLOUDS-697 Project: jclouds Issue Type: Sub

[jira] [Updated] (JCLOUDS-696) Support OpenStack Heat Event API

2014-09-01 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett updated JCLOUDS-696: --- Description: http://developer.openstack.org/api-ref-orchestration-v1.html#stack-events

[jira] [Created] (JCLOUDS-698) Support OpenStack Heat Software Config API

2014-09-01 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-698: -- Summary: Support OpenStack Heat Software Config API Key: JCLOUDS-698 URL: https://issues.apache.org/jira/browse/JCLOUDS-698 Project: jclouds Issue Type

Re: [jclouds] Implemented compute attach interfaces extension. (#497)

2014-08-29 Thread Jeremy Daggett
@@ -261,6 +262,13 @@ Optional? extends ConsolesApi getConsolesApi( @EndpointParam(parser = RegionToEndpoint.class) String region); + /** + * Provides access to attach interface features. + */ + @Delegate + Optional? extends AttachInterfaceApi

Re: [jclouds] Implemented compute attach interfaces extension. (#497)

2014-08-29 Thread Jeremy Daggett
@@ -261,6 +262,13 @@ Optional? extends ConsolesApi getConsolesApi( @EndpointParam(parser = RegionToEndpoint.class) String region); + /** + * Provides access to attach interface features. + */ + @Delegate + Optional? extends AttachInterfaceApi

Re: [jclouds] Implemented compute attach interfaces extension. (#497)

2014-08-29 Thread Jeremy Daggett
+ this.portId = checkNotNull(portId, portId); + this.portState = portState; + this.macAddress = macAddress; + this.fixedIps = fixedIps; + } + + @Nullable + public String getNetworkId() { + return this.networkId; + } + + public String getPortId() { +

Re: [jclouds] Implemented compute attach interfaces extension. (#497)

2014-08-29 Thread Jeremy Daggett
+ * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.jclouds.openstack.nova.v2_0.domain; + +import com.google.common.base.Objects; +import com.google.common.base.Objects.ToStringHelper; +import

Re: [jclouds] Implemented compute attach interfaces extension. (#497)

2014-08-29 Thread Jeremy Daggett
+ } + + @Override + public boolean equals(Object obj) { + if (this == obj) + return true; + if (obj == null || getClass() != obj.getClass()) + return false; + InterfaceAttachment that = InterfaceAttachment.class.cast(obj); + return

Re: [jclouds] Implemented compute attach interfaces extension. (#497)

2014-08-29 Thread Jeremy Daggett
+import javax.ws.rs.DELETE; +import javax.ws.rs.GET; +import javax.ws.rs.POST; +import javax.ws.rs.Path; +import javax.ws.rs.PathParam; +import javax.ws.rs.Produces; +import javax.ws.rs.core.MediaType; + +/** + * Provides access to the OpenStack Compute (Nova) Attach Interfaces API. +

Re: [jclouds] Implemented compute attach interfaces extension. (#497)

2014-08-29 Thread Jeremy Daggett
@RoadRoller Thanks for the contribution of this Nova extension API! We definitely will need Expect (in this case) and Live tests before we can get this merged. There are a lot of examples in the test classes under `org.jclouds.openstack.nova.v2_0.extensions` for reference, and please let us

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

2014-08-29 Thread Jeremy Daggett
@jasdeep-hundal Weird... Try copying the ASF header from another file and run checkstyle locally to see if the issue persists. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment-53920481

[jira] [Commented] (JCLOUDS-685) Support bulk-delete/multi-object deletes from the BlobStore object

2014-08-29 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14115786#comment-14115786 ] Jeremy Daggett commented on JCLOUDS-685: In briefly looking at this, I noticed

Re: [jclouds] Unasync Rackspace First Gen Cloud Servers (#468)

2014-08-29 Thread Jeremy Daggett
Closed #468. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/468#event-159168146

Re: [jclouds] Unasync Rackspace First Gen Cloud Servers (#468)

2014-08-29 Thread Jeremy Daggett
CloudServers will be deprecated in jclouds 2.0 and removed in jclouds 3.0. Closing. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/468#issuecomment-53928272

[jclouds] Deprecate Rackspace First-Gen CloudServers (#500)

2014-08-29 Thread Jeremy Daggett
Added deprecation warning and removal plan. You can merge this Pull Request by running: git pull https://github.com/rackspace/jclouds deprecate-cloudservers Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/500 -- Commit Summary -- *

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

2014-08-29 Thread Jeremy Daggett
@jasdeep-hundal Oh, no magic there! Just copy the license header from another Java file :+1: --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment-53930325

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

2014-08-29 Thread Jeremy Daggett
Ha! All you need to do is run `mvn checkstyle:check`, or `mvn checkstyle:checkstyle` if you want a report. HTH --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment-53933620

Re: [jclouds] Token based authentication in openstack-keystone (#433)

2014-08-29 Thread Jeremy Daggett
+ public T id(String id) { + this.id = id; + return self(); + } + + public TokenCredentials build() { + return new TokenCredentials(id); + } + + public T fromTokenCredentials(TokenCredentials in) { + return this +

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

2014-08-28 Thread Jeremy Daggett
@@ -98,6 +98,51 @@ public String toString() { } + /** +* A representation of block device that should be attached to the instance to be launched +* +*/ + public static class BlockDeviceMapping { I would extract this class into its own domain class

[jclouds] JCLOUDS-686: Remove changesSince() query from base PaginationOptions (#499)

2014-08-28 Thread Jeremy Daggett
This PR deprecates the `changesSince(Date ifModifiedSince)` method in PaginationOptions. `changes-since` is specific to Nova (and [Glance](https://github.com/jclouds/jclouds-labs-openstack/pull/137)) and has moved to the Nova `ListOptions` class. Nova `ListOptions.maxResults(int maxKeys)` has

[jira] [Commented] (JCLOUDS-686) Remove OpenStack PaginationOptions.changesSince()

2014-08-28 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113975#comment-14113975 ] Jeremy Daggett commented on JCLOUDS-686: https://github.com/jclouds/jclouds-labs

[jira] [Created] (JCLOUDS-688) Nova ServerApi.createImageFromServer() does not consider metadata

2014-08-28 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-688: -- Summary: Nova ServerApi.createImageFromServer() does not consider metadata Key: JCLOUDS-688 URL: https://issues.apache.org/jira/browse/JCLOUDS-688 Project

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

2014-08-28 Thread Jeremy Daggett
+Objects.equal(this.tenantId, that.tenantId) +Objects.equal(this.floatingNetworkId, that.floatingNetworkId) +Objects.equal(this.fixedIpAddress, that.fixedIpAddress) +Objects.equal(this.floatingIpAddress, that.floatingIpAddress) +

Re: [jclouds-labs-openstack] Strip hardcoded v2.0 in Neutron APIs (#134)

2014-08-27 Thread Jeremy Daggett
Pushed to master 92112318c14e7d779463b57f4701d19736f00297 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/134#issuecomment-53590612

Re: [jclouds-labs-openstack] Strip hardcoded v2.0 in Neutron APIs (#134)

2014-08-27 Thread Jeremy Daggett
Closed #134. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/134#event-157929129

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

2014-08-27 Thread Jeremy Daggett
Closed #94. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/94#event-157977966

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

2014-08-27 Thread Jeremy Daggett
Pushed to master de8348d --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/94#issuecomment-53605683

Re: [jclouds-labs-openstack] Ignore jEnv files (#136)

2014-08-27 Thread Jeremy Daggett
Pushed to master 3243e71 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/136#issuecomment-53605879

Re: [jclouds-labs-openstack] Swift API Updates (#129)

2014-08-27 Thread Jeremy Daggett
Closed #129. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/129#event-157980233

Re: [jclouds-labs-openstack] Swift API Updates (#129)

2014-08-27 Thread Jeremy Daggett
Pushed to master 23a293e --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/129#issuecomment-53606308

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

2014-08-27 Thread Jeremy Daggett
+putRequest = signer.signPutBlob(containerName, blob2, 600); +MutableContentMetadata metadata = blob2.getMetadata() + .getContentMetadata(); +HttpRequest.Builder? putRequestBuilder = putRequest.toBuilder() +

[jira] [Commented] (JCLOUDS-686) Remove OpenStack PaginationOptions.changesSince()

2014-08-27 Thread Jeremy Daggett (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113083#comment-14113083 ] Jeremy Daggett commented on JCLOUDS-686: The Glance API should support

[jclouds-labs-openstack] Glance API ListImageOptions should support changesSince() (#137)

2014-08-27 Thread Jeremy Daggett
The work necessary to fix [`PaginationOptions`](https://issues.apache.org/jira/browse/JCLOUDS-686) in the main jclouds repo requires this downstream change to happen *prior* so the build doesn#39;t break. :+1: You can merge this Pull Request by running: git pull

Re: [jclouds-labs-openstack] Strip hardcoded v2.0 in Neutron APIs (#134)

2014-08-26 Thread Jeremy Daggett
@zack-shoylev The build was broken for a short time and I provided a fix in this [commit](https://github.com/jclouds/jclouds/commit/ddd00a20de591127ae8b030ef9f6ea5ea892971b). --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

2014-08-26 Thread Jeremy Daggett
+ * limitations under the License. + */ +package org.jclouds.openstack.neutron.v2.domain; + +import java.beans.ConstructorProperties; +import javax.inject.Named; + +import org.jclouds.javax.annotation.Nullable; +import com.google.common.base.MoreObjects; +import

Re: [jclouds] Token based authentication in openstack-keystone (#433)

2014-08-26 Thread Jeremy Daggett
@pimenas In some other refactoring of the `openstack-common` project, my belief at the time was that Token based auth was already in the codebase! This is specific to Keystone v2 so I will review and provide feedback. Thx! --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Token based authentication in openstack-keystone (#433)

2014-08-26 Thread Jeremy Daggett
+ */ +package org.jclouds.openstack.keystone.v2_0.domain; + +import static com.google.common.base.Preconditions.checkNotNull; + +import java.beans.ConstructorProperties; + +import org.jclouds.openstack.keystone.v2_0.config.CredentialType; + +import com.google.common.base.Objects;

Re: [jclouds] Token based authentication in openstack-keystone (#433)

2014-08-26 Thread Jeremy Daggett
+ +import static com.google.common.base.Preconditions.checkNotNull; + +import java.beans.ConstructorProperties; + +import org.jclouds.openstack.keystone.v2_0.config.CredentialType; + +import com.google.common.base.Objects; +import com.google.common.base.Objects.ToStringHelper; + +/** +

Re: [jclouds] Token based authentication in openstack-keystone (#433)

2014-08-26 Thread Jeremy Daggett
+ + @Override + public int hashCode() { + return Objects.hashCode(id); + } + + @Override + public boolean equals(Object obj) { + if (this == obj) return true; + if (obj == null || getClass() != obj.getClass()) return false; + TokenCredentials that =

Re: [jclouds] Token based authentication in openstack-keystone (#433)

2014-08-26 Thread Jeremy Daggett
@@ -87,6 +87,41 @@ public HttpRequest initialAuthWithAccessKeyAndSecretKeyAndTenantId(String access accessKey, secretKey, getTenantId()), application/json)).build(); } + public HttpRequest initialAuthWithTokenAndTenantName(String

Re: [jclouds] Token based authentication in openstack-keystone (#433)

2014-08-26 Thread Jeremy Daggett
@@ -87,6 +87,41 @@ public HttpRequest initialAuthWithAccessKeyAndSecretKeyAndTenantId(String access accessKey, secretKey, getTenantId()), application/json)).build(); } + public HttpRequest initialAuthWithTokenAndTenantName(String

Re: [jclouds] Token based authentication in openstack-keystone (#433)

2014-08-26 Thread Jeremy Daggett
@@ -42,6 +42,18 @@ public void testGetApiMetaData() { assertEquals(metadata, new ParseRackspaceApiMetadataTest().expected()); } + public void testGetApiMetaDataWithTokenCredentialsAuth() { + KeystoneApi api = requestsSendResponses( +

Re: [jclouds] Token based authentication in openstack-keystone (#433)

2014-08-26 Thread Jeremy Daggett
@@ -42,6 +42,18 @@ public void testGetApiMetaData() { assertEquals(metadata, new ParseRackspaceApiMetadataTest().expected()); } + public void testGetApiMetaDataWithTokenCredentialsAuth() { + KeystoneApi api = requestsSendResponses( +

Re: [jclouds] Token based authentication in openstack-keystone (#433)

2014-08-26 Thread Jeremy Daggett
@pimenas Hi! There are a few comments that need to be addressed, but overall the PR looks good. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/433#issuecomment-53450915

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

2014-08-26 Thread Jeremy Daggett
+ @Named(tenant_id) + private String tenantId; + // Only mandatory attribute when creating + @Named(floating_network_id) + private String floatingNetworkId; + @Named(fixed_ip_address) + private String fixedIpAddress; + @Named(floating_ip_address) + private String

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

2014-08-26 Thread Jeremy Daggett
+ } + + private abstract static class BuilderParameterizedBuilderType { + protected FloatingIP floatingIP; + + /** + * No-parameters constructor used when updating. + * */ + private Builder() { + floatingIP = new FloatingIP(); + } + +

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

2014-08-26 Thread Jeremy Daggett
+* @return the list of all floatingIP references configured for the tenant. +*/ + @Named(floatingip:list) + @GET + @Transform(FloatingIPsToPagedIterable.class) + @ResponseParser(ParseFloatingIPs.class) + @Fallback(EmptyPagedIterableOnNotFoundOr404.class) +

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

2014-08-26 Thread Jeremy Daggett
+ /** +* The operation returns a list of floating IPs to which the tenant has access. Default policy settings return only +* those floating IPs that are owned by the tenant who submits the request, unless the request is submitted by an +* user with administrative rights. +

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

2014-08-26 Thread Jeremy Daggett
@zack-shoylev Looking good! A few comments, and could you also please [reformat](http://jsonlint.com/) the json files? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/135#issuecomment-53454551

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

2014-08-26 Thread Jeremy Daggett
Closed #94. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/94#event-157475729

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

2014-08-26 Thread Jeremy Daggett
Reopened #94. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/94#event-157475754

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

2014-08-26 Thread Jeremy Daggett
@shrinandj Just closed and reopened to kick the build again. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/94#issuecomment-53468326

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

2014-08-26 Thread Jeremy Daggett
} - String blobName = Iterables.getLast(blobs).getName(); - HttpRequest request = ctx.getSigner(regionId).signGetBlob(containerName, blobName); It looks like the `getSigner(regionId)` was used here, but removed! --- Reply to this email directly or view it on

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

2014-08-26 Thread Jeremy Daggett
@@ -83,13 +101,65 @@ public void testSignBlob() throws InterruptedException, ExecutionException { continue; } String containerName = Iterables.getLast(containers).getName(); - PageSet? extends StorageMetadata blobs = region.list(containerName); -

[jira] [Created] (JCLOUDS-686) Remove OpenStack PaginationOptions.changesSince()

2014-08-26 Thread Jeremy Daggett (JIRA)
Jeremy Daggett created JCLOUDS-686: -- Summary: Remove OpenStack PaginationOptions.changesSince() Key: JCLOUDS-686 URL: https://issues.apache.org/jira/browse/JCLOUDS-686 Project: jclouds

<    1   2   3   4   5   6   7   8   9   10   >