@andreaturli Are you happy to merge this without the ListenerProtocol you
suggested, or would you like to see that implemented?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/371
Fixes an issue where Azure ARM resource groups are not deleted when a node is
destroyed. This fix resolves the following Jiras
https://issues.apache.org/jira/browse/JCLOUDS-1330
https://issues.apache.org/jira/browse/JCLOUDS-1331
You can view, comment on, or merge this pull request online at:
h
nakomis commented on this pull request.
> + // Wait for 404 on the disk api
+ Predicate diskDeleted = new Predicate() {
+ @Override
+ public boolean apply(IdReference input) {
+return api.getDiskApi(input.resourceGroup()).get(input.name()) ==
null;
+
nakomis commented on this pull request.
> @@ -171,9 +216,12 @@ public boolean cleanupSecurityGroupIfOrphaned(String
> resourceGroup, String group
logger.debug(">> deleting orphaned security group %s from
%s...", name, resourceGroup);
try {
del
nakomis commented on this pull request.
> @@ -231,7 +309,10 @@ private static boolean
> isOrphanedJcloudsAvailabilitySet(AvailabilitySet availabi
}
private boolean deleteVirtualMachine(String group, VirtualMachine
virtualMachine) {
- return
resourceDeleted.apply(api.getVirtualM
Hi, thanks for the feedback. I've addressed a couple of the comments above, and
pushed a couple of changes to address the others
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1240#is
