Re: [jclouds/jclouds] Make NovaErrorHandler logging of sensitive information configurable (#1243)

2018-10-16 Thread Oliver Gondža
@olivergondza pushed 1 commit. 664ba53 Make logSensitiveInformation private -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1243/files/7cdea3521747397e3f693342eb1eb8e59f7ccd87..664ba53842a5df7a9c615d08f854b242d97fe

[jclouds/jclouds] Make NovaErrorHandler logging of sensitive information configurable (#1243)

2018-10-16 Thread Oliver Gondža
While figuring out how to get jclouds to use keystone v3 api to work, it refused to provide any info as, for some reason, it run into the problem while talking to nova and not keystone. Making it configurable here as well. You can view, comment on, or merge this pull request online at: https:/

Re: [jclouds] JCLOUDS-962: Do not override provider methods (#818)

2015-07-20 Thread Oliver Gondža
Would it be possible to publish alpha/rc with the announcement so people can start to experiment and provide more useful feedback? It is not a deal breaker but it blocks https://github.com/jenkinsci/openstack-cloud-plugin/pull/15, and the release would help. --- Reply to this email directly or

Re: [jclouds] JCLOUDS-962: Do not override provider methods (#818)

2015-07-17 Thread Oliver Gondža
Alright, I have marked all provider methods final to identify the overridden ones and created a delegate where needed. Still, there is a lot of methods that _was not_ overriden and thus have no delegate methods. I am undecided if we should keep them `final` to identify problems in dependent libr

Re: [jclouds] JCLOUDS-962: Do not override provider methods (#818)

2015-07-16 Thread Oliver Gondža
@nacx, Looking back at the amount of boilerplate this generates, keeping the `@Provider` annotation in parent class is a must. Refactoring: ```java @Provide public X provideX() { ... } ``` into ```java @Provide public final X guiceProvideX() { ... } public X provideX() { ... } ``` should not

[jclouds] JCLOUDS-962: Do not override provider methods (#818)

2015-07-16 Thread Oliver Gondža
[JCLOUDS-962](https://issues.apache.org/jira/browse/JCLOUDS-962) Fix guice 4 support. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/818 -- Commit Summary -- * JCLOUDS-962: Do not override provider methods -- File Changes -- M