Softlayer will occasionally return an incomplete operating system template
entry in the `/SoftLayer_Virtual_Guest/getCreateObjectOptions` call, making it
impossible to spin up machines - ignore the incomplete entries which are
usually not even relevant.
Snippet of incomplete response in `operat
If an IOException is thrown during the execution of an HttpCommand retry only
if the HTTP method doesn't have side effects (i.e. GET, HEAD). Otherwise the
retry could cause unwanted side effects (i.e. creating and leaking multiple new
nodes).
In my particular case Softlayer was timing out with
Certain hardened images will have `umask 0077` set for the root user, making
the newly created `/home/users` folder inaccessible to non-root. This results
in a failure when trying to ssh with the new account. Explicitly set
permissions to be independent of default umask.
You can view, comment on
Addressed comments. Personally I see "safe" as a subset of "idempotent"
methods, which includes `DELETE` and `PUT` in addition to `GET` and `HEAD`. I
added them to the white-list as this makes the change differ in behaviour from
before only for `POST` (and `PATCH`) which is where I had issues.
@nacx Note that the changes are for the exception only case. This means that
the client will send a request but won't receive the response. It doesn't
matter whether the provider uses a proper REST API or not - if an exception
occurs in the middle of a request, then it's not clear whether it can
This is exactly what the current implementation does, no? It's not clear from
the github diff, worth looking at the whole file.
The server error retry handler will call into another method - `public boolean
shouldRetryRequest(HttpCommand command, HttpResponse response)` as opposed to
the excepti
Make sense, I'll update the PR.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/744#issuecomment-101317635
Addressed all comments.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/743#issuecomment-101630952
Redid PR, moved changes to `BaseHttpCommandExecutorService`
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/744#issuecomment-101668005
Updated PR, local tests passing.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/746#issuecomment-101772489
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/756
-- Commit Summary --
* Implement setting and retrieving the notes property on Softlayer machines
-- File Changes --
A
providers/softlayer/src/main/java/org/jclouds/softlayer/bi
> + Map meta = templateOptions.getUserMetadata();
> + if (meta != null && !meta.isEmpty()) {
> +if (meta.containsKey(USER_META_NOTES)) {
> + return meta.get(USER_META_NOTES);
> +} else {
> + String notes = "User Metadata\n=
> @@ -125,6 +126,15 @@ public void testSetTagsOnVirtualGuest() throws Exception
> {
> }
>
> @Test(dependsOnMethods = "testSetTagsOnVirtualGuest")
> + public void testSetNotesOnVirtualGuest() throws Exception {
> + // Test with maximum allowed notes length - 1000 characters.
Max l
> @@ -149,4 +152,34 @@
> @Produces(MediaType.APPLICATION_JSON)
> @Fallback(Fallbacks.FalseOnNotFoundOr404.class)
> boolean setTags(@PathParam("id") long id, @BinderParam(TagToJson.class)
> Set tags);
> +
> + /**
> +* Set notes (visible in UI)
> +*
> +* @param id
> +*
Addressed part of the comments, waiting for input on the rest.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/756#issuecomment-108385482
Addressed comments. To set notes in SL the user should use `notes` property in
user metadata.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/756#issuecomment-110344711
Addressed comments and squashed into a single commit.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/756#issuecomment-110616036
Looking good now :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/756#issuecomment-110710696
Looks good.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/823#issuecomment-124564333
Added live tests and missing functionality. I've been using the provider the
whole time since creating it and it's been working great. Good to review.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/160#issuecomment-192967878
+1, looks like this has already been discussed at
https://issues.apache.org/jira/browse/JCLOUDS-534
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/934#issuecomment-194322876
bump @nacx, @andreaturli
Let me know if anything else needed for a review.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/160#issuecomment-203009249
A couple of unit tests missing, but will be easy to add if everything else is
good to go.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/160#issuecomment-203009569
https://github.com/jclouds/jclouds/blob/master/project/pom.xml#L235
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-karaf/pull/81
-- Commit Summary --
* Use same bundle version as in jclouds/project/java-xmlbuilder.verison
-- File Changes -
@nacx There's no vagrant API, so it's using the cli under the hood. It's
possible to install a plugin which exposes an API, but since the provider makes
most sense when used locally better not introduce another abstraction layer
(and add extra setup steps for users).
I've updated the dependency
I've just deleted the PR branch in my repo @andreaturli. The changes are
already in jclouds' master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/81#issuecomment-265663737
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-karaf/pull/91
-- Commit Summary --
* Use same bundle version as in jclouds/project/java-xmlbuilder.verison
-- File Changes --
M pom.xml (2)
-- Patch Links --
https://github.com/jclouds
Reponed in https://github.com/jclouds/jclouds-karaf/pull/91
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/81#issuecomment-265703639
Hi @nacx. Bumped version to `2.1.0-SNAPSHOT`.
What work would be needed to get this merged into labs?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/160#issuecomment-266230148
Thanks for taking the time to go through the code. Will implement the changes
and get back to you.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/160#issuecomment-266657373
Xenial doesn't have Java 6 package.
Select the java package dynamically based on what's available. Don't hardcode
Java 6.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1045
-- Commit Summary --
* Fix Java install on Ubuntu Xenial
--
neykov commented on this pull request.
> @@ -177,7 +177,11 @@ function installOpenJDK() {
echo reusing JAVA_HOME $JAVA_HOME
else
if which dpkg &> /dev/null; then
- apt-get-update && apt-get-install openjdk-6-jdk
+ apt-get update && \
+ PACKAGE=`apt-cache search --
neykov commented on this pull request.
> + String privateKey;
+ try {
+ privateKey = Files.toString(new File(sshConfig.getIdentityFile()),
Charset.defaultCharset());
+ } catch (IOException e) {
+ throw new IllegalStateException("Invalid private key " +
sshConfig.
neykov commented on this pull request.
> +
+ LoginCredentials loginCredentials = LoginCredentials.builder()
+.user(sshConfig.getUser())
+.privateKey(privateKey)
+.build();
+ return new NodeAndInitialCredentials(node,
newMachine.getId(), loginCredent
neykov commented on this pull request.
> + }
+
+ @Override
+ protected Set getIso3166Codes() {
+ return ImmutableSet.of();
+ }
+
+ @Test
+ @Override
+ public void testDefaultTemplateBuilder() throws IOException {
+ Template defaultTemplate =
view.getComputeService().temp
neykov commented on this pull request.
> + }
+}, null);
+ }
+
+ @Override
+ public Iterable listLocations() {
+ return ImmutableList.of(
+ new
LocationBuilder().id("localhost").description("localhost").scope(LocationScope.HOST).build());
+ }
+
@neykov pushed 33 commits.
b911159 First pass on review comments
7083b15 VagrantNodeRegistry with eviction for terminated machines
79142b0 Centralize machine file config access
c2b1c70 Skip non-jclouds vagrant machines
31b8bbf Streamline machine name usage
1200a2a Simplify machine cleanup
12
neykov commented on this pull request.
> +
+Building
+
+
+1. Vagrant bindings
+ * `git clone https://github.com/neykov/vagrant-java-bindings`
+ * `cd vagrant-java-bindings`
+ * `mvn clean install`
+ * Copy `target/vagrant-java-bindings-0.0.1-SNAPSHOT.jar` to jcloud's
classpath
+2. V
neykov commented on this pull request.
> + * `git clone https://github.com/neykov/vagrant-java-bindings`
+ * `cd vagrant-java-bindings`
+ * `mvn clean install`
+ * Copy `target/vagrant-java-bindings-0.0.1-SNAPSHOT.jar` to jcloud's
classpath
+2. Vagrant provider
+ * `git clone https://githu
neykov commented on this pull request.
> +
+UserName
+$USER
+GroupName
+daemon
+StandardOutPath
+/Users/$USER/.polipo/polipo.log
+StandardErrorPath
+/Users/$USER/.polipo/polipo.log
+
+
+```
+
+* `sudo chown root:wheel /Library/LaunchDaemons/fr.jussieu.pps.poli
Addressed all comments I haven't replied directly to. Also a lot of
improvements all around the board.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/160#issuecomment-269615901
@andreaturli Don't mind moving the project under the jclouds umbrella. What I'd
like though is to keep it self-contained without any additional dependencies
like guice, guava or jclouds logging. That's to allow anyone using it without
pulling in jclouds dependencies.
Don't think that would fit w
Fully agree @nacx, that was my point as well.
If you prefer to avoid the additional dependency I can bring in just the bits
that are needed for the jclouds provider.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://g
neykov commented on this pull request.
> + * `git clone https://github.com/neykov/vagrant-java-bindings`
+ * `cd vagrant-java-bindings`
+ * `mvn clean install`
+ * Copy `target/vagrant-java-bindings-0.0.1-SNAPSHOT.jar` to jcloud's
classpath
+2. Vagrant provider
+ * `git clone https://githu
thanks @nacx and @andreaturli for your opinions - here's what I'll end up doing
then:
* keep the `vagrant-java-binding` dependency - this will allow others to use
it without pulling in jclouds dependencies
* abstract the access to the library in the provider so it can be switched at
any time
Updated PR to use `apt-get-install` and support for yum.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1045#issuecomment-270644276
neykov commented on this pull request.
Looking great, nice to see the tests updated.
> @@ -27,7 +27,7 @@ limitations under the License.
org.apache.jclouds
jclouds-karaf
pom
- 2.1.0-SNAPSHOT
+ 2.0.1-SNAPSHOT
Is this change made on purpose?
--
You are receiving this because you are su
@neykov pushed 2 commits.
3c5807d Get vagrant home from environment
cd6dbdd Introduce an abstractaion layer between jclouds and the Vagrant CLI API
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/160/files/1d
I've abstracted away the access to vagrant - it's all in `VagrantCliProvider`
now.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/160#issuecomment-271253432
@neykov pushed 1 commit.
3ea1e3f Guice assisted Factory for VagrantApiFacade
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/160/files/cd6dbdd60362405db757d7c4d03281391253858e..3ea1e3f264166e80aeb10dbd0ead8b83
eTest
Configuring TestNG with: TestNG652Configurator
I 09, 2017 9:20:42 PM
org.jclouds.vagrant.compute.VagrantComputeServiceAdapterLiveTest setupProperties
INFO: Home for ubuntu/xenial64 at
/Users/svet/.jclouds/vagrant/tests/ubuntu_xenial64
I 09, 2017 9:20:
neykov commented on this pull request.
> +import com.google.common.base.Predicate;
+import com.google.common.collect.Iterables;
+import com.google.common.io.Files;
+
+import vagrant.Vagrant;
+import vagrant.api.CommandIOListener;
+import vagrant.api.VagrantApi;
+import vagrant.api.domain.Box;
+i
https://paste.apache.org/vdES
```
Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,651.118 sec
- in org.jclouds.vagrant.compute.UbuntuXenialLiveTest
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https
@neykov pushed 1 commit.
1c397bd Fix terminated state, fix NPE
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/160/files/3ea1e3f264166e80aeb10dbd0ead8b8394186f86..1c397bd970704cde5b43d1061759ee9b5735c54f
@neykov pushed 1 commit.
4cb8ba5 Run live tests against a single, configurable imageId.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/160/files/1c397bd970704cde5b43d1061759ee9b5735c54f..4cb8ba5e68db3b93d1c6a
@neykov pushed 1 commit.
7129162 Fix tests for imageId=centos/7
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/160/files/6796d960c854f15bf1d6a642eadaa7c93fe1853d..7129162ed18a01634c4b9244beefca889c65c4d0
@neykov pushed 1 commit.
76e37e7 Update README
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/160/files/7129162ed18a01634c4b9244beefca889c65c4d0..76e37e704801218356f754b484fc697764782def
neykov commented on this pull request.
> +
+Building
+
+
+1. Vagrant bindings
+ * `git clone https://github.com/neykov/vagrant-java-bindings`
+ * `cd vagrant-java-bindings`
+ * `mvn clean install`
+ * Copy `target/vagrant-java-bindings-0.0.1-SNAPSHOT.jar` to jcloud's
classpath
+2. V
Happy to hear that @nacx. Squashed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/160#issuecomment-272506866
🎉 thanks @nacx @andreaturli.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/160#issuecomment-275071440
neykov commented on this pull request.
> @@ -52,38 +52,56 @@ limitations under the License.
mvn:org.apache.jclouds.api/atmos/${jclouds.version}
Latest version of namespace is `http://karaf.apache.org/xmlns/features/v1.4.0`.
`resolver` attribute is no longer used so can drop it.
--
Y
neykov commented on this pull request.
> @@ -110,7 +110,6 @@ limitations under the License.
jclouds-compute
jclouds-api-atmos
jclouds-api-byon
-jclouds-api-cloudsigma2
Easier to pack all the features in one or several big super-
Updated the vagrant bindings to build as an OSGi bundle.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/350
-- Commit Summary --
* Improve OSGi compatibility
-- File Changes --
M vagrant/pom.xml (2)
-- Patch Links --
https
Merge after https://github.com/jclouds/jclouds-labs/pull/350
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-karaf/pull/94
-- Commit Summary --
* Add Vagrant provider
-- File Changes --
M feature/src/main/resources/feature.xml (6)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-cli/pull/36
-- Commit Summary --
* Add Vagrant provider
-- File Changes --
M assembly/pom.xml (1)
-- Patch Links --
https://github.com/jclouds/jclouds-cli/pull/36.patch
https://github.
@nacx here's the PR against jclouds-cli -
https://github.com/jclouds/jclouds-cli/pull/36
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/94#issuecomment-275876174
Lets jclouds manage vagrant machines from previous runs.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/355
-- Commit Summary --
* Load existing machines info on startup
* Update vagrant provider limitations
-- File Changes --
neykov commented on this pull request.
> @@ -52,38 +52,56 @@ limitations under the License.
mvn:org.apache.jclouds.api/atmos/${jclouds.version}
Hmm indeed not clear at all :)
I was referring to the the [root element
namespace](https://github.com/andreaturli/jclouds-karaf/blob/44bec200
neykov commented on this pull request.
> +import com.google.common.base.Supplier;
+import com.google.common.collect.Collections2;
+import com.google.inject.Inject;
+
+public class ImageSupplier implements Supplier>,
Function {
+ private final Function, Collection> outdatedBoxesFilter;
+ pri
@nacx addressed comments.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/355#issuecomment-276450652
neykov commented on this pull request.
>this.timeSupplier = timeSupplier;
+ this.nodes = Suppliers.memoize(new
ConcurrentWrapperSupplier(existingMachines));
The `ConcurrentHashMap` is an implementation detail of the
`VagrantNodeRegistry`. The wrapping supplier+memoize is just a m
neykov commented on this pull request.
> @@ -73,36 +93,41 @@ public long getDelay(TimeUnit unit) {
return unit.convert(expiryTime - timeSupplier.get(),
TimeUnit.MILLISECONDS);
}
}
- private Map nodes = new ConcurrentHashMap();
- private DelayQueue terminatedNodes = new
>Could you also elaborate a bit the motivation behind having split the Vagrant
>Facade in two different interfaces?
The `` started leaking in classes that don't really deal with boxes at all.
Looking at the changes that must've been code that I've removed since as it was
additional to `VagrantC
neykov commented on this pull request.
> @@ -73,36 +93,41 @@ public long getDelay(TimeUnit unit) {
return unit.convert(expiryTime - timeSupplier.get(),
TimeUnit.MILLISECONDS);
}
}
- private Map nodes = new ConcurrentHashMap();
- private DelayQueue terminatedNodes = new
Used to keep terminated nodes meta for a short while, but not needed.
Also adds missing state transitions on halt, reboot.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/357
-- Commit Summary --
* Remove terminated nodes cache
--
TL;DR - We should keep the registry and expire the status only. Could save some
of it in the machine description yaml.
---
That's correct @nacx. We see only machines we've created (with the exception of
the initial load).
The provider serves the following purposes:
1. holds information that'
LGTM
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1057#issuecomment-277221478
neykov commented on this pull request.
> @@ -52,38 +52,56 @@ limitations under the License.
mvn:org.apache.jclouds.api/atmos/${jclouds.version}
Yes, it's not included in the latest schema above.
--
You are receiving this because you are subscribed to this thread.
Reply to this email
neykov commented on this pull request.
> + dependency='true'>mvn:org.apache.jclouds.common/googlecloud/${jclouds.version}
+
mvn:org.apache.jclouds.labs/google-cloud-storage/${jclouds.version}
+
+
+
+jclouds-compute
+mvn:org.apache.jclouds.labs/packet/${jcl
neykov commented on this pull request.
> + private static final String FEATURES_XML = "features.xml";
+
+ @Inject
+ FeaturesService featuresService;
+
+ static File getFeaturesFile() throws URISyntaxException {
+ String featuresXml = System.getProperty(FEATURES_XML);
+ Assert.a
neykov commented on this pull request.
> + dependency='true'>mvn:org.apache.jclouds.common/googlecloud/${jclouds.version}
+
mvn:org.apache.jclouds.labs/google-cloud-storage/${jclouds.version}
+
+
+
+jclouds-compute
+mvn:org.apache.jclouds.labs/packet/${jcl
Tests from the same class are executed concurrently so don't share state in the
class. Additionally use temporary files/folders to allow for parallel builds.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/364
-- Commit Summary --
LGTM. Could still use the image cache and fall back to `getImage` only if empty.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/359#issuecomment-282737375
For completeness here's the exception this is trying to fix:
```
Caused by: java.lang.NullPointerException
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:210)
at
com.google.common.collect.SingletonImmutableSet.(SingletonImmutableSet.java:47)
at com.google.commo
neykov requested changes on this pull request.
> @@ -179,8 +180,15 @@ public String apply(Status input) {
Credentials credentials = credentialStore.get("node#" +
virtualMachine.name());
builder.credentials(LoginCredentials.fromCredentials(credentials));
-
builder.publicAdd
ve the
following two in your logs:
```
[INFO] Installing .../jclouds-karaf/feature-labs/pom.xml to
/Users/svet/.m2/repository/org/apache/jclouds/karaf/jclouds-karaf-labs/2.1.0-SNAPSHOT/jclouds-karaf-labs-2.1.0-SNAPSHOT.pom
[INFO] Installing .../jclouds-karaf/feature-labs/target/feature-labs.xm
neykov commented on this pull request.
> + featuresService.installFeature("jclouds-rackspace-cloudfiles-us");
+ }
+
+ @Test
+ public void testServerloveZ1ManFeature() throws Exception {
+ featuresService.installFeature("jclouds-serverlove-z1-man");
+ }
+
+ @Test
+ public vo
neykov commented on this pull request.
> + featuresService.installFeature("jclouds-rackspace-cloudfiles-us");
+ }
+
+ @Test
+ public void testServerloveZ1ManFeature() throws Exception {
+ featuresService.installFeature("jclouds-serverlove-z1-man");
+ }
+
+ @Test
+ public vo
LGTM.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92#issuecomment-287320844
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-karaf/pull/98
-- Commit Summary --
* Group labs features in super features
-- File Changes --
M feature-labs/src/main/feature/feature.xml (16)
-- Patch Links --
https://github.com/jclo
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-cli/pull/37
-- Commit Summary --
* Reference super features in assembly module
-- File Changes --
M assembly/pom.xml (60)
-- Patch Links --
https://github.com/jclouds/jclouds-cli/pull/
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-karaf/pull/99
-- Commit Summary --
* Add back the cloudsigma-api feature for backwards compatibility
-- File Changes --
M feature/src/main/feature/feature.xml (20)
-- Patch Links --
ht
@andreaturli This doesn't need `jclouds-karaf#98`. It's just for backwards
compatibility.
@demobox I've tried the distribution with `bin/jclouds` - it's working as
expected.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
h
neykov commented on this pull request.
>
config
-jclouds
-jclouds-commands
-jclouds-compute
-jclouds-guice
`jclouds-guice`, `jclouds` is included by `jclouds-compute` and it is inclu
neykov commented on this pull request.
> @@ -516,32 +521,27 @@ limitations under the License.
-jclouds-compute
Goot point @demobox. I reverted the changes for the sake of consistency. Still
think it's the right thing to do though. Perhaps something to take care of in
ano
@andreaturli Either this PR or https://github.com/jclouds/jclouds-cli/pull/37
will fix the build. Thought it's useful to add anyway for backwards
compatibility, in case other projects depend on it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly
Correction on my comment above @andreaturli. This does require
https://github.com/jclouds/jclouds-karaf/pull/98 to build successfully. And
https://github.com/jclouds/jclouds-karaf/pull/99 is not needed, it's just good
to have.
--
You are receiving this because you are subscribed to this thread
Also makes the windows image optional for tests - skips the tests if not found.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/373
-- Commit Summary --
* Make the windows image optional
* Improve vagrant docs
-- File Changes --
Good spot @demobox. Updated.
Now testing with jclouds-cli, though "it shouldn't matter (tm)" :).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/99#issuecomment-287786218
Adds back (a bit simplified) the maven config which creates artifacts out of
the config files used in the feature.xml.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-karaf/pull/100
-- Commit Summary --
* Attach config files referenced in t
1 - 100 of 180 matches
Mail list logo
