[jira] [Updated] (JCLOUDS-1492) Dimension Data Feature API Predicates are not usable

[ https://issues.apache.org/jira/browse/JCLOUDS-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trevor Flanagan updated JCLOUDS-1492: - Description: The predicates exposed in  [https://github.com/apache/jclouds-labs/blob

[jira] [Created] (JCLOUDS-1492) Dimension Data Feature API Predicates are not usable

Trevor Flanagan created JCLOUDS-1492: Summary: Dimension Data Feature API Predicates are not usable Key: JCLOUDS-1492 URL: https://issues.apache.org/jira/browse/JCLOUDS-1492 Project: jclouds

[jira] [Updated] (JCLOUDS-1492) Dimension Data Feature API Predicates are not usable

[ https://issues.apache.org/jira/browse/JCLOUDS-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trevor Flanagan updated JCLOUDS-1492: - Issue Type: Bug (was: Task) > Dimension Data Feature API Predicates are not usa

Re: [jclouds/jclouds-labs] Use State enum instead of String state in Domain classes (#452)

trevorflanagan commented on this pull request. Nice one @btrishkin, this should mean that we no longer use String state anywhere. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-examples] Dimension Data - Added cleanServer call to NetworkDomainTearDown (#95)

Thanks for taking a look @andreaturli -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/95#issuecomment-431399666

[jclouds/jclouds-examples] Dimension Data - Added cleanServer call to NetworkDomainTearDown (#95)

You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-examples/pull/95 -- Commit Summary -- * Updating the Dimension Data NetworkDomainTearDown example to include the ability to clean a FAILED_ADD server. -- File Changes -- M

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

@trevorflanagan pushed 1 commit. 315b896 JCLOUDS-1431 - Support AU geo for Live Tests. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

trevorflanagan commented on this pull request. >assertNotNull(cloneImageId); assertTrue(serverNormalPredicate.apply(serverId), "server was not NORMAL after timeout"); } + @Test(dependsOnMethods = "testCloneServerToMakeCustomerImage") + public void

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

trevorflanagan commented on this pull request. > +import org.jclouds.rest.annotations.Fallback; +import org.jclouds.rest.annotations.MapBinder; +import org.jclouds.rest.annotations.PayloadParam; +import org.jclouds.rest.annotations.RequestFilters; +import

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

Commits squashed in advance merge. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/446#issuecomment-431126798

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

I have re-based onto master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/446#issuecomment-431126111

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

trevorflanagan commented on this pull request. > +import javax.ws.rs.Path; +import javax.ws.rs.Produces; +import javax.ws.rs.core.MediaType; + +@RequestFilters({ BasicAuthentication.class, OrganisationIdFilter.class }) +@Consumes(MediaType.APPLICATION_JSON) +@Path("/caas/2.7/image") +public

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

trevorflanagan commented on this pull request. >assertNotNull(cloneImageId); assertTrue(serverNormalPredicate.apply(serverId), "server was not NORMAL after timeout"); } + @Test(dependsOnMethods = "testCloneServerToMakeCustomerImage") + public void

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

trevorflanagan commented on this pull request. > @@ -89,8 +89,17 @@ public void setUp() { datacenters = getZones(); } + // private Set getZones() { + // return ctx.utils().injector().getInstance(ZoneIdsSupplier.class).get(); + // } + + // TODO this leads to a

Re: [jclouds/jclouds-labs] JCLOUDS-1457 - Add Clean Server operation to ServerApi. (#450)

Thanks for looking @nacx , change has been made and commits squashed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/450#issuecomment-430947500

Re: [jclouds/jclouds-labs] JCLOUDS-1457 - Add Clean Server operation to ServerApi. (#450)

trevorflanagan commented on this pull request. > @@ -150,6 +150,17 @@ String cloneServer(@PayloadParam("id") String id, > @PayloadParam("imageName") Str @MapBinder(BindToJsonPayload.class) void startServer(@PayloadParam("id") String id); + @Named("server:cleanServer") + @POST +

Re: [jclouds/jclouds-labs] JCLOUDS-1457 - Add Clean Server operation to ServerApi. (#450)

trevorflanagan commented on this pull request. > @@ -22,7 +22,7 @@ public enum State { - NORMAL, FAILED_ADD, FAILED_CHANGE, FAILED_DELETE, PENDING_DELETE, DELETED, UNRECOGNIZED, PENDING_CHANGE; + NORMAL, FAILED_ADD, FAILED_CHANGE, FAILED_DELETE, PENDING_DELETE, DELETED, UNRECOGNIZED,

Re: [jclouds/jclouds-labs] JCLOUDS-1457 - Add Clean Server operation to ServerApi. (#450)

trevorflanagan commented on this pull request. > @@ -35,6 +36,7 @@ public static Builder builder() { public abstract String name(); + @Nullable This change is not directly related to this PR. -- You are receiving this because you are subscribed to this thread. Reply to this email

[jclouds/jclouds-labs] JCLOUDS-1457 - Add Clean Server operation to ServerApi. (#450)

You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/450 -- Commit Summary -- * JCLOUDS-1457 - Add Clean Server operation to ServerApi. -- File Changes -- M

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

@trevorflanagan pushed 1 commit. ba16be9 JCLOUDS-1458 Create Dimension Data Provider Guide - handling code review comments. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

trevorflanagan commented on this pull request. > + +{% highlight java %} +/* + * Deploy Network Domain to the Zone / Datacenter we wish to operate on. The response from this API is the Network Domain Identifier. + */ +String networkDomainId = api.getNetworkApi().deployNetworkDomain(AU9,

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

@trevorflanagan pushed 1 commit. 2f7f11f JCLOUDS-1458 Create Dimension Data Provider Guide - correcting the artifact id. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

trevorflanagan commented on this pull request. > @@ -69,6 +69,11 @@ The Maven Group ID for all supported providers below is > [org.apache.jclouds.prov digitalocean + +Dimension Data* I think this is all that you require @nacx ? --

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

@trevorflanagan pushed 1 commit. b3e54fb Example of Dimension Data CloudControl provider. Code review comments. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

@trevorflanagan pushed 1 commit. 2d46a4b Example of Dimension Data CloudControl provider. Code review comments. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

@trevorflanagan pushed 1 commit. 8bb536c Example of Dimension Data CloudControl provider. Code review comments. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

trevorflanagan commented on this pull request. > @@ -21,7 +21,7 @@ 4.0.0 org.apache.jclouds.examples jclouds-examples - 2.1.0 + 2.2.0-SNAPSHOT Great thanks I wasnt sure what the correct approach was for the parent pom. -- You are receiving this because you are subscribed to this

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

@trevorflanagan pushed 1 commit. b13ec1f JCLOUDS-1458 Create Dimension Data Provider Guide -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

trevorflanagan commented on this pull request. > +{% highlight java %} +/* + * Deploy Network Domain to the Zone / Datacenter we wish to operate on. The response from this API is the Network Domain Identifier. + */ +String networkDomainId =

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

@trevorflanagan pushed 1 commit. dfc01f0 JCLOUDS-1458 Create Dimension Data Provider Guide -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

@trevorflanagan pushed 1 commit. c43833b JCLOUDS-1458 Create Dimension Data Provider Guide -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

@trevorflanagan pushed 1 commit. 0b140b7 JCLOUDS-1458 Create Dimension Data Provider Guide -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

@trevorflanagan pushed 1 commit. 3c76242 JCLOUDS-1458 Create Dimension Data Provider Guide -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

@trevorflanagan pushed 1 commit. 4fef5ec JCLOUDS-1458 Create Dimension Data Provider Guide -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

@trevorflanagan pushed 1 commit. d934ee6 JCLOUDS-1458 Create Dimension Data Provider Guide -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

@trevorflanagan pushed 1 commit. 2fa987f JCLOUDS-1458 Create Dimension Data Provider Guide -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

@trevorflanagan pushed 5 commits. e9793c0 JCLOUDS-1458 Create Dimension Data Provider Guide c0011df JCLOUDS-1458 Create Dimension Data Provider Guide c3f804f JCLOUDS-1458 Create Dimension Data Provider Guide bb2b4c6 JCLOUDS-1458 Create Dimension Data Provider Guide 2e28c0b JCLOUDS-1458

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

trevorflanagan commented on this pull request. > + +Dimension Data CloudControl allows for Tags to be applied to assets. There are two parts to the tagging process, first a tag key needs to be created, second the tag key is applied to an asset. + +Create a tag key. We will use this to tag

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

trevorflanagan commented on this pull request. > + +## How to: Deploy a Network Domain + +For more information on Network Domains see [here](https://docs.mcp-services.net/display/CCD/Introduction+to+Cloud+Network+Domains+and+VLANs) + +The code to deploy a network domain follows. + +{%

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

trevorflanagan commented on this pull request. > +{% endhighlight %} + +A Vlan deployment is an asynchronous process. We need to wait for it to complete. The Dimension Data provider has built in predicates that will block execution and check that the Vlan's State has moved from PENDING_ADD to

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

trevorflanagan commented on this pull request. > + +A Network Domain deployment is an asynchronous process. We need to wait for it to complete. The Dimension Data provider +has built in google guice predicates that will block execution and check that the Network Domain's State has moved from

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

trevorflanagan commented on this pull request. > +{% highlight java %} +/* + * Deploy Network Domain to the Zone / Datacenter we wish to operate on. The response from this API is the Network Domain Identifier. + */ +String networkDomainId =

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

trevorflanagan commented on this pull request. > + +The code to deploy a network domain follows. + +{% highlight java %} +/* + * Deploy Network Domain to the Zone / Datacenter we wish to operate on. The response from this API is the Network Domain Identifier. + */ +

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

trevorflanagan commented on this pull request. > + +## Concepts + +The jclouds library wraps the [Dimension Data CloudControl API](https://docs.mcp-services.net/display/DEV/Welcome+to+the+CloudControl+documentation+portal). All operations are performed over SSL and authenticated using your

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

@trevorflanagan pushed 1 commit. 65f45b3 JCLOUDS-1458 Create Dimension Data Provider Guide -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

trevorflanagan commented on this pull request. > + +The Dimension Data CloudControl organization will be associated with one or more [MCP 2.0 Data Centers](https://docs.mcp-services.net/display/CCD/Introduction+to+MCP+2.0+Data+Center+Locations). A Data Center is a container for the assets

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

@trevorflanagan pushed 1 commit. 7855306 Example of Dimension Data CloudControl provider. Code review comments. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

trevorflanagan commented on this pull request. > +### Terms +Like any cloud provider, Dimension Data CloudControl has its own set of terms in cloud computing. To abstract this into jclouds' Compute interface, these terms were associated: + +- Node - a `Server` +- Image - both *user-uploaded*

[jira] [Updated] (JCLOUDS-1458) Create Dimension Data Provider Guide

[ https://issues.apache.org/jira/browse/JCLOUDS-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trevor Flanagan updated JCLOUDS-1458: - Labels: dimensiondata (was: ) > Create Dimension Data Provider Gu

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

trevorflanagan commented on this pull request. > + +-- + +## Concepts + +The jclouds library wraps the [Dimension Data CloudControl API](https://docs.mcp-services.net/display/DEV/Welcome+to+the+CloudControl+documentation+portal). All operations are performed over SSL and

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

@trevorflanagan pushed 1 commit. 99c618d Example of Dimension Data CloudControl provider. Code review comments. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

Thanks for taking a look @nacx I will make the required changes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/94#issuecomment-428505174

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

@trevorflanagan pushed 1 commit. 74b3524 JCLOUDS-1458 Create Dimension Data Provider Guide -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

@trevorflanagan pushed 1 commit. 3dd85f6 JCLOUDS-1458 Create Dimension Data Provider Guide -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-site/pull/220 -- Commit Summary -- * JCLOUDS-1458 Create Dimension Data Provider Guide -- File Changes -- A guides/dimensiondata.md (719) M guides/index.md (1) -- Patch Links --

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

@trevorflanagan pushed 1 commit. 9f7b5cf Adding comments to the code, in order to prep for adding guide to https://jclouds.apache.org/guides -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[jira] [Created] (JCLOUDS-1458) Create Dimension Data Provider Guide

Trevor Flanagan created JCLOUDS-1458: Summary: Create Dimension Data Provider Guide Key: JCLOUDS-1458 URL: https://issues.apache.org/jira/browse/JCLOUDS-1458 Project: jclouds Issue Type

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

@trevorflanagan pushed 1 commit. 3e1290a Adding comments to the code, in order to prep for adding guide to https://jclouds.apache.org/guides -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

@trevorflanagan pushed 1 commit. f5cc1cd Example of Dimension Data CloudControl provider -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

@trevorflanagan pushed 1 commit. 20a5a65 Ignore any exceptions when deleting servers or vlans for best effort cleanup -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[jclouds/jclouds-examples] Added Dimension Data examples (#94)

Bumped version to 2.2.0-SNAPSHOT across all modules Added three examples: 1. ```org.jclouds.examples.dimensiondata.cloudcontrol.DeployNetworkDomainVlanAndServer``` - deploys Network Domain, VLAN and a Server and waits for them to be state Normal and in the case of the Server for it also to be

[jira] [Created] (JCLOUDS-1457) Add Clean Server operation to ServerApi

Trevor Flanagan created JCLOUDS-1457: Summary: Add Clean Server operation to ServerApi Key: JCLOUDS-1457 URL: https://issues.apache.org/jira/browse/JCLOUDS-1457 Project: jclouds Issue

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

rebuild please appears to be a failure unrelated to my changes on jenkins -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/446#issuecomment-427003272

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

trevorflanagan commented on this pull request. > @@ -54,7 +54,7 @@ protected Builder() { id("dimensiondata-cloudcontrol").name("DimensionData CloudControl API").identityName("user name") .credentialName("user password")

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

trevorflanagan commented on this pull request. > } - private void applyTagToAsset() { I am doing this test in the ServerApiLiveTest now -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

trevorflanagan commented on this pull request. > @@ -89,8 +89,17 @@ public void setUp() { datacenters = getZones(); } + // private Set getZones() { + // return ctx.utils().injector().getInstance(ZoneIdsSupplier.class).get(); + // } + + // TODO this leads to a

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

trevorflanagan commented on this pull request. > @@ -45,4 +46,7 @@ @Delegate TagApi getTagApi(); + + @Delegate + CustomerImageApi getCustomerImageApi(); A new API added as part of this so that we can delete the image we create when we test the clone api. -- You are receiving

[jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

I have removed the reliance on pre-seeded servers, images, networks and vlans and instead the tests will setup and importantly clear down what they create. The tests will now be run with the following ``` mvn clean install -Plive -pl dimensiondata

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

> Wow, something went wrong during synchronization with master, a lot of > commits here that are not supposed to be part of PR. Should I recreate branch > and PR maybe? I think it might be the best thing to do @btrishkin, especially since the scope of the changes has reduced since the original

Re: [jclouds/jclouds-labs] JCLOUDS-1432 - handle RESOURCE_NOT_FOUND, (#439)

This is @FileIOUtility first PR for Apache jclouds but he has been working on several aspects of the project for a while now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[jira] [Created] (JCLOUDS-1432) API Client expects 404 code when asset UUID not found for Get APIs

Trevor Flanagan created JCLOUDS-1432: Summary: API Client expects 404 code when asset UUID not found for Get APIs Key: JCLOUDS-1432 URL: https://issues.apache.org/jira/browse/JCLOUDS-1432 Project

[jira] [Updated] (JCLOUDS-1432) API Client expects 404 code when asset UUID not found for Get APIs

[ https://issues.apache.org/jira/browse/JCLOUDS-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Trevor Flanagan updated JCLOUDS-1432: - Description: API Client expects 404 code when asset UUID not found for Get APIs

[jira] [Created] (JCLOUDS-1431) Support AU geo for Live Tests

Trevor Flanagan created JCLOUDS-1431: Summary: Support AU geo for Live Tests Key: JCLOUDS-1431 URL: https://issues.apache.org/jira/browse/JCLOUDS-1431 Project: jclouds Issue Type: Task

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

trevorflanagan commented on this pull request. > +import static com.google.inject.internal.util.$Preconditions.checkNotNull; + +@Singleton +public class DatacenterToLocation implements Function { + + private final JustProvider justProvider; + + @Inject + public

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

trevorflanagan commented on this pull request. > +@Singleton +public class DatacenterToLocation implements Function { + + private final JustProvider justProvider; + + @Inject + public DatacenterToLocation(JustProvider justProvider) { + this.justProvider =

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

trevorflanagan commented on this pull request. >super(builder); } public static Properties defaultProperties() { Properties properties = DimensionDataCloudControlApiMetadata.defaultProperties(); + properties.setProperty(PROPERTY_REGIONS, "na,eu,au,mea,ap,canada");

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

Appreciate all the help with this one @nacx , I've learnt alot about jclouds working on it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/433#issuecomment-382742915

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

trevorflanagan commented on this pull request. > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.jclouds.dimensiondata.cloudcontrol.options;

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

trevorflanagan commented on this pull request. >super(builder); } public static Properties defaultProperties() { Properties properties = DimensionDataCloudControlApiMetadata.defaultProperties(); + properties.setProperty(PROPERTY_REGIONS, "na,eu,au,mea,ap,canada");

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

Suggested changes made @nacx, thanks. I have also re-based onto master and squashed commits. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/433#issuecomment-382696716

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

@trevorflanagan pushed 3 commits. 26724ba JCLOUDS-1406 - Add default location configuration to dimension data provider 1070c18 JCLOUDS-1406 - Add default location configuration to dimension data provider f20b15d JCLOUDS-1406 - Add default location configuration to dimension data provider

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/433#issuecomment-382462656

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

@nacx - I have taken a look at what you are proposing. I do see the value in what you suggest. However I am slightly confused about how I might complete this. I have [pushed a new branch](https://github.com/DimensionDataDublin/jclouds-labs/tree/zones_review_updates_for_nacx) that maybe you

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

@trevorflanagan pushed 2 commits. 8d13f3e JCLOUDS-1406 - Add default location configuration to dimension data provider b702c82 JCLOUDS-1406 - Add default location configuration to dimension data provider -- You are receiving this because you are subscribed to this thread. View it on

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

@nacx this sounds nice, the rebuilding of the filter options wasn't a nice approach. I will take a look and see how this looks. It might be a couple of days before I can provide some updates. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

> Change looks good. Would it make sense, though, to create a couple filter > objects ListServerOptions and ListDatacenterOptions that extend > PaginationOptions and introduce the datacenter query parameters? if the > datacenter filter parameter is optional, then it would be better and cleaner

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

trevorflanagan commented on this pull request. >super(builder); } public static Properties defaultProperties() { Properties properties = DimensionDataCloudControlApiMetadata.defaultProperties(); + properties.setProperty(PROPERTY_REGIONS, "na,eu,au,mea,ap,canada");

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

trevorflanagan commented on this pull request. > @@ -40,6 +51,16 @@ @ConfiguresHttpApi public class DimensionDataCloudControlHttpApiModule extends HttpApiModule { + @Override + protected void installLocations() { + super.installLocations(); +

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

@nacx I have made the suggested changes, but I am stuck with another one of those circular dependency issues. My only thought is that the ordering of bindings in `org.jclouds.dimensiondata.cloudcontrol.config.DimensionDataCloudControlHttpApiModule#installLocations` could be the problem? here

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

trevorflanagan commented on this pull request. >if (datacenterIds != null && !datacenterIds.isEmpty()) { - return request.toBuilder().addQueryParam("datacenterId", datacenterIds).build(); + return request.toBuilder().addQueryParam(queryParam, datacenterIds).build();

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

@trevorflanagan pushed 1 commit. b50bb1f JCLOUDS-1406 - Add default location configuration to dimension data provider -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

trevorflanagan commented on this pull request. > @@ -40,6 +43,17 @@ @ConfiguresHttpApi public class DimensionDataCloudControlHttpApiModule extends HttpApiModule { + @Override + protected void installLocations() { + super.installLocations(); + //

[jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/433 -- Commit Summary -- * JCLOUDS-1406 - Add default location configuration to dimension data provider -- File Changes -- M dimensiondata/pom.xml (1) M

[jira] [Created] (JCLOUDS-1406) Add default location configuration to dimension data provider

Trevor Flanagan created JCLOUDS-1406: Summary: Add default location configuration to dimension data provider Key: JCLOUDS-1406 URL: https://issues.apache.org/jira/browse/JCLOUDS-1406 Project

[jclouds/jclouds-labs] JCLOUDS-1405 - Dimension Data Live Tests Broken - Domain classes for Server and Image with List nics incorrect (#432)

https://issues.apache.org/jira/browse/JCLOUDS-1405 Build output for Live Tests: > Running TestSuite > Configuring TestNG with: TestNG652Configurator > Starting test > testGetAccount(org.jclouds.dimensiondata.cloudcontrol.features.AccountApiLiveTest) > [TestNG] Test >

[jira] [Created] (JCLOUDS-1405) Dimension Data Live Tests Broken - Domain classes for Server and Image with List nics incorrect

Trevor Flanagan created JCLOUDS-1405: Summary: Dimension Data Live Tests Broken - Domain classes for Server and Image with List nics incorrect Key: JCLOUDS-1405 URL: https://issues.apache.org/jira/browse

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

trevorflanagan commented on this pull request. > +import static com.google.inject.internal.util.$Preconditions.checkNotNull; + +@Singleton +public class DatacenterToLocation implements Function { + + private final JustProvider justProvider; + + @Inject + public

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

trevorflanagan commented on this pull request. > +@Singleton +public class DatacenterToLocation implements Function { + + private final JustProvider justProvider; + + @Inject + public DatacenterToLocation(JustProvider justProvider) { + this.justProvider =

Re: [jclouds/jclouds-labs] Implement ServerWithNatRuleToNodeMetadata Function (#428)

trevorflanagan commented on this pull request. > + this.nodeNamingConvention = checkNotNull(namingConvention, > "namingConvention").createWithoutPrefix(); + this.locations = checkNotNull(locations, "locations"); + this.baseImageToImage = checkNotNull(baseImageToImage,

Re: [jclouds/jclouds-labs] Implement GetOrCreateNetworkDomainThenCreateNodes Strategy (#426)

@nacx I have squashed my commits. As agreed earlier on slack I have done with the approach of defaulting to a single vlan for the nodes created. I am also using the approach of storing `vlanName` in `templateOptions.networks(vlanName);` -- You are receiving this because you are subscribed to

  1   2   3   >