Re: [jclouds-labs-openstack] Add Manila support (#198)

2015-07-27 Thread Zack Shoylev
Closed #198. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/198#event-366096053

Re: [jclouds-labs-openstack] Add Manila support (#198)

2015-07-27 Thread Zack Shoylev
Reopened #198. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/198#event-366096075

Re: [jclouds-labs-openstack] Add Manila support (#198)

2015-07-27 Thread Zack Shoylev
Closed #198. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/198#event-366052273

Re: [jclouds-labs-openstack] Add Manila support (#198)

2015-07-27 Thread Zack Shoylev
I have merged the jclouds prereq PR. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/198#issuecomment-125198739

Re: [jclouds-labs-openstack] Add Manila support (#198)

2015-07-27 Thread Zack Shoylev
Reopened #198. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/198#event-366052286

Re: [jclouds] Add awareness of Manila and SHARED_FILESYSTEM openstack projects (#821)

2015-07-27 Thread Zack Shoylev
Closed #821. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/821#event-366029827

Re: [jclouds] Add awareness of Manila and SHARED_FILESYSTEM openstack projects (#821)

2015-07-27 Thread Zack Shoylev
merged, backported --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/821#issuecomment-125191314

Re: [jclouds] add os-hypervisors extension (#819)

2015-07-27 Thread Zack Shoylev
Closed #819. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/819#event-366014737

Re: [jclouds] add os-hypervisors extension (#819)

2015-07-27 Thread Zack Shoylev
merged and backported --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/819#issuecomment-125185167

Re: [jclouds] add os-hypervisors extension (#819)

2015-07-24 Thread Zack Shoylev
want to run it through some tests, but looks good. If it works ok, we might have to refactor some other mock tests to use it as well. From: arvindn05 Sent: Thursday, July 23, 2015 3:51 AM To: jclouds/jclouds Cc: Zack Shoylev Subject: Re: [jclouds] add os-h

Re: [jclouds] add os-hypervisors extension (#819)

2015-07-22 Thread Zack Shoylev
> +import org.jclouds.http.HttpRequest; > +import org.jclouds.http.HttpResponse; > +import org.jclouds.openstack.nova.v2_0.NovaApi; > +import org.jclouds.openstack.nova.v2_0.domain.regionscoped.Hypervisor; > +import org.jclouds.openstack.nova.v2_0.domain.regionscoped.HypervisorDetails; > +import or

Re: [jclouds] add os-hypervisors extension (#819)

2015-07-22 Thread Zack Shoylev
> +import org.jclouds.http.HttpRequest; > +import org.jclouds.http.HttpResponse; > +import org.jclouds.openstack.nova.v2_0.NovaApi; > +import org.jclouds.openstack.nova.v2_0.domain.regionscoped.Hypervisor; > +import org.jclouds.openstack.nova.v2_0.domain.regionscoped.HypervisorDetails; > +import or

Re: [jclouds] Do not test marker contents (#820)

2015-07-21 Thread Zack Shoylev
@andrewgaul I might not be able to test until next week, but will give it a try. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/820#issuecomment-123568819

Re: [jclouds] add os-hypervisors extension (#819)

2015-07-21 Thread Zack Shoylev
> +import org.jclouds.http.HttpRequest; > +import org.jclouds.http.HttpResponse; > +import org.jclouds.openstack.nova.v2_0.NovaApi; > +import org.jclouds.openstack.nova.v2_0.domain.regionscoped.Hypervisor; > +import org.jclouds.openstack.nova.v2_0.domain.regionscoped.HypervisorDetails; > +import or

Re: [jclouds] Add awareness of Manila and SHARED_FILESYSTEM openstack projects (#821)

2015-07-21 Thread Zack Shoylev
Looks good to me, but might not be able to merge it until Saturday. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/821#issuecomment-123564906

Re: [jclouds] Add awareness of Manila and SHARED_FILESYSTEM openstack projects (#821)

2015-07-21 Thread Zack Shoylev
Reopened #821. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/821#event-361738700

Re: [jclouds] Add awareness of Manila and SHARED_FILESYSTEM openstack projects (#821)

2015-07-21 Thread Zack Shoylev
Closed #821. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/821#event-361738691

Re: [jclouds-labs-openstack] Add Manila support (#198)

2015-07-21 Thread Zack Shoylev
Wow, that's a lot of work there! Thank you for contributing. I added some notes. To see how these notes are implemented in other places, check our support for openstack-heat here: https://github.com/jclouds/jclouds-labs-openstack/tree/master/openstack-heat/src/main/java/org/jclouds/openstack/hea

Re: [jclouds-labs-openstack] Add Manila support (#198)

2015-07-21 Thread Zack Shoylev
> + > +import org.jclouds.date.DateService; > +import org.jclouds.date.internal.SimpleDateFormatDateService; > +import org.jclouds.http.HttpResponse; > +import org.jclouds.openstack.manila.v1.domain.Share; > +import org.jclouds.openstack.manila.v1.options.CreateShareOptions; > +import org.jclouds.r

Re: [jclouds-labs-openstack] Add Manila support (#198)

2015-07-21 Thread Zack Shoylev
> + @Nullable > + ShareNetwork get(@PathParam("id") String shareNetworkId); > + > + /** > +* Creates a new ShareNetwork > +* > +* @param shareNetworkId Id of the ShareNetwork > +* @param options See CreateShareNetworkOptions > +* @return The new ShareNetwork > +*/ > +

Re: [jclouds-labs-openstack] Add Manila support (#198)

2015-07-21 Thread Zack Shoylev
> + */ > +@SkipEncoding({'/', '='}) > +@RequestFilters(AuthenticateRequest.class) > +@Consumes(MediaType.APPLICATION_JSON) > +@Path("/share-networks") > +public interface ShareNetworkApi { > + /** > +* Returns a summary list of ShareNetworks. > +* > +* @return The list of ShareNetwork

Re: [jclouds-labs-openstack] Add Manila support (#198)

2015-07-21 Thread Zack Shoylev
> + */ > +@SkipEncoding({'/', '='}) > +@RequestFilters(AuthenticateRequest.class) > +@Consumes(MediaType.APPLICATION_JSON) > +@Path("/share-networks") > +public interface ShareNetworkApi { > + /** > +* Returns a summary list of ShareNetworks. > +* > +* @return The list of ShareNetwork

Re: [jclouds-labs-openstack] Add Manila support (#198)

2015-07-21 Thread Zack Shoylev
> +import java.util.Date; > +import java.util.Map; > + > +import javax.inject.Named; > + > +import org.jclouds.javax.annotation.Nullable; > + > +import com.google.common.base.CaseFormat; > +import com.google.common.base.Objects; > +import com.google.common.base.Objects.ToStringHelper; > +import com

Re: [jclouds-labs-openstack] Add Manila support (#198)

2015-07-21 Thread Zack Shoylev
Note: Failing because it depends on the corresponding jclouds change for service type. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/198#issuecomment-123489121

Re: [jclouds] Add awareness of Manila and SHARED_FILESYSTEM openstack projects (#821)

2015-07-21 Thread Zack Shoylev
Closed #821. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/821#event-361664233

Re: [jclouds] Add awareness of Manila and SHARED_FILESYSTEM openstack projects (#821)

2015-07-21 Thread Zack Shoylev
Reopened #821. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/821#event-361664261

Re: [jclouds] add os-hypervisors extension (#819)

2015-07-20 Thread Zack Shoylev
> +import org.jclouds.http.HttpRequest; > +import org.jclouds.http.HttpResponse; > +import org.jclouds.openstack.nova.v2_0.NovaApi; > +import org.jclouds.openstack.nova.v2_0.domain.regionscoped.Hypervisor; > +import org.jclouds.openstack.nova.v2_0.domain.regionscoped.HypervisorDetails; > +import or

Re: [jclouds] add os-hypervisors extension (#819)

2015-07-20 Thread Zack Shoylev
> +package org.jclouds.openstack.nova.v2_0.domain.regionscoped; > + > +import com.google.auto.value.AutoValue; > +import org.jclouds.json.SerializedNames; > + > +/** > + * Hypervisor which shows id, name and other details > + */ > +@AutoValue > +public abstract class HypervisorDetails { > + > + p

[jira] [Created] (JCLOUDS-965) Ensure jclouds retries properly when writing the request is interrupted

2015-07-17 Thread Zack Shoylev (JIRA)
Zack Shoylev created JCLOUDS-965: Summary: Ensure jclouds retries properly when writing the request is interrupted Key: JCLOUDS-965 URL: https://issues.apache.org/jira/browse/JCLOUDS-965 Project

Re: [jclouds] Split availability Zone API to return Basic Info and Detailed info (#815)

2015-07-16 Thread Zack Shoylev
Closed #815. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/815#event-357808807

Re: [jclouds] Split availability Zone API to return Basic Info and Detailed info (#815)

2015-07-16 Thread Zack Shoylev
merged, backported --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/815#issuecomment-122041635

[jira] [Commented] (JCLOUDS-963) jcloud IOExpection: Error writing request body to server

2015-07-16 Thread Zack Shoylev (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629839#comment-14629839 ] Zack Shoylev commented on JCLOUDS-963: -- I suspect fairly normal network prob

Re: [jclouds] Split availability Zone API to return Basic Info and Detailed info (#815)

2015-07-15 Thread Zack Shoylev
Going to try rebuilding... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/815#issuecomment-121796608

Re: [jclouds] Split availability Zone API to return Basic Info and Detailed info (#815)

2015-07-15 Thread Zack Shoylev
Closed #815. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/815#event-357070225

Re: [jclouds] Split availability Zone API to return Basic Info and Detailed info (#815)

2015-07-15 Thread Zack Shoylev
Reopened #815. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/815#event-357070227

Re: [jclouds] Split availability Zone API to return Basic Info and Detailed info (#815)

2015-07-15 Thread Zack Shoylev
Can we add some of your first comment in this PR as in-code docs for the domain classes? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/815#issuecomment-121768474

Re: [jclouds] Split availability Zone API to return Basic Info and Detailed info (#815)

2015-07-15 Thread Zack Shoylev
> @@ -34,7 +36,7 @@ > @Test(groups = "unit", testName = "AvailabilityZoneApiExpectTest") > public class AvailabilityZoneApiExpectTest extends BaseNovaApiExpectTest { > > - public void testAvailabilityZonesList() throws Exception { > + public void testListAvailabilityZones() throws Exception

Re: [jclouds] Split availability Zone API to return Basic Info and Detailed info (#815)

2015-07-15 Thread Zack Shoylev
> + * See the License for the specific language governing permissions and > + * limitations under the License. > + */ > +package org.jclouds.openstack.nova.v2_0.domain.regionscoped; > + > +import com.google.common.base.Objects; > +import com.google.common.collect.ImmutableMap; > +import com.google.

Re: [jclouds] Split availability Zone API to return Basic Info and Detailed info (#815)

2015-07-15 Thread Zack Shoylev
> + * See the License for the specific language governing permissions and > + * limitations under the License. > + */ > +package org.jclouds.openstack.nova.v2_0.domain.regionscoped; > + > +import com.google.common.base.Objects; > +import com.google.common.collect.ImmutableMap; > +import com.google.

Re: [jclouds] Adds missing floating-ip-pool expect test (#813)

2015-07-14 Thread Zack Shoylev
Closed #813. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/813#event-355952792

Re: [jclouds] Adds missing floating-ip-pool expect test (#813)

2015-07-14 Thread Zack Shoylev
merged, backported --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/813#issuecomment-121434718

Re: [jclouds] Adds missng floating-ip-pool expect test (#813)

2015-07-14 Thread Zack Shoylev
Also note https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/contrib/floating_ip_pools.py --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/813#issuecomment-121431532

[jira] [Resolved] (JCLOUDS-700) OpenStack Nova AvailabilityZone class missing "hosts" field

2015-07-14 Thread Zack Shoylev (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zack Shoylev resolved JCLOUDS-700. -- Resolution: Fixed Fix Version/s: (was: 2.0.0) 1.9.1 > OpenSt

Re: [jclouds] Adding missing "hosts" field to OpenStack Nova AvailabilityZone (#806)

2015-07-14 Thread Zack Shoylev
Closed #806. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/806#event-355939619

Re: [jclouds] Adding missing "hosts" field to OpenStack Nova AvailabilityZone (#806)

2015-07-14 Thread Zack Shoylev
merged, backported. Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/806#issuecomment-121431327

[jclouds] Adds missng floating-ip-pool expect test (#813)

2015-07-14 Thread Zack Shoylev
Fixes broken namespace for the ip pool extension You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/813 -- Commit Summary -- * Adds missng floating-ip-pool expect test -- File Changes -- M apis/openstack-nova/src/main/java/org/jclou

[jira] [Commented] (JCLOUDS-700) OpenStack Nova AvailabilityZone class missing "hosts" field

2015-07-14 Thread Zack Shoylev (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627297#comment-14627297 ] Zack Shoylev commented on JCLOUDS-700: -- https://github.com/jclouds/jclouds/pull

[jira] [Resolved] (JCLOUDS-333) Glance failed to parse Image details which has microseconds in Date format

2015-07-14 Thread Zack Shoylev (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zack Shoylev resolved JCLOUDS-333. -- Resolution: Fixed > Glance failed to parse Image details which has microseconds in Date for

Re: [jclouds] Adding missing "hosts" field to OpenStack Nova AvailabilityZone (#806)

2015-07-14 Thread Zack Shoylev
Hm, no, that seems to have messed it up again. What I do: In my PR branch, I rebase the last 2 (or more) commits: git rebase -i HEAD~2 Then I force push to the github branch I used for the pull request: git push -f --- Reply to this email directly or view it on GitHub: https://github.com/jclou

Re: [jclouds] Updates live tests and template builder settings for compute (#809)

2015-07-14 Thread Zack Shoylev
Closed #809. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/809#event-355476344

Re: [jclouds] Updates live tests and template builder settings for compute (#809)

2015-07-14 Thread Zack Shoylev
merged and backported --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/809#issuecomment-121281052

Re: [jclouds] Adding missing "hosts" field to OpenStack Nova AvailabilityZone (#806)

2015-07-14 Thread Zack Shoylev
Thanks for explaining! In this case, this should be good to merge - rebase to a single commit. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/806#issuecomment-121258189

Re: [jclouds] Updates live tests and template builder settings for compute (#809)

2015-07-13 Thread Zack Shoylev
This will have to be backported --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/809#issuecomment-121143386

[jclouds] Updates live tests and template builder settings for compute (#809)

2015-07-13 Thread Zack Shoylev
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/809 -- Commit Summary -- * Updates live tests and template builder settings for compute -- File Changes -- M compute/src/main/java/org/jclouds/compute/reference/ComputeServiceConst

[jira] [Updated] (JCLOUDS-907) Extra space in endpoint causes exception

2015-07-13 Thread Zack Shoylev (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zack Shoylev updated JCLOUDS-907: - Fix Version/s: (was: 1.9.1) 2.0.0 > Extra space in endpoint cau

[jira] [Commented] (JCLOUDS-907) Extra space in endpoint causes exception

2015-07-13 Thread Zack Shoylev (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625659#comment-14625659 ] Zack Shoylev commented on JCLOUDS-907: -- It won't make it for 1.9.1; mostl

Re: [jclouds] Adding missing "hosts" field to OpenStack Nova AvailabilityZone (#806)

2015-07-13 Thread Zack Shoylev
Ok. Thanks, ran it and looks good, but I have some questions: It seems you need to deprecate, because you are using a new AvailabilityZone class. Why not just update the old availability zone so you don't have to deprecate it? It seems the new one is just adding stuff, so it should be backwards

Re: [jclouds] Adding missing "hosts" field to OpenStack Nova AvailabilityZone (#806)

2015-07-10 Thread Zack Shoylev
> @@ -34,11 +33,21 @@ public void testListAvailabilityZones() throws Exception { > >Optional availabilityZoneApi = > api.getAvailabilityZoneApi("RegionOne"); >if (availabilityZoneApi.isPresent()) { > - FluentIterable zones = > availabilityZoneApi.get().list(); > +

Re: [jclouds] Adding missing "hosts" field to OpenStack Nova AvailabilityZone (#806)

2015-07-10 Thread Zack Shoylev
> @@ -34,11 +33,21 @@ public void testListAvailabilityZones() throws Exception { > >Optional availabilityZoneApi = > api.getAvailabilityZoneApi("RegionOne"); >if (availabilityZoneApi.isPresent()) { > - FluentIterable zones = > availabilityZoneApi.get().list(); > +

Re: [jclouds] Adding missing "hosts" field to OpenStack Nova AvailabilityZone (#806)

2015-07-10 Thread Zack Shoylev
Closed #806. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/806#event-353012009

Re: [jclouds-labs-openstack] Fixes issue where glance fails to parse image details (#197)

2015-07-09 Thread Zack Shoylev
Thank you for contributing! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/197#issuecomment-120174005

Re: [jclouds] Removes CopyObjectException in favor of standard blobstore exceptions (#804)

2015-07-09 Thread Zack Shoylev
Closed #804. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/804#event-352428392

Re: [jclouds] Removes CopyObjectException in favor of standard blobstore exceptions (#804)

2015-07-09 Thread Zack Shoylev
merged but not backported --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/804#issuecomment-120173734

Re: [jclouds] Removes CopyObjectException in favor of standard blobstore exceptions (#804)

2015-07-09 Thread Zack Shoylev
Rebuild, please. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/804#issuecomment-120168172

Re: [jclouds] Removes CopyObjectException in favor of standard blobstore exceptions (#804)

2015-07-09 Thread Zack Shoylev
> @@ -141,20 +142,17 @@ public void testCopyObject() throws Exception { > // test exception thrown on bad source name > try { > destApi.copy(destinationObject, badSource, sourceObjectName); > -fail("Expected CopyObjectException"); Ah, right. Thanks, I w

Re: [jclouds-labs-openstack] Fixes issue where glance fails to parse image details (#197)

2015-07-09 Thread Zack Shoylev
Closed #197. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/197#event-352274058

Re: [jclouds-labs-openstack] Fixes issue where glance fails to parse image details (#197)

2015-07-09 Thread Zack Shoylev
merged and backported --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/197#issuecomment-120128167

Re: [jclouds-labs-openstack] Fixes issue where glance fails to parse image details with milli seconds in the date (#195)

2015-07-09 Thread Zack Shoylev
Thanks, I will merge and backport in a bit. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/195#issuecomment-120109048

Re: [jclouds] Removes CopyObjectException in favor of standard blobstore exceptions (#804)

2015-07-09 Thread Zack Shoylev
@andrewgaul ^ --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/804#issuecomment-120083348

[jira] [Commented] (JCLOUDS-957) openstack-swift provider throws different exceptions for copyBlob

2015-07-09 Thread Zack Shoylev (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620869#comment-14620869 ] Zack Shoylev commented on JCLOUDS-957: -- https://github.com/jclouds/jclouds/pull

Re: [jclouds] Removes CopyObjectException in favor of standard blobstore exceptions (#804)

2015-07-09 Thread Zack Shoylev
https://issues.apache.org/jira/browse/JCLOUDS-957 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/804#issuecomment-120075502

[jclouds] Removes CopyObjectException in favor of standard blobstore exceptions (#804)

2015-07-09 Thread Zack Shoylev
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/804 -- Commit Summary -- * Removes CopyObjectException in favor of jclouds-standard blobstore exceptions -- File Changes -- D apis/openstack-swift/src/main/java/org/jclouds/openst

Re: [jclouds-labs-openstack] Fixes issue where glance fails to parse image details with milli seconds in the date (#195)

2015-07-08 Thread Zack Shoylev
Hmm commits seem messed up. If you want to, you can make a new one. Just make sure to reference it here. Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/195#issuecomment-119784737

Re: [jclouds] Fixes a small test bug on windows (#803)

2015-07-08 Thread Zack Shoylev
Closed #803. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/803#event-351392236

Re: [jclouds] Fixes a small test bug on windows (#803)

2015-07-08 Thread Zack Shoylev
merged --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/803#issuecomment-119776774

[jclouds] Fixes a small test bug on windows (#803)

2015-07-08 Thread Zack Shoylev
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/803 -- Commit Summary -- * Fixes a small test bug on windows -- File Changes -- M apis/filesystem/src/test/java/org/jclouds/filesystem/FilesystemBlobStoreTest.java (2) -- Patch L

Re: [jclouds-labs-openstack] Fixes issue where glance fails to parse image details with milli seconds in the date (#195)

2015-07-08 Thread Zack Shoylev
Rebase to a single commit --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/195#issuecomment-119757953

[jira] [Resolved] (JCLOUDS-680) OpenStack Swift: Improve Object update behavior

2015-07-08 Thread Zack Shoylev (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zack Shoylev resolved JCLOUDS-680. -- Resolution: Fixed > OpenStack Swift: Improve Object update behav

[jira] [Commented] (JCLOUDS-680) OpenStack Swift: Improve Object update behavior

2015-07-08 Thread Zack Shoylev (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619580#comment-14619580 ] Zack Shoylev commented on JCLOUDS-680: -- I think it's better now. > Ope

[jira] [Commented] (JCLOUDS-957) openstack-swift provider throws different exceptions for copyBlob

2015-07-08 Thread Zack Shoylev (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618823#comment-14618823 ] Zack Shoylev commented on JCLOUDS-957: -- I'm looking > openstack-sw

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-07-02 Thread Zack Shoylev
squashed, merged, backported --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/196#issuecomment-118152081

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-07-02 Thread Zack Shoylev
Closed #196. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/196#event-346826522

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-07-02 Thread Zack Shoylev
> + */ > + public abstract Builder adminStateUp(Boolean adminStateUp); > + > + /** > + * > + * @param firewallPolicyId The firewall policy uuid that this firewall > is associated with. This firewall implements the rules contained in the > + *

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-07-02 Thread Zack Shoylev
That is strange. Sure, but maybe have a look and see it's not something else that's going wrong. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/196#issuecomment-118012210

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-07-02 Thread Zack Shoylev
Also I think the getSomeName() getters were fine. Auto works fine with getName() and name(String name)/getName() in the builder, for example. https://github.com/jclouds/jclouds-labs-openstack/blob/master/openstack-heat/src/main/java/org/jclouds/openstack/heat/v1/options/CreateStack.java --- Reply

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-07-02 Thread Zack Shoylev
Another thing I overlooked - openstack-heat has the good up-to-date examples that I recently refactored. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/196#issuecomment-118010952

[jira] [Created] (JCLOUDS-954) Upgrade trove to current openstack features

2015-07-02 Thread Zack Shoylev (JIRA)
Zack Shoylev created JCLOUDS-954: Summary: Upgrade trove to current openstack features Key: JCLOUDS-954 URL: https://issues.apache.org/jira/browse/JCLOUDS-954 Project: jclouds Issue Type

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-07-01 Thread Zack Shoylev
> +public abstract class CreateFirewallPolicy { > + > + @Nullable public abstract String getTenantId(); > + @Nullable public abstract String getName(); > + @Nullable public abstract String getDescription(); > + public abstract boolean isShared(); > + @Nullable public abstract List getFire

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-07-01 Thread Zack Shoylev
> + @Nullable public abstract String getStatus(); > + @Nullable public abstract String getFirewallPolicyId(); > + > + @SerializedNames({"id", "tenant_id", "name", "description", > "admin_state_up", "status", "firewall_policy_id"}) > + public static Firewall create(String id, String tenantI

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-07-01 Thread Zack Shoylev
> +public abstract class CreateFirewallPolicy { > + > + @Nullable public abstract String getTenantId(); > + @Nullable public abstract String getName(); > + @Nullable public abstract String getDescription(); > + public abstract boolean isShared(); > + @Nullable public abstract List getFire

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-07-01 Thread Zack Shoylev
> + > +/** > + * A firewall policy > + * > + * @see + * > href="http://docs.openstack.org/admin-guide-cloud/content/fwaas_api_abstractions.html";>api > doc > + */ > +@AutoValue > +public abstract class FirewallPolicy { > + > + @Nullable > + public abstract String getId(); > + @Nullabl

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-07-01 Thread Zack Shoylev
> + @SelectJson("firewall") > + @Fallback(NullOnNotFoundOr404.class) > + @Nullable > + Firewall get(@PathParam("id") String id); > + > + /** > +* Create a new firewall > +* > +* @param firewall Options for creating a firewall > +* @return the newly created firewall > +

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-07-01 Thread Zack Shoylev
Thanks @andreaturli ; looking pretty good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/196#issuecomment-117638687

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-07-01 Thread Zack Shoylev
> + > + @Named("firewall:insertFirewallRuleToPolicy") > + @PUT > + @Path("/firewall_policies/{id}/insert_rule") > + @Fallback(NullOnNotFoundOr404.class) > + @Nullable > + FirewallPolicy insertFirewallRuleToPolicy(@PathParam("id") String > policyId, @WrapWith("firewall_rule_id") String

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-07-01 Thread Zack Shoylev
> +import org.jclouds.javax.annotation.Nullable; > +import org.jclouds.json.SerializedNames; > + > +import com.google.auto.value.AutoValue; > +import com.google.common.collect.ImmutableList; > + > +/** > + * A firewall policy > + * > + * @see + * > href="http://docs.openstack.org/admin-guide

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-07-01 Thread Zack Shoylev
> + @SelectJson("firewall") > + @Fallback(NullOnNotFoundOr404.class) > + @Nullable > + Firewall get(@PathParam("id") String id); > + > + /** > +* Create a new firewall > +* > +* @param firewall Options for creating a firewall > +* @return the newly created firewall > +

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-07-01 Thread Zack Shoylev
> + > +/** > + * A firewall policy > + * > + * @see + * > href="http://docs.openstack.org/admin-guide-cloud/content/fwaas_api_abstractions.html";>api > doc > + */ > +@AutoValue > +public abstract class FirewallPolicy { > + > + @Nullable > + public abstract String getId(); > + @Nullabl

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-07-01 Thread Zack Shoylev
> + * @see + * > href="http://docs.openstack.org/admin-guide-cloud/content/fwaas_api_abstractions.html";>api > doc > + */ > +@AutoValue > +public abstract class FirewallPolicy { > + > + @Nullable > + public abstract String getId(); > + @Nullable public abstract String getTenantId(); >

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-07-01 Thread Zack Shoylev
> + > +/** > + * A Firewall > + * > + * @see + * > href="http://docs.openstack.org/admin-guide-cloud/content/fwaas_api_abstractions.html";>api > + * doc > + */ > +@AutoValue > +public abstract class Firewall { > + > + @Nullable public abstract String getId(); > + @Nullable public ab

Re: [jclouds-labs-openstack] add FWaaS extension to openstack-neutron (#196)

2015-06-30 Thread Zack Shoylev
> @@ -47,6 +48,10 @@ public void testCreateUpdateAndDeleteSecurityGroup() { > try { > sgApi = api.getSecurityGroupApi(region).get(); > > +for (Subnet subnet : > api.getSubnetApi(region).list().concat().toList()) { > + System.out.println("subnet: "

<    1   2   3   4   5   6   7   8   9   10   >