in that case, should we also remove the check for maximum file path size being
255 bytes?
I left that in because that is not configurable in openstack.
checkArgument(
path.getBytes().length < 255,
String.format("maximum length of path is 255 bytes. Path
specified %s
@nacx Please review when you get a chance
https://issues.apache.org/jira/browse/JCLOUDS-1175
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1012#issuecomment-249039546
Fix issue JCLOUDS-1175 by removing hardcoded content sizes in Openstack
Nova API
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1012
-- Commit Summary --
* Remove hardcoded limitation of content size in Openstack Nova
CreateServerOpti
i think so for now. But the issue i created was to track a general issue with
with new validations introduced as part of v2.1 of openstack api's.
This might be only the first instance of these new validations causing
issues...i will reopen if i see issues in other apis.
Thanks for the quick rev
thanks Zack!
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/974#issuecomment-227290091
Reopened #974.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/974#event-696922533
Closed #974.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/974#event-696922532
Fix Issue with flavor creation by making links nullable
see https://issues.apache.org/jira/browse/JCLOUDS-1126
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/974
-- Commit Summary --
* Make links nullable
-- File Changes --
M
ap
Closed #973.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/973#event-696918056
Reopened #973.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/973#event-696918013
Closed #973.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/973#event-696917894
Closed #973.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/973#event-696905448
Reopened #973.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/973#event-696905453
Fix Issue with flavor creation by making links nullable
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/973
-- Commit Summary --
* Make links nullable
-- File Changes --
M
apis/openstack-keystone/src/main/java/org/jclouds/opensta
Closed #972.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/972#event-696902205
@arvindn05 pushed 2 commits.
60f5c55 Make links nullable
f45f74c Merge branch 'master' of https://github.com/arvindn05/jclouds
---
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull
Fix issue with flavor creation
https://issues.apache.org/jira/browse/JCLOUDS-1126
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/972
-- Commit Summary --
* Make links nullable
-- File Changes --
M
apis/openstack-keystone/src/ma
>>but is there a way to filter just sensitive data from the payload? Like
>>search-and-replace passwords?
by the time we get the payload data, it has been converted into JSON and the
only way to selectively mask the sensitive payload, we would have to go with a
search and replace solution.
I do
change default behavior of log to print sensitive information
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/834
-- Commit Summary --
* change default behavior of log to print sensitive information
-- File Changes --
M
apis/open
we do add this message in its place instead of removing the payload "Sensitive
data in payload, use PROPERTY_LOGGER_WIRE_LOG_SENSITIVE_INFO override to enable
logging this data." so its going to be obvious i hope.
like i said i am fine either way, though i prefer keeping the authentication
pay
@nacx I am fine if you want the default behavior to be that you print out the
password information in plaintext for 1.9.x
But since that will cause a security issue i would suggest to not do that. I
understand your concern about tooling and tools which process logs but they
should not be relyin
fixed as part of https://github.com/jclouds/jclouds/pull/819
to allow getting basic and and detailed information about hypervisors
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/729#issuecomment-126414502
thanks
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/830#issuecomment-126407782
I dont have any other work left on this.
@zack-shoylev we should be able to merge this to master. Is there anything i
need to do for helping you merge this to master?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/830#issuecomment-126404352
> @@ -83,8 +83,13 @@ static String
> requestPayloadIfStringOrFormIfNotReturnEmptyString(HttpRequest req
> && request.getPayload().getContentMetadata().getContentLength()
> != null
> && request.getPayload().getContentMetadata().getContentLength()
> < 1024) {
>
Fix bug where password information is printed in logs in case of exceptions in
keystone
fixes bug https://issues.apache.org/jira/browse/JCLOUDS-958
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/830
-- Commit Summary --
* Fix bug whe
> +import org.jclouds.http.HttpRequest;
> +import org.jclouds.http.HttpResponse;
> +import org.jclouds.openstack.nova.v2_0.NovaApi;
> +import org.jclouds.openstack.nova.v2_0.domain.regionscoped.Hypervisor;
> +import org.jclouds.openstack.nova.v2_0.domain.regionscoped.HypervisorDetails;
> +import or
> +import org.jclouds.http.HttpRequest;
> +import org.jclouds.http.HttpResponse;
> +import org.jclouds.openstack.nova.v2_0.NovaApi;
> +import org.jclouds.openstack.nova.v2_0.domain.regionscoped.Hypervisor;
> +import org.jclouds.openstack.nova.v2_0.domain.regionscoped.HypervisorDetails;
> +import or
> +import org.jclouds.http.HttpRequest;
> +import org.jclouds.http.HttpResponse;
> +import org.jclouds.openstack.nova.v2_0.NovaApi;
> +import org.jclouds.openstack.nova.v2_0.domain.regionscoped.Hypervisor;
> +import org.jclouds.openstack.nova.v2_0.domain.regionscoped.HypervisorDetails;
> +import or
Closed #819.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/819#event-361613812
Reopened #819.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/819#event-361613854
> +import org.jclouds.http.HttpRequest;
> +import org.jclouds.http.HttpResponse;
> +import org.jclouds.openstack.nova.v2_0.NovaApi;
> +import org.jclouds.openstack.nova.v2_0.domain.regionscoped.Hypervisor;
> +import org.jclouds.openstack.nova.v2_0.domain.regionscoped.HypervisorDetails;
> +import or
> +package org.jclouds.openstack.nova.v2_0.domain.regionscoped;
> +
> +import com.google.auto.value.AutoValue;
> +import org.jclouds.json.SerializedNames;
> +
> +/**
> + * Hypervisor which shows id, name and other details
> + */
> +@AutoValue
> +public abstract class HypervisorDetails {
> +
> + p
In NovaHttpApiModule,
no idea why we cant use ExtensionNamespaces.HYPERVISORS instead of specifying
the URI again ...but since all the other binding do the same, i am following
the same pattern FYI
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/81
Closed #819.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/819#event-360561587
Reopened #819.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/819#event-360561615
> @@ -96,6 +94,8 @@ private void bindDefaultAliases() {
>
> URI.create("http://docs.openstack.org/compute/ext/os-volume-attachment-update/api/v2";));
>
> aliases.addBinding(URI.create(ExtensionNamespaces.ATTACH_INTERFACES)).toInstance(
>
> URI.create("http://docs
add os-hypervisors extension for openstack-nova
fixes https://issues.apache.org/jira/browse/JCLOUDS-851
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/819
-- Commit Summary --
* add os-hypervisors extension
-- File Changes --
M a
Thanks for the review. @zack-shoylev Added few more negetive test cases and
comments.
Leaving the host service as is for now. If there are other domain classes which
need to use host service domain class, we can move it out.
---
Reply to this email directly or view it on GitHub:
https://github.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +package org.jclouds.openstack.nova.v2_0.domain.regionscoped;
> +
> +import com.google.common.base.Objects;
> +import com.google.common.collect.ImmutableMap;
> +import com.google.
Split availability Zone API to return Basic Info and Detailed info.
My previous checkin did not show detail for availability zone which is a
different path than just plain availability zone info(name and state)
Introduced AvailabilityZone class which just shows name and state
Introduced Availabil
Adding the wire logs
16:37:00.948 [http-bio-443-exec-2] DEBUG o.j.rest.internal.InvokeHttpMethod -
>> invoking extension:list
16:37:00.948 [http-bio-443-exec-2] DEBUG
o.j.h.i.JavaUrlHttpCommandExecutorService - Sending request 183650828: GET
http://X.X.X.X:8774/v2/76f28b5c3fd64ae8a3e95034b5c296e
@zack-shoylev Thanks for the tip. It looks like its fixed now. I see only one
commit in PR page.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/806#issuecomment-121368999
@zack-shoylev did i get the rebase to single commit right this time? Or else i
can create a new pull request with just the single commit.
Also, the bugs which i fixed are tracked as part of JIRA. Do i need to do
anything to update their status?
---
Reply to this email directly or view it on Git
everything under the zone scoped package is being deprecated. If you look at
the original bug request, it has the bullet point below
Move AvailabilityZone and ZoneState from the deprecated
org.jclouds.openstack.nova.v2_0.domain.zonescoped package to the correct
org.jclouds.openstack.nova.v2_0.d
@zack-shoylev I added the the tests for deprecated code as well.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/806#issuecomment-121021892
i am creating tests named DeprecatedAvailabilityZoneApiExpectTest and
DeprecatedAvailabilityZonesApiLiveTest to test the deprecated code.
If you guys have a better naming pattern, i can use that.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/806#i
Adding missing "hosts" field to OpenStack Nova AvailabilityZone.
Fixes bug https://issues.apache.org/jira/browse/JCLOUDS-700
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/806
-- Commit Summary --
* Adding missing "hosts" field to Op
Thanks Zack!!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/197#issuecomment-120170366
created a new pull request with just the one commit. @zack-shoylev
https://github.com/jclouds/jclouds-labs-openstack/pull/197
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/195#issuecomment-120108907
Fixes issue where glance fails to parse image details with milli seconds in the
date
The issue is described in this bug.
https://issues.apache.org/jira/browse/JCLOUDS-333
Caused by: java.text.ParseException: Unparseable date:
"2015-06-19T15:06:58.000+"
at java.text.DateFormat.parse(Unknown
Closed #195.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/195#event-352189889
I am not sure if the rebase workedif not i can just create another clean
pull request without the many commits. please let me know @zack-shoylev
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/195#issuecomment-119778676
anything i need to do before this change can be merged @zack-shoylev ?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/195#issuecomment-119742617
Thanks Zack and nac. Sorry for the formatting issues, this is my first commit
so please bear with me :)
The merge commit is not needed. Trying to learn working with github.
Please see my latest review. Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jcl
Fixes issue where glance fails to parse image details with milli seconds in the
date.
The issue is described in this bug.
https://issues.apache.org/jira/browse/JCLOUDS-333
Caused by: java.text.ParseException: Unparseable date:
"2015-06-19T15:06:58.000+"
at java.text.DateFormat.parse(Unknown
Closed #194.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/194#event-337265177
Fixes issue where glance fails to parse image details with milli seconds in the
date.
The issue is described in this bug.
https://issues.apache.org/jira/browse/JCLOUDS-333
Caused by: java.text.ParseException: Unparseable date:
"2015-06-19T15:06:58.000+"
at java.text.DateForm
58 matches
Mail list logo
