[jclouds/jclouds] [JCLOUDS-1200] Mark nonserializable fields in HttpResponseException and subtypes as transient (#1211)

2018-05-18 Thread Jesse Glick
[JCLOUDS-1200](https://issues.apache.org/jira/browse/JCLOUDS-1200) Also marking the corresponding getters as nullable, since they would normally not be null, but could be if the exception were serialized and deserialized. I looked into making the fields actually _be_ serializable, but at least

Re: [jclouds/jclouds] [JCLOUDS-1200] Mark nonserializable fields in HttpResponseException and subtypes as transient (#1211)

2018-05-20 Thread Andrew Gaul
This seems reasonable but I wonder what motivates this change and how we can ensure that all of our exceptions honor the `Serializable` contract? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jcl

Re: [jclouds/jclouds] [JCLOUDS-1200] Mark nonserializable fields in HttpResponseException and subtypes as transient (#1211)

2018-05-21 Thread Jesse Glick
> what motivates this change [JENKINS-51390](https://issues.jenkins-ci.org/browse/JENKINS-51390): Jenkins Pipelines which had caught an S3-related exception, or were in the process of propagating it up the call stack, caused lower-level errors when attempting to save the program state, since it

Re: [jclouds/jclouds] [JCLOUDS-1200] Mark nonserializable fields in HttpResponseException and subtypes as transient (#1211)

2018-05-21 Thread Andrew Gaul
Pushed to master as 65a5ec8164f5a75f63b1d853a742f358e0ae040b and 2.1.x as d47c776cf308e638c5ceff316852f29ceca89add. Thank you for your contribution @jglick! I investigated configuring FindBugs and SpotBugs to find this error but could not figure it out. Please let me know if you can figure ou

Re: [jclouds/jclouds] [JCLOUDS-1200] Mark nonserializable fields in HttpResponseException and subtypes as transient (#1211)

2018-05-21 Thread Andrew Gaul
Closed #1211. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1211#event-1638420449

Re: [jclouds/jclouds] [JCLOUDS-1200] Mark nonserializable fields in HttpResponseException and subtypes as transient (#1211)

2018-05-22 Thread Jesse Glick
> I investigated configuring FindBugs and SpotBugs to find this error but could > not figure it out. I see some FindBugs annotations in the project, but no FindBugs mojo being run. Something you would run manually? The detector in question would be [`SE_BAD_FIELD`](http://findbugs.sourceforge.

Re: [jclouds/jclouds] [JCLOUDS-1200] Mark nonserializable fields in HttpResponseException and subtypes as transient (#1211)

2018-05-22 Thread Andrew Gaul
I periodically run SpotBugs via `mvn spotbugs:check` but we configure it in `project/pom.xml`. I do not believe that the default configuration includes the `SE_BAD_FIELD` check but I could not figure out how to enable it. https://github.com/spotbugs/spotbugs/issues/385#issuecomment-352146321 s