Re: [jclouds/jclouds] [JCLOUDS-1374]This is the first commit of Softlayer LoadBalancer API (#1176)

2020-07-25 Thread Andrew Gaul
Closed #1176. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1176#event-3586273540

Re: [jclouds/jclouds] [JCLOUDS-1374]This is the first commit of Softlayer LoadBalancer API (#1176)

2020-07-25 Thread Andrew Gaul
Please reopen against apache/jclouds if this is still relevant. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1176#issuecomment-663855736

Re: [jclouds/jclouds] [JCLOUDS-1374]This is the first commit of Softlayer LoadBalancer API (#1176)

2018-08-22 Thread Andrea Turli
hi @swaqos any update on that? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1176#issuecomment-415091546

Re: [jclouds/jclouds] [JCLOUDS-1374]This is the first commit of Softlayer LoadBalancer API (#1176)

2018-01-31 Thread swaqos
I think creating a new virtualGuest is not a problem, but the problem is more with the network/subnets. I believe with the new CDN accounts, virtualGuest creations require subnetId as well, while I believe subnets need to live on private networks, and there are limit number of private networks(5

Re: [jclouds/jclouds] [JCLOUDS-1374]This is the first commit of Softlayer LoadBalancer API (#1176)

2018-01-30 Thread Ignasi Barrera
Time is not an issue. Live tests are assumed to take their time. What about my comment on creating the machine using the compute service? Could it be then created using the compute service defaults, and extract the subnet and address from the created instance? -- You are receiving this because

Re: [jclouds/jclouds] [JCLOUDS-1374]This is the first commit of Softlayer LoadBalancer API (#1176)

2018-01-30 Thread swaqos
I totally understand that out of the box live tests would be nice and I would hope that too, but that would require other information for the new subnet (networkIdentifier, cider) and new machine, not to mention the extra time needed for this (it's now taking approximately 20 mins). I wonder if

Re: [jclouds/jclouds] [JCLOUDS-1374]This is the first commit of Softlayer LoadBalancer API (#1176)

2018-01-30 Thread swaqos
Reopened #1176. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1176#event-1449815624

Re: [jclouds/jclouds] [JCLOUDS-1374]This is the first commit of Softlayer LoadBalancer API (#1176)

2018-01-30 Thread Ignasi Barrera
Thanks for the explanation. Would it make sense to do like we do in the [Azure ARM load balancer live test](https://github.com/jclouds/jclouds/blob/master/providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/LoadBalancerApiLiveTest.java#L250) and use the ComputeService

Re: [jclouds/jclouds] [JCLOUDS-1374]This is the first commit of Softlayer LoadBalancer API (#1176)

2018-01-30 Thread swaqos
Closed #1176. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1176#event-1448958454

Re: [jclouds/jclouds] [JCLOUDS-1374]This is the first commit of Softlayer LoadBalancer API (#1176)

2018-01-30 Thread swaqos
subnetId: This is the subnet id of which the load balancer instance will connect to, and which the back-end compute servers can reach. Description from load balancer doc "This subnet must have network connectivity with backend servers hosting your application. This means that the backend servers

Re: [jclouds/jclouds] [JCLOUDS-1374]This is the first commit of Softlayer LoadBalancer API (#1176)

2018-01-30 Thread Ignasi Barrera
Thanks @swaqos! >The users are expected to set variables subnetId, servicePrices, and >testInstancePrivateIp for LoadBalancerApiLiveTest. What are those properties needed for? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

Re: [jclouds/jclouds] [JCLOUDS-1374]This is the first commit of Softlayer LoadBalancer API (#1176)

2018-01-29 Thread swaqos
swaqos commented on this pull request. > + @BeforeClass(groups = {"integration", "live"}) + @Override + public void setup() { + super.setup(); + + loadBalancerApi = api.getLoadBalancerApi(); + + datacenter = Iterables.get(api.getDatacenterApi().listDatacenters(), 0); +

Re: [jclouds/jclouds] [JCLOUDS-1374]This is the first commit of Softlayer LoadBalancer API (#1176)

2018-01-29 Thread swaqos
swaqos commented on this pull request. > + LoadBalancerMember getLoadBalancerMember(@PathParam("id") int id); + + /** +* Add load balancer members +* @param LoadBalancerMembersToBeAdded the load balancer member creation definition of LoadBalancerMember.AddLoadBalancerMember +*

Re: [jclouds/jclouds] [JCLOUDS-1374]This is the first commit of Softlayer LoadBalancer API (#1176)

2018-01-28 Thread Andrea Turli
andreaturli requested changes on this pull request. > + @BeforeClass(groups = {"integration", "live"}) + @Override + public void setup() { + super.setup(); + + loadBalancerApi = api.getLoadBalancerApi(); + + datacenter = Iterables.get(api.getDatacenterApi().listDatacenters()

Re: [jclouds/jclouds] [JCLOUDS-1374]This is the first commit of Softlayer LoadBalancer API (#1176)

2018-01-27 Thread Andrea Turli
thx @swaqos it looks like a great PR: jira issue, good tests (with live tests results) and use of jclouds best practices! Thanks, Ill review it properly asap -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com

[jclouds/jclouds] [JCLOUDS-1374]This is the first commit of Softlayer LoadBalancer API (#1176)

2018-01-26 Thread swaqos
Jira link: https://issues.apache.org/jira/browse/JCLOUDS-1374 The update focuses on adding SoftLayer LoadBalancer API to the features list of SoftLayer provider. Domain type files: - Added LoadBalancer.java - Added LoadBalancerHealthMonitor.java - Added LoadBalancerListener.java - Added LoadBalan