Please reopen against apache/jclouds if this is still relevant.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1236#issuecomment-663855817
Hi @gaul , I gave up this contribution for this time... So I suppose we could
close this PR for this time. :disappointed:
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@nacx @tormath1 does this pull request need anything to move forward?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1236#issuecomment-458260849
tormath1 commented on this pull request.
> checkArgument(!iterator.hasNext(),
"Error: Please specify only one network/subnetwork in
TemplateOptions when using GCE.");
}
String region = ZONE == location.getScope() ?
location.getParent().getId() :
nacx commented on this pull request.
> checkArgument(!iterator.hasNext(),
"Error: Please specify only one network/subnetwork in
TemplateOptions when using GCE.");
}
String region = ZONE == location.getScope() ?
location.getParent().getId() :
@tormath1 pushed 4 commits.
211beb8 perf(node/creation): remove if statement
a0c4bf1 style(context): fix missing indentation
6169621 style(resources): fix spaces in comment
59ebfc1 style(fw/loader): fix indentation from 4 to 3
--
You are receiving this because you are subscribed to this
tormath1 commented on this pull request.
> checkArgument(!iterator.hasNext(),
"Error: Please specify only one network/subnetwork in
TemplateOptions when using GCE.");
}
String region = ZONE == location.getScope() ?
location.getParent().getId() :
nacx commented on this pull request.
Thanks @tormath1!
> @@ -220,6 +225,14 @@ protected void configure() {
return CacheBuilder.newBuilder().build(in);
}
+
+@Provides
+@Singleton
+protected LoadingCache> firewallsMap(
+CacheLoader> in) {
+return
@tormath1 pushed 1 commit.
51801fc style(node/creation): use inline if
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1236/files/b9310ab7f9e73709cbdf181163d5dd3c20dec52d..51801fc0fdfd67a2efda5ee359b104c5ba9fced2
This is the [jira](https://issues.apache.org/jira/browse/JCLOUDS-1415). I've
wrote one test for the firewall loader, but I think it's not enough.
And I've tried to make a Minimum Viable Change in order to don't have a lot of
new files and things to review.
Thanks for your review !
You can
10 matches
Mail list logo
