Re: [jclouds/jclouds] Added Local Network Gateway API (#1216)

2018-06-12 Thread Ignasi Barrera
nacx commented on this pull request. > + // Make sure the resource is fully provisioned before deleting it + waitUntilAvailable(name); + URI uri = api().delete(name); + assertResourceDeleted(uri); + } + + private LocalNetworkGatewayApi api() { + return

Re: [jclouds/jclouds] Added Local Network Gateway API (#1216)

2018-06-12 Thread Andrea Turli
andreaturli approved this pull request. lgtm, some minor changes > @@ -138,7 +138,7 @@ public void deleteAvailabilitySet() throws > InterruptedException { assertSent(server, "DELETE", path); } - public void deleteSubnetResourceDoesNotExist() throws InterruptedException { +

Re: [jclouds/jclouds] Added Local Network Gateway API (#1216)

2018-06-11 Thread Ignasi Barrera
Live test result: ```bash --- T E S T S --- Running org.jclouds.azurecompute.arm.features.LocalNetworkGatewayApiLiveTest Configuring TestNG with: TestNG652Configurator Starting test

[jclouds/jclouds] Added Local Network Gateway API (#1216)

2018-06-11 Thread Ignasi Barrera
This PR adds the Local Gateway Network API and is the first of a set of PRs that will add support for configuring VPNs in Azure ARM: https://docs.microsoft.com/en-us/rest/api/network-gateway/ You can view, comment on, or merge this pull request online at: