Re: [jclouds/jclouds] Define the JDK version in a Maven property (#1152)

2017-11-30 Thread Ignasi Barrera
nacx commented on this pull request. > - -maven-toolchains-plugin -1.1 - - - - toolchain - - - - - - -

Re: [jclouds/jclouds] Define the JDK version in a Maven property (#1152)

2017-11-30 Thread Andrew Phillips
demobox commented on this pull request. > - -maven-toolchains-plugin -1.1 - - - - toolchain - - - - - - -

Re: [jclouds/jclouds] Define the JDK version in a Maven property (#1152)

2017-11-30 Thread Ignasi Barrera
Closed #1152. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1152#event-1365282883

Re: [jclouds/jclouds] Define the JDK version in a Maven property (#1152)

2017-10-25 Thread Andrew Gaul
gaul approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1152#pullrequestreview-71885965

Re: [jclouds/jclouds] Define the JDK version in a Maven property (#1152)

2017-10-25 Thread Ignasi Barrera
If this works, the profile must also be defined in `jclouds-karaf` and `jclouds-cli`. I forgot those projects when merging the first PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[jclouds/jclouds] Define the JDK version in a Maven property (#1152)

2017-10-25 Thread Ignasi Barrera
This changes how we reference the toolchain to use a Maven property. This will allow us to be more flexible and generic when configuring builds in Jenkins and we can avoid having a dedicated maven profile for each JDK version we want to support. A property can be overridden in the command-line,