I've squashed and pushed your changes to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/92044e3d) and
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/3ae2213a), and
also added a commit in both branches to address my last comments. Thanks
@felfert!
--
You are rece
Closed #1042.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1042#event-885497755
nacx commented on this pull request.
>I intentionally left the old "wrong" variant via the userMetaData map in place
>in order to not break existing code.
Good! In that case, what about overriding the `userMetadata` methods in the
DigitalOceanTemplateOptions too, and mark them `@Deprecated` poi
> Right. I think the use of user metadata here is wrong. It is meant for
> providers like OpenStack that support key value pairs in the metadata, but
> not for this. Mind changing it and add the userData field to the
> DigitalOceanTemplateOptions, and also this comment to properly indicate user
@felfert pushed 1 commit.
ec39127 Added byte[] userData according to code review
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1042/files/730cecd174f6a769518ebf2d12125f78bc95068b..ec39127a001bea32d30e097877db4fef
FTR, I've opened
[JCLOUDS-1211](https://issues.apache.org/jira/browse/JCLOUDS-1211) to track the
tags support.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1042#issuecomment-263233
>The others (meaning: at least openstack-nova and aws-ec2) have a completely
>different API in jclouds: They implement a separate method in their
>TemplateOptions specializations: userData(byte[] userData). So: why is it that
>the digitaloceans2 provider follows a different approach here? Result
@felfert pushed 1 commit.
730cecd Simplified code according to code review
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1042/files/487f5e8be846745fd3ad182b3fe592f381643d1e..730cecd174f6a769518ebf2d12125f78bc9506
Later: Just realized, that the tags are a Set and associated with a
node so: Of course that makes sense :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1042#issuecomment-263073020
@nacx I looked into the tag api documentation and I think, it does **not** fit
the jclouds semantic. In jclouds, those are `Map`, but in
DigitalOcean they have Map where Object is currently always a
droplet. (Most likely, it's an Integer-Id, just like with their key API).
I'm going to change ma
nacx commented on this pull request.
Thanks for the fix @felfert!
Since we don't support yet tags (we should implement the [tag
api](https://developers.digitalocean.com/documentation/v2/#tags) and open a
JIRA to track this), I think there is no need to keep using the
`metadataAndTagsAsCommaDel
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1042
-- Commit Summary --
* Fixes JCLOUDS-1206
-- File Changes --
M
providers/digitalocean2/src/main/java/org/jclouds/digitalocean2/compute/DigitalOcean2ComputeServiceAdapter.java
12 matches
Mail list logo
