Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

Pushed to master as 14621c08d70c3f128d7d1a81149fc88f43c61c95 and 29655f3149f151a834ed5a724e91e32994b28d89 and 2.1.x as 4288c9eb7f3d920eb24af8da006b8c32f1cff703 and d464e8a3704a780f7bec4873bce905413f987faa. Sorry for the delay; I misunderstood the Travis failures and missed the added tests.

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

Closed #1084. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1084#event-1638433977

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

I'm able to successfully run the tests locally. I'm not sure what the Travis failure was at the time, but I believe we should be able to rebase and merge this PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

Checked out the container listings. We don't have the same issue, as we don't attempt to build URIs from them. We should merge this PR to fix this issue in Swift. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

@gaul I'd like to resurrect this PR and apologies for the delay. I think this is the right thing to do for Swift, as listings will return non-ASCII UTF-8 characters not URL encoded, but escaped as "\u". I'm curious if the same issue exists when listing the containers -- I'll look into that

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

@stevegomez17 Please stop adding irrelevant comments to jclouds pull requests. I have been deleting these. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1084#issuecomment-332682134

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

say thank you so much on have never really expressed that to you very well but you dont realize how much you have helped me out !! Sent from my iPhone On Sep 27, 2017, at 4:21 PM, Timur Alperovich wrote: @andrewgaul I will try to looking into it this weekend and

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

@timuralp Do you have any insight into this issue? Otherwise we can close this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1084#issuecomment-331726071

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

@andrewgaul I don't have any updates, no - I'm not in a position to come back and look at this at the moment unfortunately. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

@matmannion Any updates on this pull request? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1084#issuecomment-326688942

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

@andrewgaul I haven't had chance to go back and look at this, but I was testing against a DevStack instance with the following: mvn integration-test -pl :openstack-swift -Plive -Dtest.openstack-swift.endpoint="http://137.205.194.8:5000/identity/v2.0;

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

@andrewgaul I've added an integration test against live. I looked through the commits from JCLOUDS-217 and there doesn't seem to be anything that jumps out as an obvious better solution; I note that @timuralp himself made [an identical change to

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

@matmannion pushed 1 commit. 23e8889 JCLOUDS-1263: Add live integration test for manipulating objects through the Swift ObjectApi with unicode characters in their path -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

@matmannion Can you look at some of the earlier URL encoding commits to see if there is a better solution? @timuralp fixed a lot of these issues in [JCLOUDS-217](https://issues.apache.org/jira/browse/JCLOUDS-217). -- You are receiving this because you are subscribed to this thread. Reply to

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

@matmannion Can you add a test to `ContainerApiLiveTest`? If you haven't run the integration tests before, you can do so via: ``` mvn integration-test -pl :openstack-swift -Plive -Dtest.rackspace-cloudfiles-us.identity="${JCLOUDS_IDENTITY}"

Re: [jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

Looks good -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1084#issuecomment-291242800

[jclouds/jclouds] JCLOUDS-1263: URL encode object names from list object response before creating URIs with them (#1084)

changes to jclouds-core and this seemed to be the easiest drop-in fix for the underlying issue. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1084 -- Commit Summary -- * JCLOUDS-1263: URL encode object names from list object response