Thanks for taking this on, @gaul and @nacx! Java 8 here we finally come... ;-)
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1193#issuecomment-380293707
Done. I've updated the matrix build to force the compile source and target and
added Guava 21.0. If I've not messed it up, the Guava 21 build should be
skipped for Java 1.7.
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
> I haven't spend time looking at the modernizer violations but I guess we'll
> have to address them once we officially support Java 8 as our default version
> and we change the defaults for the compile source/target.
Agree that we have more work to do here and this is the first step. Could
FYI using the same @nacx's mvn command I get
```
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 10:00 min
[INFO] Finished at:
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1193#pullrequestreview-110713030
>You need to set maven.compile.source and maven.compile.target to 1.8 to
>compile with Guava 21.
Right. I forgot :) Now build works with: `mvn clean install
-Dguaca.version=21.0 -Dmaven.compile.source=1.8 -Dmaven.compile.target=1.8
-Danimal.sniffer.skip -Dmodernizer.skip`
I haven't spend time
> Thanks for taking a look at this, @gaul! Build is failing for me:
You need to set `maven.compile.source` and `maven.compile.target` to 1.8 to
compile with Guava 21.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Thanks for taking a look at this, @gaul! Build is failing for me:
```bash
$ mvn -version
Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1;
2014-12-14T18:29:23+01:00)
Maven home: /opt/maven
Java version: 1.8.0_162, vendor: Oracle Corporation
Java home: /usr/java/jdk1.8.0_162/jre
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1193
-- Commit Summary --
* JCLOUDS-1333: Fix Java 8 and Guava 21 issues
-- File Changes --
M
apis/cloudstack/src/main/java/org/jclouds/cloudstack/compute/predicates
