demobox commented on this pull request.
> @@ -148,8 +149,13 @@ public boolean blobExists(final String containerName,
> final String blobName) {
}
@Override
- public Iterable getBlobKeysInsideContainer(final String
containerName) {
- return
gaul commented on this pull request.
> } else if (child.isDirectory()) {
-blobNames.add(function.apply(child.getAbsolutePath()) +
File.separator); // TODO: undo if failures
-populateBlobKeysInContainer(child, blobNames, function);
+// Consider a
timuralp approved this pull request.
Looks good to me!
> } else if (child.isDirectory()) {
-blobNames.add(function.apply(child.getAbsolutePath()) +
File.separator); // TODO: undo if failures
-populateBlobKeysInContainer(child, blobNames, function);
+
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1268#pullrequestreview-197508785
@timuralp could you review this?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1268#issuecomment-457725188
gaul commented on this pull request.
> @@ -148,8 +149,13 @@ public boolean blobExists(final String containerName,
> final String blobName) {
}
@Override
- public Iterable getBlobKeysInsideContainer(final String
containerName) {
- return
Previously getBlobKeysInsideContainer returned all keys and filtered
in LocalBlobStore. Now getBlobKeysInsideContainer filters via prefix
which can dramatically decrease the number of keys returned,
especially for the filesystem provider. Further optimizations are
possible for delimiter.
You can
