Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/219e2958) and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/e4c99a07)!
Thanks @trentontrees for the contribution!!
--
You are receiving this because you are subscribed to this thread.
Reply to this email d
Closed #1245.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1245#event-1924344216
Thanks for the effort! Basically, because we don't push code to GitHub but to
the Apache Git repository. This is just a mirror of that one and whatever is
pushed just here gets removed when the Apache Git repo is mirrored.
Now that you have gotten into the wonderful world of rebasing :) would yo
Took a few tries, but successfully squashed the PR. Should be good to go :)
Out of curiosity, why have the original repository squash the commits? Why not
use github's squash and merge option to flatten the commits? I only ask as I
made a squash mistake and was lucky enough to have had a few
@trentontrees pushed 6 commits.
f7b83f4 Mark sourceImage as Nullable
8b17dfe Make NovaErrorHandler logging of sensitive information configurable
767240f JCLOUDS-1462: Upgrade Apache Http driver to 4.3.6
9dd50b3 JCLOUDS-1463: Do not return MachineTypes from zones that are not
available for dep
danielestevez approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1245#pullrequestreview-167903755
That link looks useful, thanks!
Please squash the commits and we're done
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1245#issuecomment-432469002
I did a double check and after some searching I found a helpful link:
https://www.ec2instances.info/
I updated `t2`/`t3` to match that document. I noticed that some of the other
instance types do not match that doc, but for now I'm leaving them out of this
PR.
--
You are receiving this becau
@trentontrees pushed 1 commit.
79a7ea3 fix: Update processor speeds for t2/t3 types
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1245/files/f8c630c68b17c4b5f9a870b98634e40d04d7f69a..79a7ea383a28e2b37974dabf8c48c
Thanks @trentontrees CPU seem correct now but i'm looking at
```Processsors.speed`` and it don't see the right values.
In AWS doc these new instances have ```up to 3.3``` for t2 and 2.5 for t3
instead of 0.4. Could you check these values too?
Once done, just rebase it and it'll be merged!
--
@danielestevez This PR should be set for review (again)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1245#issuecomment-432040525
@trentontrees pushed 1 commit.
f8c630c fix: Update core count to match documented values
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1245/files/865e69181ba5a4104e828c5c09d5ec5040021465..f8c630c68b17c4b5f9a870b9
danielestevez commented on this pull request.
> @@ -429,6 +444,89 @@ public static EC2HardwareBuilder t2_large() {
.processors(ImmutableList.of(new Processor(1.0,
0.4))).rootDeviceType(RootDeviceType.EBS);
}
+ /**
+* @see InstanceType#T2_XLARGE
+*/
+ public static
trentontrees commented on this pull request.
> @@ -429,6 +444,89 @@ public static EC2HardwareBuilder t2_large() {
.processors(ImmutableList.of(new Processor(1.0,
0.4))).rootDeviceType(RootDeviceType.EBS);
}
+ /**
+* @see InstanceType#T2_XLARGE
+*/
+ public static
trentontrees commented on this pull request.
> @@ -429,6 +444,89 @@ public static EC2HardwareBuilder t2_large() {
.processors(ImmutableList.of(new Processor(1.0,
0.4))).rootDeviceType(RootDeviceType.EBS);
}
+ /**
+* @see InstanceType#T2_XLARGE
+*/
+ public static
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1245#issuecomment-430785426
danielestevez commented on this pull request.
> @@ -429,6 +444,89 @@ public static EC2HardwareBuilder t2_large() {
.processors(ImmutableList.of(new Processor(1.0,
0.4))).rootDeviceType(RootDeviceType.EBS);
}
+ /**
+* @see InstanceType#T2_XLARGE
+*/
+ public static
danielestevez commented on this pull request.
> + /**
+* @see InstanceType#T3_MEDIUM
+*/
+ public static EC2HardwareBuilder t3_medium() {
+ return new EC2HardwareBuilder(InstanceType.T3_MEDIUM).t3()
+ .ram(4096)
+ .processors(ImmutableList.of(new Proces
PR #1244 also does this feature. Slightly different approach to the problem.
[Jira 1460](https://issues.apache.org/jira/browse/JCLOUDS-1460)
Added support for:
t2.nano
t2.xlarge
t2.2xlarge
t3.nano
t3.micro
t3.small
t3.medium
t3.large
t3.xlarge
t3.2xlarge
m4.16xlarge
AWS Instance Type reference p
Looking at the build failure, I'm not understanding how my PR affected the Nova
API. Mine changes should be local to AWS only.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1245#iss
20 matches
Mail list logo
