Re: [jclouds/jclouds] Mark srouceImage as Nullable to avoid NullPointerException while attaching local-ssd disk in GCE (#1242)

2018-10-18 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/f7b83f45) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/71dbce55). Thanks @maismail! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [jclouds/jclouds] Mark srouceImage as Nullable to avoid NullPointerException while attaching local-ssd disk in GCE (#1242)

2018-10-18 Thread Ignasi Barrera
Closed #1242. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1242#event-1911717382

Re: [jclouds/jclouds] Mark srouceImage as Nullable to avoid NullPointerException while attaching local-ssd disk in GCE (#1242)

2018-10-16 Thread Ignasi Barrera
It's just a null check in a domain model that was not hit in a path reachable from the portable abstraction... I'm fine with the path as-is. @demobox? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Mark srouceImage as Nullable to avoid NullPointerException while attaching local-ssd disk in GCE (#1242)

2018-10-16 Thread Andrew Gaul
@maismail Could you fix the srouceImage typo in the commit message? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1242#issuecomment-430213378

Re: [jclouds/jclouds] Mark srouceImage as Nullable to avoid NullPointerException while attaching local-ssd disk in GCE (#1242)

2018-10-16 Thread Andrew Phillips
@nacx Should we consider adding any kinds of test(s) for this? Also, would a JIRA issue for tracking make sense here? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[jclouds/jclouds] Mark srouceImage as Nullable to avoid NullPointerException while attaching local-ssd disk in GCE (#1242)

2018-10-16 Thread Mahmoud Ismail
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1242 -- Commit Summary -- * Mark srouceImage as Nullable -- File Changes -- M providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/AttachDisk.java