Re: [jclouds/jclouds] OAuth filter customization per request (#1160)

2017-11-30 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/624367df) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/3bdc25c3). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.

Re: [jclouds/jclouds] OAuth filter customization per request (#1160)

2017-11-30 Thread Ignasi Barrera
Closed #1160. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1160#event-1365286718

Re: [jclouds/jclouds] OAuth filter customization per request (#1160)

2017-11-28 Thread Jim Spring
LGTM. Some test failures I was seeing, wholly unrelated and will retest those and open issues accordingly. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1160#issuecomment-347739730

Re: [jclouds/jclouds] OAuth filter customization per request (#1160)

2017-11-28 Thread Jim Spring
I’ll update my code this morning if there are any changes and can run the ARM tests and get back in a bit. Sent from my iThingy > On Nov 28, 2017, at 06:06, Andrea Turli wrote: > > from slack conversation, I understand @nacx already tested this with GCE, so > lgtm! > > — > You are receiving

Re: [jclouds/jclouds] OAuth filter customization per request (#1160)

2017-11-28 Thread Andrea Turli
from slack conversation, I understand @nacx already tested this with GCE, so lgtm! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1160#issuecomment-347533273

Re: [jclouds/jclouds] OAuth filter customization per request (#1160)

2017-11-28 Thread Andrea Turli
thanks @nacx ! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1160#issuecomment-347533302

Re: [jclouds/jclouds] OAuth filter customization per request (#1160)

2017-11-28 Thread Andrea Turli
I'd like to test this with arm and gce as well. I'll report on this thread asap -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1160#issuecomment-347476809

[jclouds/jclouds] OAuth filter customization per request (#1160)

2017-11-28 Thread Ignasi Barrera
This pull request enables a per-request customization of the OAuth properties, such as the audience and resource. This is useful for providers that have APIs that authorize different resources, such as Azure ARM and the KeyVault API. The changes in this PR are backward-compatible and by default