Merged at
[master](https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=9b3e6d91bff99b39699a333eec798d1f2cd5cded)
and
[1.9.x](https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=9b3e6d91bff99b39699a333eec798d1f2cd5cded)
--
You are receiving this because you are
Closed #1027.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1027#event-841967206
ok cool. I think I will volunteer for a new 1.9.x release :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1027#issuecomment-256953771
Absolutely. There are no plans to release 1.9.x, and it's been a while since we
stopped backporting fixes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1027#issuecomment-256953114
merged at
[1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/7167b473)
@nacx @zack-shoylev shall we port that to `master` as well?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
nacx approved this pull request.
lgtm!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1027#pullrequestreview-6243053
@nacx I have had some issues reproducing 1176. But I think this is alright to
merge even if it does not fix it right away (but I strongly suspect it will).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@zack-shoylev Could you give a try to this PR and check if this fixes
JCLOUDS-1176?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1027#issuecomment-256586741
Good change! Thanks, @andreaturli
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1027#issuecomment-256479800
test408ShouldRetry for 2.0 should also be updated, it seems?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1027#issuecomment-256479071
This might affect https://issues.apache.org/jira/browse/JCLOUDS-1176
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1027#issuecomment-256475005
> Can you expand on the problem this solves?
Upon failed requests (response code > 3xx), the
[BaseHttpCommandExecutorService](https://github.com/jclouds/jclouds/blob/master/core/src/main/java/org/jclouds/http/internal/BaseHttpCommandExecutorService.java#L134-L146)
decides if the request should
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1027#issuecomment-256448373
@andrewgaul retriers in general shouldn't close the streams if they are not
reading the payload, as
https://github.com/jclouds/jclouds/blob/master/core/src/main/java/org/jclouds/http/internal/BaseHttpCommandExecutorService.java#L144
will close it anyway.
--
You are receiving this because you
Easier to review when ignoring whitespace:
https://github.com/jclouds/jclouds/pull/1027/files?w=1
@andreaturli Can you expand on the problem this solves?
@zack-shoylev Can you review this since you wrote `RetryOnRenew`?
--
You are receiving this because you are subscribed to this thread.
Reply
BTWE, there are a couple more `RetryOnRenew` classes that do the same thing.
Mind removing the finally block from all them too?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I think you are right!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1027#issuecomment-256376606
nacx commented on this pull request.
> @@ -116,7 +115,11 @@ public boolean shouldRetryRequest(HttpCommand command,
> HttpResponse response) {
return retry;
} finally {
- releasePayload(response);
+ // If the request is failed and is not going to be retried,
/cc @nacx
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1027
-- Commit Summary --
* fix jclouds/apis/swift retryOnRenew
-- File Changes --
M
common/openstack/src/main/java/org/jclouds/openstack/handlers/RetryOnRenew.java
(7)
19 matches
Mail list logo
