Re: [jclouds/jclouds] rename oauth properties (#1014)

2016-09-26 Thread Andrea Turli
thx @nacx for the explanation! I'll close the pr as not needed -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1014#issuecomment-249579672

Re: [jclouds/jclouds] rename oauth properties (#1014)

2016-09-26 Thread Andrea Turli
Closed #1014. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1014#event-802329941

Re: [jclouds/jclouds] rename oauth properties (#1014)

2016-09-26 Thread Ignasi Barrera
Well, I'd say the wrong properties are the ones you point in this last comment, as they double-prefix the property. When jclouds creates the context, it tries to resolve the properties that are prefixed with the "provider id", and if not, it tries to resolve them with the "jclouds" prefix. You c

Re: [jclouds/jclouds] rename oauth properties (#1014)

2016-09-26 Thread Andrea Turli
because I thought it was jclouds's convention, thinking about stuff like ``` public static final String AUTO_ALLOCATE_FLOATING_IPS = "jclouds.openstack-nova.auto-create-floating-ips"; ``` so for simmetry I'd have expected that for oauth things as well, no? -- You are receiving this because you a

Re: [jclouds/jclouds] rename oauth properties (#1014)

2016-09-26 Thread Ignasi Barrera
Why do you want to pass it like that? I mean, you are providing properties of two different jclouds providers/apis: "azurecompute-arm" and "oauth". And you are passing both using the jclouds convention `.endpoint`. Why do you want to change that add a prefix to one of the properties? -- You ar

Re: [jclouds/jclouds] rename oauth properties (#1014)

2016-09-26 Thread Andrea Turli
thanks @nacx but I don't follow completely. For example, to run tests in `jclouds-labs/azurecompute-arm` I need to specify: ``` mvn clean install -Plive -Dtest.azurecompute-arm.identity="identity" -Dtest.azurecompute-arm.credential="password" -Dtest.azurecompute-arm.endpoint="https://management.

Re: [jclouds/jclouds] rename oauth properties (#1014)

2016-09-26 Thread Ignasi Barrera
:-1: jclouds alrady reads properties in the form: `.`, so you can configure properties (endpoints, for example) for multiple providers: * `aws-ec2.endpoint` * `openstack-nova.endpoint` * `openstack-nova.identity` If no provider specific property is found, jclouds fallsback to the `jclouds` pref

[jclouds/jclouds] rename oauth properties (#1014)

2016-09-26 Thread Andrea Turli
- oauth.{endpoint.identity, credential} to jclouds.oauth.{endpoint, identity, credential} @nacx what do you think? I think it is more homogenous this way You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1014 -- Commit Summary -- * ren