demobox approved this pull request.
Thanks for the explanations, Ignasi! +1 - looks good to go to me
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/91#pullrequestreview-104
nacx commented on this pull request.
> @@ -85,10 +85,7 @@ private Instance getInstance() {
private void createUser() throws TimeoutException {
System.out.format("Create User%n");
-
- boolean result = userApi.create(NAME, PASSWORD, NAME);
-
- System.out.format(" %s%n", res
nacx commented on this pull request.
> docker
-
- 2.0.0-SNAPSHOT
+ ${jclouds.version}
The code compiles and if it was working with 2.0.0-SNAPSHOT it should work with
the 2.0.0 release. I think it is a safe change to make.
--
You are receiving this because you are s
nacx commented on this pull request.
> @@ -87,10 +87,7 @@ private Instance getInstance() {
private void createDatabase() throws TimeoutException {
System.out.format("Create Database%n");
-
- boolean result = databaseApi.create(NAME);
-
- System.out.format(" %s%n", result)
nacx commented on this pull request.
> @@ -20,7 +20,7 @@
- - %msg%n
+ %msg%n
I made this change to chef and compute, since those are the ones I'm familiar
with. Each log in jclouds compute (and the compute/chef example code) is
already prefixed with `>>` or `<<`, so it
demobox commented on this pull request.
> @@ -20,7 +20,7 @@
- - %msg%n
+ %msg%n
How does this compare with the logging for other examples?
> docker
-
- 2.0.0-SNAPSHOT
+ ${jclouds.version}
Have we been able to verify that this change works as e
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-examples/pull/91
-- Commit Summary --
* Upgrade compute examples to 2.0.0
-- File Changes --
M chef-basics/pom.xml (9)
M
chef-basics/src/main/java/org/apache/jclouds/examples/chef/b
