andreaturli commented on this pull request.
> @@ -52,38 +52,56 @@ limitations under the License.
mvn:org.apache.jclouds.api/atmos/${jclouds.version}
@neykov you mean I can remove `resolver='(obr)'` for all the features?
--
You are receiving this because you are subscribed to this
@andreaturli pushed 1 commit.
3896a3f fix karaf-maven-plugin
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92/files/425dd892d3efc7f67a7d7b30e43c8b0fae519adf..3896a3fac4e477d55636ad7a4998b9897c8c2b2b
@andreaturli pushed 1 commit.
21b7fc7 bump karaf version in itests
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92/files/eaee0b4a3575f7761bd39d79b93927fdd7426334..21b7fc7e0444d914cce02907b75a2b01c7bd86ac
@andreaturli pushed 1 commit.
eaee0b4 add providers
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92/files/0303badf39d88b82292ab27b9876b9d7c4c138ee..eaee0b4a3575f7761bd39d79b93927fdd7426334
@andreaturli pushed 4 commits.
0d5f154 add drivers features
74294c9 add allcompute and allblobstore feature
a22532c add FeatureLabsInstallationTest - wip
0303bad fix FeatureLabsInstallationTest
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@andreaturli pushed 3 commits.
8477274 add feature-labs.xml file
609e664 wip
0a37d2e wip
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
neykov commented on this pull request.
> @@ -52,38 +52,56 @@ limitations under the License.
mvn:org.apache.jclouds.api/atmos/${jclouds.version}
Hmm indeed not clear at all :)
I was referring to the the [root element
andreaturli commented on this pull request.
> @@ -110,7 +110,6 @@ limitations under the License.
jclouds-compute
jclouds-api-atmos
jclouds-api-byon
-jclouds-api-cloudsigma2
I will try to add `super-features`, currently I'm
andreaturli commented on this pull request.
> @@ -52,38 +52,56 @@ limitations under the License.
mvn:org.apache.jclouds.api/atmos/${jclouds.version}
not sure I follow your suggestion, is this for line 52?
--
You are receiving this because you are subscribed to this thread.
Reply to
neykov commented on this pull request.
> @@ -110,7 +110,6 @@ limitations under the License.
jclouds-compute
jclouds-api-atmos
jclouds-api-byon
-jclouds-api-cloudsigma2
Easier to pack all the features in one or several big
neykov commented on this pull request.
> @@ -52,38 +52,56 @@ limitations under the License.
mvn:org.apache.jclouds.api/atmos/${jclouds.version}
Latest version of namespace is `http://karaf.apache.org/xmlns/features/v1.4.0`.
`resolver` attribute is no longer used so can drop it.
--
I think you are right, @nacx, we need to bump karaf version as well
modern-itests vs itests are just easier to read/write and they use the recent
capabilities offered by pax exam etc I've seen also better error messages and
less boilerplate code
When modern-itests will have all of the tests
A couple more questions from a non-karaf expert:
* You only bumped OSGi version. What would it take to bump the Karaf version
too? The one we use is quite old.
* What advantages present the modern tests? And do they run faster?
Thanks for taking care of this @andreaturli! And thanks @geomacy
>maybe it would be useful at this point to split the feature file into several
>more modular files, e.g. at least to factor out the jclouds labs features
+1 to this. Also in the context of
[JCLOUDS-1221](https://issues.apache.org/jira/browse/JCLOUDS-1221).
--
You are receiving this because
Looks good; one thought - maybe it would be useful at this point to split the
feature file into several more modular files, e.g. at least to factor out the
jclouds labs features. Was going to suggest splitting apis and providers but
you will always need both, so not much point in that.
--
neykov commented on this pull request.
Looking great, nice to see the tests updated.
> @@ -27,7 +27,7 @@ limitations under the License.
org.apache.jclouds
jclouds-karaf
pom
- 2.1.0-SNAPSHOT
+ 2.0.1-SNAPSHOT
Is this change made on purpose?
--
You are receiving this because you are
I'd like to push out this PR to have feedback from osgi/karaf experts, as I'm
not
This PR:
- re-organize `feature.xml` to alphabetical order to simplify the review process
- bump osgi and karaf version
- add a new `modern-itests` maven module inspired by
17 matches
Mail list logo
