I don't think so. The changes upgrade the version of karaf so we don't want
them in the bugfix branches. Thanks for your help on this!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/
Closed #99.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/99#event-1007011054
Merged to
[master](https://git-wip-us.apache.org/repos/asf?p=jclouds-karaf.git;a=commit;h=7006c512427d70ba3c748f4e4a13c5f7546f4dd9).
Thanks, Svet!
@neykov @andreaturli @nacx Does this or any of the related changes here or in
jclouds-cli need backporting to any other branches, by the way?
--
Y
[From
Svet](https://github.com/jclouds/jclouds-cli/pull/37#issuecomment-287800676):
"Tested successfully..."
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/99#issuecomment-2878
> though "it shouldn't matter (tm)" :).
_grin_. Thanks for running the tests again!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/99#issuecomment-287795600
Good spot @demobox. Updated.
Now testing with jclouds-cli, though "it shouldn't matter (tm)" :).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/99#issuecomment-287786218
@neykov This looks good to me as long as we're confident that adding this back
will not break the CLI in any way.
Out of curiosity: were you able to carry out your tests from
jclouds/jclouds-cli#37 with this change added?
--
You are receiving this because you are subscribed to this thread.
Rep
Er, actually: now that #98 is merged, does this need to be added to the new
`jclouds-labs-all-compute` feature?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/99#issuecomment-28
@andreaturli Either this PR or https://github.com/jclouds/jclouds-cli/pull/37
will fix the build. Thought it's useful to add anyway for backwards
compatibility, in case other projects depend on it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly
neykov commented on this pull request.
> @@ -516,32 +521,27 @@ limitations under the License.
-jclouds-compute
Goot point @demobox. I reverted the changes for the sake of consistency. Still
think it's the right thing to do though. Perhaps something to take care of in
ano
Out of curiosity, jclouds-cli requires it?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/99#issuecomment-287560210
demobox commented on this pull request.
> @@ -516,32 +521,27 @@ limitations under the License.
-jclouds-compute
I'm not sure what our pattern is here - for other features, we seem to be
including _all_ transitive features, e.g.:
```
jclouds-compute
j
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-karaf/pull/99
-- Commit Summary --
* Add back the cloudsigma-api feature for backwards compatibility
-- File Changes --
M feature/src/main/feature/feature.xml (20)
-- Patch Links --
ht
13 matches
Mail list logo
