merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-karaf/commit/fa11dcfc)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92#issuecomment-287334268
Closed #92.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92#event-1004319668
cool. merging
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92#issuecomment-287333680
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92#pullrequestreview-27560135
Let's have this merged! :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92#issuecomment-287327566
thanks @neykov
I think this should be merged as it is there for too long :)
@nacx are you ok as well?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92#issuecomment-287322399
LGTM.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92#issuecomment-287320844
@nacx @neykov I think it is finally mergeable, let me know
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92#issuecomment-285647968
@andreaturli pushed 1 commit.
e4e1560 fix
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92/files/f91b3547c08076606386dc83086ebfa31eb99e5b..e4e156040f1785992c44ee74062ef03e268aab9e
@andreaturli pushed 1 commit.
f91b354 fix FeatureLabsInstallationTest
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@andreaturli pushed 1 commit.
a9f7814 add missing import
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92/files/f1b152a8abf6ab1b0557724377aa49cf071203d9..a9f7814772cb0edd1f66bfad1ce6835f7870a0f6
@andreaturli pushed 1 commit.
f1b152a use default karaf-maven-plugin in feature and feature-labs
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
andreaturli commented on this pull request.
> @@ -27,7 +27,6 @@
import org.jclouds.compute.domain.OsFamily;
import org.jclouds.compute.domain.TemplateBuilder;
import org.jclouds.compute.options.TemplateOptions;
-import org.jclouds.ec2.compute.options.EC2TemplateOptions;
Right but not sure
nacx commented on this pull request.
> @@ -27,7 +27,6 @@
import org.jclouds.compute.domain.OsFamily;
import org.jclouds.compute.domain.TemplateBuilder;
import org.jclouds.compute.options.TemplateOptions;
-import org.jclouds.ec2.compute.options.EC2TemplateOptions;
@andreaturli Looks like
@nacx any idea for this
https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/199/org.apache.jclouds.karaf$commands/console
?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@andreaturli pushed 1 commit.
b568383 enable FeatureInstallationTests
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@andreaturli pushed 1 commit.
9a27228 remove leftover obr resolver
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92/files/24dfa04f8de0ae596d2903f9b325beb383e49692..9a27228938eb5578d9949932cbe7e896ecab3ad0
andreaturli commented on this pull request.
> + featuresService.installFeature("jclouds-rackspace-cloudfiles-us");
+ }
+
+ @Test
+ public void testServerloveZ1ManFeature() throws Exception {
+ featuresService.installFeature("jclouds-serverlove-z1-man");
+ }
+
+ @Test
+
andreaturli commented on this pull request.
> +jclouds-cloudsigma2-hnl
+jclouds-cloudsigma2-lvs
+jclouds-cloudsigma2-sjc
+jclouds-cloudsigma2-wdc
+
andreaturli commented on this pull request.
> + featuresService.installFeature("jclouds-rackspace-cloudfiles-us");
+ }
+
+ @Test
+ public void testServerloveZ1ManFeature() throws Exception {
+ featuresService.installFeature("jclouds-serverlove-z1-man");
+ }
+
+ @Test
+
neykov commented on this pull request.
> + featuresService.installFeature("jclouds-rackspace-cloudfiles-us");
+ }
+
+ @Test
+ public void testServerloveZ1ManFeature() throws Exception {
+ featuresService.installFeature("jclouds-serverlove-z1-man");
+ }
+
+ @Test
+ public
andreaturli commented on this pull request.
> + featuresService.installFeature("jclouds-rackspace-cloudfiles-us");
+ }
+
+ @Test
+ public void testServerloveZ1ManFeature() throws Exception {
+ featuresService.installFeature("jclouds-serverlove-z1-man");
+ }
+
+ @Test
+
neykov approved this pull request.
All good - some minor cleanups noted.
> -
+
+jclouds-compute
+jclouds-api-sts
+
mvn:org.apache.jclouds.api/cloudwatch/${jclouds.version}
+
+
+
+jclouds-compute
+jclouds-driver-bouncycastle
+
@andreaturli pushed 1 commit.
24dfa04 revert jsch-agentproxy-jsch pom.xml
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
andreaturli commented on this pull request.
> @@ -82,7 +82,8 @@ limitations under the License.
-
${project.build.directory}/dependency-reduced-pom.xml
+
tested with that line reverted and it works as well. Can't remember
andreaturli commented on this pull request.
> @@ -52,38 +52,56 @@ limitations under the License.
mvn:org.apache.jclouds.api/atmos/${jclouds.version}
addressed this, @neykov thanks
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
nacx commented on this pull request.
> @@ -82,7 +82,8 @@ limitations under the License.
-
${project.build.directory}/dependency-reduced-pom.xml
+
Ping?
> @@ -110,7 +110,6 @@ limitations under the License.
@andreaturli pushed 3 commits.
ec4ee03 Update JSCH to version 0.1.54
0cf5d91 use netty.bundle.version
bf61829 rename itest package
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
>Re the Parametrized tests, I think it is a nice-to-have rather than a must,
>shall I use that feature in this PR?
No. Let's leave it as-is.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@nacx Renamed the package, sorry about that
Re the Parametrized tests, I think it is a nice-to-have rather than a must,
shall I use that feature in this PR?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@andreaturli pushed 1 commit.
471b49b fix ServiceTest
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92/files/dabeef16931f126001acaecc6a1eaafbab2aeb35..471b49bc095fe131b03d17e1c15f456903451e8a
@andreaturli pushed 2 commits.
c9d68a4 split feature-labs into a separate module
dabeef1 remove resolver=(obr) from features as not used
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
nacx commented on this pull request.
> +@RunWith(PaxExam.class)
+@ExamReactorStrategy(PerMethod.class)
+public class FeatureInstallationTest extends BasePaxExamTest {
+
+ @Inject
+ FeaturesService featuresService;
+
+ @Before
+ public void setUp() throws Exception {
+
The itests packages need to be renamed to `jclouds` instead of `brooklyn`.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92#issuecomment-281316108
andreaturli commented on this pull request.
> +@RunWith(PaxExam.class)
+@ExamReactorStrategy(PerMethod.class)
+public class FeatureInstallationTest extends BasePaxExamTest {
+
+ @Inject
+ FeaturesService featuresService;
+
+ @Before
+ public void setUp() throws Exception {
+
nacx requested changes on this pull request.
Epic PR @andreaturli!
> @@ -82,7 +82,8 @@ limitations under the License.
-
${project.build.directory}/dependency-reduced-pom.xml
+
Why has this been changed? We might need this
@nacx I think we had some issues with the builder, now the PR looks ok as it is
from my workstation. Can you please double-check before merging it?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #92.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92#event-964971751
Reopened #92.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92#event-964971783
Closed #92.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92#event-964796331
Reopened #92.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92#event-964796367
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/92#issuecomment-280300366
@andreaturli pushed 1 commit.
10ab107 remove old itests; rename modern-itests to itests
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
nacx commented on this pull request.
> jclouds-compute
-mvn:org.apache.jclouds.api/oauth/${jclouds.version}
-mvn:org.apache.jclouds.common/googlecloud/${jclouds.version}
-
mvn:org.apache.jclouds.provider/google-compute-engine/${jclouds.version}
+
andreaturli commented on this pull request.
> jclouds-compute
-mvn:org.apache.jclouds.api/oauth/${jclouds.version}
-mvn:org.apache.jclouds.common/googlecloud/${jclouds.version}
-
mvn:org.apache.jclouds.provider/google-compute-engine/${jclouds.version}
+
45 matches
Mail list logo
