demobox commented on this pull request.
> @@ -238,4 +240,12 @@ private static String
> getValueOrPropertyOrEnvironmentVariable(
}
return value;
}
+
+ private static String getCredentialValue(String provider, String
credential) {
+ return credential != null &&
nacx commented on this pull request.
> @@ -238,4 +240,12 @@ private static String
> getValueOrPropertyOrEnvironmentVariable(
}
return value;
}
+
+ private static String getCredentialValue(String provider, String
credential) {
+ return credential != null && isG
> Also: do we need to make any updates to other projects for this?
No, changes are transparent to other jclouds-karaf projects and the CLI.
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-
demobox commented on this pull request.
Thanks for the cleanup, @nacx! Also: do we need to make any updates to other
projects for this?
> @@ -238,4 +240,12 @@ private static String
> getValueOrPropertyOrEnvironmentVariable(
}
return value;
}
+
+ private static Strin
👍
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/88#issuecomment-262581547
This is the continuation of https://github.com/jclouds/jclouds-karaf/pull/87,
to properly encapsulate the Google Cloud credentials logic and reuse it in
compute and blob store.
/cc @demobox @andrewgaul
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds
