Re: [jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-08-06 Thread Andrea Turli
Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/d0b07a66) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/301#issuecomment-238022091

Re: [jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-08-06 Thread Andrea Turli
Closed #301. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/301#event-747433245

Re: [jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-08-06 Thread Andrea Turli
thx @ritazh merging it now --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/301#issuecomment-238021534

Re: [jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-08-01 Thread Rita Zhang
@andreaturli LGTM! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/301#issuecomment-236643545

Re: [jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-07-29 Thread Rita Zhang
@andreaturli this is awesome! I will test it soon. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/301#issuecomment-236297267

Re: [jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-07-14 Thread Ignasi Barrera
> @@ -132,6 +132,41 @@ void testVirtualMachine() { > } > > @Test > + void testAddStorageResourceWhenNameIsLongerThan24Chars() { > + String name = "thishasmorethan24characters"; > + DeploymentTemplateBuilder builder = > getMockDeploymentTemplateBuilderWithEmptyOptions(name);

Re: [jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-07-14 Thread Andrea Turli
@andreaturli pushed 1 commit. 1a2193f add unit test for storage account name generation --- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-07-13 Thread Ignasi Barrera
> @@ -487,4 +496,37 @@ private boolean keyVaultInUse(){ >return !Strings.isNullOrEmpty(options.getKeyVaultIdAndSecret()); > } > > + /** > +* Generates a valid storage account > +* > +* Storage account names must be between 3 and 24 characters in length > and may

[jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-07-13 Thread Andrea Turli
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/301 -- Commit Summary -- * [azure-arm] add controlled storage account name generation -- File Changes -- M