Closed #416.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/416#event-1408793861
Finally merged to
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/fa63f6b1)
and
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/50d71c8e).
Many thanks for this huge effort @jmspring!
--
You are receiving this because you are subscribed to this thread.
nacx approved this pull request.
Finally! Thanks for the huge effort @jmspring! LGTM. Could you squash the
changes and rebase the branch for a clean merge?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@jmspring pushed 1 commit.
8f3744b syntax fixes
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/416/files/c9f871301c2d6b123d4c58f5ddde1354a10e5119..8f3744b33e4f474cca9037dff2a556e6ee410c82
@nacx See my note in Slack re: Predicate factories. Here are the test results:
```
---
T E S T S
---
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m;
support was
@jmspring pushed 1 commit.
c9f8713 changes based off of PR feedback
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/416/files/fd8c5fc24a283dba3f1ed0884ad89234bb6a1cd8..c9f871301c2d6b123d4c58f5ddde1354a10e5119
nacx commented on this pull request.
Many thanks for this huge effort!
I've commented mostly style things. Excellent job!
> +}
+
+@Provides
+protected Predicate
provideResourceAvailablePredicate(final AzureComputeApi api,
+
@nacx - all the requested changes should be in
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/416#issuecomment-352896792
@jmspring pushed 1 commit.
fd8c5fc refactor azure predicates
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/416/files/1d48e0fe42abbe2ed7b630c376d66806665921d5..fd8c5fc24a283dba3f1ed0884ad89234bb6a1cd8
@jmspring pushed 1 commit.
1d48e0f add request body check to mock tests, improve stability of live test
ordering
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@jmspring pushed 1 commit.
fd2c2e1 use predicates for wait
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/416/files/3dcf25eb34f2965e1301de0ef5dbb54574f2ffd4..fd2c2e191d00d35ef3f7222497e8bf8807fd40f5
@jmspring pushed 2 commits.
77b0e00 first part of PR request feedback
3dcf25e PR feedback, part 2
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
nacx commented on this pull request.
Many thanks @jmspring!
This looks quite good! I've added some general comments. Apart from those,
could you paste the summary of the live tests results?
> @@ -53,6 +53,33 @@ Verify service principal
az login -u -p --service-principal --tenant
```
nacx commented on this pull request.
> + @Fallback(NullOnNotFoundOr404.class)
+ @OAuthResource("https://vault.azure.net;)
+ DeletedKeyBundle deleteKey(@EndpointParam URI vaultBaseUrl,
@PathParam("keyName") String keyName);
+
+ @Named("key:get_versions")
+ @GET
+
@jmspring pushed 1 commit.
b3b1164 fix lint issues
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/416/files/5fdc2519bda0002ab366890c49be869e70e9663f..b3b1164b284996fbe50914f5bfe4b8dd2e9edc10
@jmspring pushed 1 commit.
5fdc251 don't use wildcard import
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/416/files/fb858b5491b912f696c7ab61216f3fb73eb6919d..5fdc2519bda0002ab366890c49be869e70e9663f
@jmspring pushed 1 commit.
fb858b5 integrate updated graphrbac api
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/416/files/be61d50fe8b6561a2dc638b753cffc2fe3a95102..fb858b5491b912f696c7ab61216f3fb73eb6919d
@jmspring pushed 1 commit.
be61d50 Merge branch 'master' into feature/keyvault-crud
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@jmspring pushed 3 commits.
b994b6a crypto apis and live tests
bd9cbd7 add crypto mock tests
36e3c64 Merge pull request #2 from jmspring/feature/keyvault-crypto
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@jmspring pushed 1 commit.
74ecb1b modify how version handled for certs/keys/secrets
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@jmspring pushed 1 commit.
65d4099 support dynamic oauth
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/416/files/f43172e01c2f1b30f342d2742bf4ce31415f3927..65d40992ad85db95908653b339fb9aecdedbe7e9
@jmspring pushed 1 commit.
f43172e merge current head
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/416/files/8006a5a405cbadd82a217c0248c7e530d2a81ec4..f43172e01c2f1b30f342d2742bf4ce31415f3927
@jmspring pushed 1 commit.
8006a5a missing resource
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/416/files/3f94a9924e7c422f3b7afa0726afaaa4d6a4c8bb..8006a5a405cbadd82a217c0248c7e530d2a81ec4
@nacx - added Merge tests. Let me know when I should update PR to include
OAuth dynamic patch.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/416#issuecomment-347728489
@jmspring pushed 1 commit.
3f94a99 add merge mock tests
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/416/files/d477519731ec9a9b20e68f405e42a9163313b8d3..3f94a9924e7c422f3b7afa0726afaaa4d6a4c8bb
@jmspring pushed 1 commit.
d477519 make checkstyle happy
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/416/files/0d04b2be044b5111d641c015484942e2fabbf69e..d477519731ec9a9b20e68f405e42a9163313b8d3
@nacx - Most of the changes you requested are done. Where "Date" is specified
in the Azure KeyVault REST docs, I've used a Date type. In the case where it
is a "unix timestamp", I've gone with Integer.
Re: KeyVaultFilter - the issue is Vault URIs for OAuth verification differ from
the
@jmspring pushed 1 commit.
0d04b2b fix typo
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/416/files/578dd76f7b80e32b03812d14f4461562aa62c607..0d04b2be044b5111d641c015484942e2fabbf69e
@jmspring pushed 1 commit.
578dd76 use integers for unix time stamp fields, immutable lists and maps,
non-null collections
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@jmspring pushed 1 commit.
95ec187 remove TrueIf2xx; Null on 404 Fallback for Patch/Post/Put
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
nacx commented on this pull request.
Thanks @jmspring! Huge effort!
I'm adding some general comments after a first review, but I still have to go
in deeper detail through the entire PR again:
* In the model classes, enforce immutable lists.
* Also try to use non-null collections and enforce
@andreaturli - updates per your request. I hadn't caught those changes when
doing the PR. Probably the side affect of a refactor / reformat via IntelliJ.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@jmspring pushed 1 commit.
342965b updates based off comments from @andreaturli
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@jmspring pushed 2 commits.
59f8328 Fix build and checkstyle
ba42d3e Merge pull request #1 from nacx/fix-build
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
andreaturli requested changes on this pull request.
> @@ -212,7 +213,7 @@ NetworkSecurityRuleApi
> getNetworkSecurityRuleApi(@PathParam("resourcegroup") Str
ImageApi getVirtualMachineImageApi(@PathParam("resourcegroup") String
resourcegroup);
/**
-* The metrics API includes
This PR builds off the initial work done by @andreaturli. It implements the
following functionality:
- KeyVault management
- Certificate operations
- Key operations
- Secret operations
Currently, in "Key operations", two functions are there, but not tested:
- [Merge
36 matches
Mail list logo
