Merged to
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/eaeea5c3)
and
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/dab07d44).
Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on Git
Closed #425.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/425#event-1378864451
@nacx thanks for reviewing. Commits are squashed and pushed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/425#issuecomment-350240771
Thanks, @trevorflanagan! Just a couple minor final comments. Mind squashing the
commits directly when fixing those?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/425#issuecommen
nacx commented on this pull request.
> + public void testApplyTags() {
+ api().applyTags(SERVER_ID, assetType,
Collections.singletonList(TagInfo.create(tagKeyId, "jcloudsValue")));
+ }
+
+ @Test
+ public void testListTags() {
+ PagedIterable response = api().listTags();
+
nacx commented on this pull request.
> +public interface TagApi {
+
+ @Named("tag:createTagKey")
+ @POST
+ @Path("/createTagKey")
+ @Produces(MediaType.APPLICATION_JSON)
+ @MapBinder(BindToJsonPayload.class)
+ @ResponseParser(TagKeyId.class)
+ String createTagKey(@PayloadParam("nam
@trevorflanagan pushed 1 commit.
565dfa5 Adding the Dimension Data Tag API interface. Updates for PR.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/425/files/aab069263f3475b4f19d74a75b83507235ee1260..565dfa5
trevorflanagan commented on this pull request.
> + @MapBinder(BindToJsonPayload.class)
+ void applyTags(@PayloadParam("assetId") String assetId,
@PayloadParam("assetType") String assetType,
+ @PayloadParam("tagById") List tagById);
+
+ @Named("tag:removeTags")
+ @POST
+ @Path(
trevorflanagan commented on this pull request.
> +import java.util.List;
+
+@RequestFilters({ BasicAuthentication.class, OrganisationIdFilter.class })
+@Consumes(MediaType.APPLICATION_JSON)
+@Path("/{jclouds.api-version}/tag")
+public interface TagApi {
+
+ @Named("tag:createTagKey")
+ @POST
nacx commented on this pull request.
Thanks @trevorflanagan!
> +import java.util.List;
+
+@RequestFilters({ BasicAuthentication.class, OrganisationIdFilter.class })
+@Consumes(MediaType.APPLICATION_JSON)
+@Path("/{jclouds.api-version}/tag")
+public interface TagApi {
+
+ @Named("tag:createTagKe
trevorflanagan commented on this pull request.
> @@ -143,7 +143,7 @@ public void testDeleteTagKey() throws Exception {
@Test
public void testTagKeyById() throws Exception {
- server.enqueue(jsonResponse("/tagKey.json"));
+ server.enqueue(jsonResponse("/tagkey.json"));
caught
@trevorflanagan pushed 1 commit.
aab0692 Adding the Dimension Data Tag API interface.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/425/files/b5021dae177ec8f76f1ec76bab53498cacc1e466..aab069263f3475b4f19d74a
@trevorflanagan pushed 1 commit.
b5021da Adding the Dimension Data Tag API interface.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/425/files/e67b0018f713086d9e901b7c8b8bf6d11578a5a5..b5021dae177ec8f76f1ec76
This will be useful for supporting Groups and also for the functions that
create the subclasses of
`org.jclouds.compute.domain.internal.ComputeMetadataImpl#tags`
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/425
-- Commit Summary
14 matches
Mail list logo
