Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

Closed #421. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/421#event-1372266168

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/2b8bfcb8) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/8c1449bd). Thanks @trevorflanagan! -- You are receiving this because you are subscribed to this thread. Reply to this email directly

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

nacx approved this pull request. Thanks, @trevorflanagan! Mind squashing the commits into a single one for a clean merge? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/421#issuecomment-348116402

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

@trevorflanagan pushed 1 commit. 58366dd Correcting the types used in ComputeServiceAdapterContextModule. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

@nacx I have refactored OsImageToImage in order to handle OsImage and CustomerImage. This means that JClouds can expose all of our image types. I have also improved the version and os family handling to be more robust. -- You are receiving this because you are subscribed to this thread. Reply

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

@trevorflanagan pushed 1 commit. c3943ad Refactor OsImageToImage to instead use BaseImage. This allows for both OS Images and Customer Images to be used. Improved the version and os family logic to use the guest operating system information. -- You are receiving this because you are

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

Sure! :smile: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/421#issuecomment-347880602

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

Hi @nacx I would like to make some further changes for the PR. Since you are busy with the release I think it's safe to do so. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

nacx commented on this pull request. > + OsImageToImage(@Memoized final Supplier locations, + Function imageDescriptionToOsFamily) { + this.locations = locations; + this.imageDescriptionToOsFamily = imageDescriptionToOsFamily; + } + + @Override +

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

trevorflanagan commented on this pull request. > + OsImageToImage(@Memoized final Supplier locations, + Function imageDescriptionToOsFamily) { + this.locations = locations; + this.imageDescriptionToOsFamily = imageDescriptionToOsFamily; + } + +

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

nacx commented on this pull request. > + OsImageToImage(@Memoized final Supplier locations, + Function imageDescriptionToOsFamily) { + this.locations = locations; + this.imageDescriptionToOsFamily = imageDescriptionToOsFamily; + } + + @Override +

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

nacx commented on this pull request. > + OsImageToImage(@Memoized final Supplier locations, + Function imageDescriptionToOsFamily) { + this.locations = locations; + this.imageDescriptionToOsFamily = imageDescriptionToOsFamily; + } + + @Override +

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

trevorflanagan commented on this pull request. > + this.locations = locations; + this.imageDescriptionToOsFamily = imageDescriptionToOsFamily; + } + + @Override + public Image apply(OsImage input) { + + OsFamily osFamily =

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

trevorflanagan commented on this pull request. > + OsImageToImage(@Memoized final Supplier locations, + Function imageDescriptionToOsFamily) { + this.locations = locations; + this.imageDescriptionToOsFamily = imageDescriptionToOsFamily; + } + +

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

@nacx thanks for taking a look. I will make the required changes shortly. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/421#issuecomment-347442442

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

nacx commented on this pull request. Thanks for a small but important PR @trevorflanagan! > + private static final String REDHAT = "RedHat"; + private static final String UBUNTU = "Ubuntu"; + private static final String SUSE = "SuSE"; + private static final String WINDOWS = "Win"; + +

[jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

This PR shows the approach we will use for the next steps involved in creating the JCLouds abstraction now that the feature APIs are complete. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/421 -- Commit Summary -- * Implement