Merged to
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/172d6f34)
and
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/caf4c19a).
Thanks @trevorflanagan!
I had to remove [an unnecessary call to
Closed #422.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/422#event-1372130453
nacx commented on this pull request.
> + }
+ }
+
+ private void attemptDeleteNatRule(final String serverId, final NetworkApi
networkApi, final NatRule natRule) {
+ try {
+ if (natRule.state().isNormal()) {
+networkApi.deleteNatRule(natRule.id());
+ }
@trevorflanagan pushed 1 commit.
4b3a037 Implementing BaseImageToHardware and CleanupServer functions. PR
updates.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
trevorflanagan commented on this pull request.
> + String networkDomainId = server.networkInfo().networkDomainId();
+ final String internalIp =
server.networkInfo().primaryNic().privateIpv4();
+
+ // delete nat rules associated to the server, if any
+ final
nacx commented on this pull request.
> + String networkDomainId = server.networkInfo().networkDomainId();
+ final String internalIp =
server.networkInfo().primaryNic().privateIpv4();
+
+ // delete nat rules associated to the server, if any
+ final NetworkApi
@trevorflanagan pushed 1 commit.
9d78555 Implementing BaseImageToHardware and CleanupServer functions. PR
updates.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@trevorflanagan pushed 1 commit.
f04c95d Implementing BaseImageToHardware and CleanupServer functions. PR
updates.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
trevorflanagan commented on this pull request.
> + String networkDomainId = server.networkInfo().networkDomainId();
+ final String internalIp =
server.networkInfo().primaryNic().privateIpv4();
+
+ // delete nat rules associated to the server, if any
+ final
trevorflanagan commented on this pull request.
> + }
+
+ @Override
+ public Boolean apply(final String serverId) {
+ final ServerApi serverApi = api.getServerApi();
+ Server server = serverApi.getServer(serverId);
+
+ if (server == null) {
+ return true;
+ }
+
nacx commented on this pull request.
Thanks, @trevorflanagan! Just some minor comments!
> +import static java.lang.String.format;
+import static
org.jclouds.dimensiondata.cloudcontrol.utils.DimensionDataCloudControlResponseUtils.generateFirewallRuleName;
+import static
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/422
-- Commit Summary --
* Implementing BaseImageToHardware and CleanupServer functions.
-- File Changes --
A
12 matches
Mail list logo
