cool! thanks @nacx
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/359#issuecomment-283293868
Closed #359.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/359#event-981537336
Squashed and pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/cd48a2eb)
and
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/40050076).
Thanks for having a loog @neykov @andreaturli!
--
You are receiving this because you are subscribed to this th
Oops, I build locally the "classic" Azure provider! It's fixed now. The
ImageCacheSupplier is intentionally not marked as "injectable", to avoid people
relying on internal classes. It is safe to inject the image supplier and check
its type.
--
You are receiving this because you are subscribed
@nacx pushed 1 commit.
7886391 Fix injextion
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/359/files/2514a901352e0c5342bfc355ad316b0f61678467..7886391fa12941d25b1cfc3c7a02643263726a89
@nacx looks like the failures are valid
https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/1694/org.apache.jclouds.labs$azurecompute-arm/testReport/junit/org.jclouds.azurecompute.arm.features/SubnetApiMockTest/start/
can you fix them so that we can merge it?
--
You are receiving th
+1 looks like a desired improvement.
not yet tested though
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/359#issuecomment-283057345
Thanks @neykov! I've applied the change. The ImageCache already provides [a
method](https://github.com/jclouds/jclouds/blob/master/compute/src/main/java/org/jclouds/compute/suppliers/ImageCacheSupplier.java#L152-L165)
to do that, so it's been easy. That method directly uses the underlying cache,
LGTM. Could still use the image cache and fall back to `getImage` only if empty.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/359#issuecomment-282737375
@nacx pushed 1 commit.
7294a8a Fix cyclic dependency and checkstyle
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/359/files/b28000ed4938761859800d3ebd3e5af9c3a9d018..7294a8a2ca71c6dedefd146a9fd65b8771c06609
Listing images in azure is **very** expensive, as it needs to list the
publishers, offers, SKUs and versions.
The function that transforms a VM to the jclouds Node, uses a cached image map
(populated with the contents of the image cache) to get the details of the
image corresponding to the node
11 matches
Mail list logo
