Re: [jclouds/jclouds-labs] JCLOUD-72 / JCLOUD-75 - DatacenterToLocation / ServerToServerWithExternalIp Functions (#423)

2017-11-30 Thread Ignasi Barrera
>BTW @nacx I saw the comments on the site PR regarding the slack channel. Would >it be possible to invite @btrishkin and I? Sure. Send mean email with your emails and I'll send the invites. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [jclouds/jclouds-labs] JCLOUD-72 / JCLOUD-75 - DatacenterToLocation / ServerToServerWithExternalIp Functions (#423)

2017-11-30 Thread Andrea Turli
andreaturli requested changes on this pull request. thanks for the great start @btrishkin Some initial thoughts on you PR, could you please have a look at them? > +import org.testng.annotations.BeforeTest; +import org.testng.annotations.Test; + +import java.util.ArrayList; +import

Re: [jclouds/jclouds-labs] JCLOUD-72 / JCLOUD-75 - DatacenterToLocation / ServerToServerWithExternalIp Functions (#423)

2017-11-30 Thread Andrea Turli
Sorry @trevorflanagan and @btrishkin for the confusion around ICLA -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/423#issuecomment-348237647

Re: [jclouds/jclouds-labs] JCLOUD-72 / JCLOUD-75 - DatacenterToLocation / ServerToServerWithExternalIp Functions (#423)

2017-11-30 Thread Andrea Turli
@btrishkin I'm not sure I understand the title of this PR: you mention https://issues.apache.org/jira/browse/JCLOUDS-72 and https://issues.apache.org/jira/browse/JCLOUDS-75 but they are not related to dimensiondata, are they? Please to simplify the review, could you open a jira issue and

Re: [jclouds/jclouds-labs] JCLOUD-72 / JCLOUD-75 - DatacenterToLocation / ServerToServerWithExternalIp Functions (#423)

2017-11-30 Thread Trevor Flanagan
BTW @nacx I saw the comments on the site PR regarding the slack channel. Would it be possible to invite @btrishkin and I? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] JCLOUD-72 / JCLOUD-75 - DatacenterToLocation / ServerToServerWithExternalIp Functions (#423)

2017-11-30 Thread Andrea Turli
thanks @btrishkin for your contribution. First of all, welcome to the jclouds community! I may have missed that, but did you sign already the ICLA? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] JCLOUD-72 / JCLOUD-75 - DatacenterToLocation / ServerToServerWithExternalIp Functions (#423)

2017-11-30 Thread Ignasi Barrera
I think it was a small confusion. ICLAs are not required for Apache contributors, only for committers. Contributors must just assume and accept (and sending a patch or opening a PR means that, that's why you copy our license headers too) that their contributions are meant to be distributed

Re: [jclouds/jclouds-labs] JCLOUD-72 / JCLOUD-75 - DatacenterToLocation / ServerToServerWithExternalIp Functions (#423)

2017-11-30 Thread Trevor Flanagan
hey @andreaturli we were not aware of the requirement to sign an ICLA. We will have to check internally to see if Dimension Data have a process in place already for this. BTW I have not signed one either. -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [jclouds/jclouds-labs] JCLOUD-72 / JCLOUD-75 - DatacenterToLocation / ServerToServerWithExternalIp Functions (#423)

2017-11-30 Thread Andrea Turli
thanks @btrishkin for your contribution. First of all, welcome to the jclouds community! I may have missed that, but did you sign already the ICLA? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[jclouds/jclouds-labs] JCLOUD-72 / JCLOUD-75 - DatacenterToLocation / ServerToServerWithExternalIp Functions (#423)

2017-11-30 Thread Boris Trishkin
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/423 -- Commit Summary -- * JCLOUD-72 / JCLOUD-75 - Implement DatacenterToLocation / ServerToServerWithExternalIp Functions -- File Changes -- A