Pushed to master and 2.0.x!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/347#issuecomment-275522943
Closed #347.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/347#event-938492541
+1 @nacx, please merge it!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/347#issuecomment-275449554
@nacx pushed 1 commit.
c33fa42 Address review comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/347/files/fb0c94c81e18e743ad53305663d4cc17e0e4672a..c33fa42fa3a1e7f4a9f04ea6fbe4e06a513046b8
nacx commented on this pull request.
> + AzureComputeSecurityGroupExtension(AzureComputeApi api, @Memoized
> Supplier> locations,
+ Function groupConverter,
+ SecurityGroupAvailablePredicateFactory securityRuleAvailable,
+ @Named(TIMEOUT_RESOURCE_DELETED) Predicate res
andreaturli commented on this pull request.
lgtm, some minor comments
> @@ -114,7 +103,7 @@ public static Properties defaultProperties() {
properties.put(API_VERSION_PREFIX +
PublicIPAddressApi.class.getSimpleName(), "2015-06-15");
properties.put(API_VERSION_PREFIX +
ResourceGroup
@nacx pushed 1 commit.
fb0c94c Return null if security group does not exist
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/347/files/d96b0d6e3b4f3da51148c6db5cc363740c6db00e..fb0c94c81e18e743ad53305663d4cc17e
@nacx pushed 1 commit.
d96b0d6 Reduce the number of API calls in the security group extension
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/347/files/a0f45c25d613ea54eb5fb6f8d208148e9daa3269..d96b0d6e3b4f3da
@andreaturli I've just added all the mentioned code cleanup and introduced the
resource group cache. Please have a look.
All extension live tests are green. I'll run the compute service adapter ones
in a while.
```bash
Starting test
testCreateSecurityGroup(org.jclouds.azurecompute.arm.compute.
@nacx pushed 1 commit.
a0f45c2 Cleanup legacy code and introduce the resource group cache
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/347/files/4ad4216899069216d34e072a310cd4a194a7aa96..a0f45c25d613ea54eb5
https://issues.apache.org/jira/browse/JCLOUDS-1231
This implements the SecurityGroupExtension and adds support for the
`TemplateOptions.inboundPorts` feature. There is also some minor refactoring in
the cleanup classes, to make it more reusable and to minimize the number of
times the code is ex
11 matches
Mail list logo
