Closed #446.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/446#event-1914224442
Squashed and merged to
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/85c46b82)
and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/f7b8c2ca).
Thx!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
@trevorflanagan pushed 1 commit.
315b896 JCLOUDS-1431 - Support AU geo for Live Tests.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
trevorflanagan commented on this pull request.
>assertNotNull(cloneImageId);
assertTrue(serverNormalPredicate.apply(serverId), "server was not NORMAL
after timeout");
}
+ @Test(dependsOnMethods = "testCloneServerToMakeCustomerImage")
+ public void
trevorflanagan commented on this pull request.
> +import org.jclouds.rest.annotations.Fallback;
+import org.jclouds.rest.annotations.MapBinder;
+import org.jclouds.rest.annotations.PayloadParam;
+import org.jclouds.rest.annotations.RequestFilters;
+import
nacx commented on this pull request.
>assertNotNull(cloneImageId);
assertTrue(serverNormalPredicate.apply(serverId), "server was not NORMAL
after timeout");
}
+ @Test(dependsOnMethods = "testCloneServerToMakeCustomerImage")
+ public void testListCustomerImages() {
+
nacx commented on this pull request.
> +import org.jclouds.rest.annotations.Fallback;
+import org.jclouds.rest.annotations.MapBinder;
+import org.jclouds.rest.annotations.PayloadParam;
+import org.jclouds.rest.annotations.RequestFilters;
+import org.jclouds.rest.binders.BindToJsonPayload;
+
Commits squashed in advance merge.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/446#issuecomment-431126798
I have re-based onto master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/446#issuecomment-431126111
trevorflanagan commented on this pull request.
> +import javax.ws.rs.Path;
+import javax.ws.rs.Produces;
+import javax.ws.rs.core.MediaType;
+
+@RequestFilters({ BasicAuthentication.class, OrganisationIdFilter.class })
+@Consumes(MediaType.APPLICATION_JSON)
+@Path("/caas/2.7/image")
+public
trevorflanagan commented on this pull request.
>assertNotNull(cloneImageId);
assertTrue(serverNormalPredicate.apply(serverId), "server was not NORMAL
after timeout");
}
+ @Test(dependsOnMethods = "testCloneServerToMakeCustomerImage")
+ public void
trevorflanagan commented on this pull request.
> @@ -89,8 +89,17 @@ public void setUp() {
datacenters = getZones();
}
+ // private Set getZones() {
+ // return
ctx.utils().injector().getInstance(ZoneIdsSupplier.class).get();
+ // }
+
+ // TODO this leads to a
nacx approved this pull request.
Just a couple minors. Will merge once addressed.
> +import javax.ws.rs.Path;
+import javax.ws.rs.Produces;
+import javax.ws.rs.core.MediaType;
+
+@RequestFilters({ BasicAuthentication.class, OrganisationIdFilter.class })
+@Consumes(MediaType.APPLICATION_JSON)
rebuild please
appears to be a failure unrelated to my changes on jenkins
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/446#issuecomment-427003272
trevorflanagan commented on this pull request.
> @@ -54,7 +54,7 @@ protected Builder() {
id("dimensiondata-cloudcontrol").name("DimensionData CloudControl
API").identityName("user name")
.credentialName("user password")
trevorflanagan commented on this pull request.
> }
- private void applyTagToAsset() {
I am doing this test in the ServerApiLiveTest now
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
trevorflanagan commented on this pull request.
> @@ -89,8 +89,17 @@ public void setUp() {
datacenters = getZones();
}
+ // private Set getZones() {
+ // return
ctx.utils().injector().getInstance(ZoneIdsSupplier.class).get();
+ // }
+
+ // TODO this leads to a
trevorflanagan commented on this pull request.
> @@ -45,4 +46,7 @@
@Delegate
TagApi getTagApi();
+
+ @Delegate
+ CustomerImageApi getCustomerImageApi();
A new API added as part of this so that we can delete the image we create when
we test the clone api.
--
You are receiving
://github.com/jclouds/jclouds-labs/pull/446
-- Commit Summary --
* JCLOUDS-1431 - Support AU geo for Live Tests
* JCLOUDS-1431 - Support AU geo for Live Tests
* JCLOUDS-1431 - Support AU geo for Live Tests
* JCLOUDS-1431 - Support AU geo for Live Tests
-- File Changes --
M
dimensiondata/src
19 matches
Mail list logo
