Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)

2018-02-20 Thread Ali Bazlamit
@alibazlamit pushed 1 commit. 3ebda7e test fix -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/431/files/536b9a976929ab3aad39b5756aec955d6f299f16..3ebda7edf3007ba25dfa23c3cf926cbdc2573b71

Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)

2018-02-20 Thread Ali Bazlamit
@alibazlamit pushed 1 commit. 536b9a9 Add baremetal logic to ComputeServiceAdapter -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)

2018-02-14 Thread Andrea Turli
Not familiar with the oneandone API but looks like `baremetal` is another servertype for server creation. If this is correct, then we could either introduce a OneAndOneTemplateOption for serverType or try to infer it from hardwareProfiles if this additional flag is available. Makes sense? --

Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)

2018-02-14 Thread Ali Bazlamit
I am sorry for the confusion, but there was a question in my previous comment, something that i would like to add to the PR before we merge it. Could you please take a look at it and let me know if you can maybe point me towards a solution. Thanks -- You are receiving this because you are

Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)

2018-02-14 Thread Andrea Turli
Thanks @alibazlamit for the summary. Would you mind to copy that into a jira issue as described at point 2 at https://cwiki.apache.org/confluence/display/JCLOUDS/How+to+Contribute Ideally you can rename the PR using the jira issue I'd. That would hugely help us to manage the project.Thanks --

Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)

2018-02-14 Thread Ali Bazlamit
@andreaturli one main feature that this PR is introducing is the Bare-metal Servers, now i have implemented that as a feature but it is not integrated with the compute API. Basically there is a new property introduced `server_type` which defaults to `cloud` or could be `baremetal`, do you have

Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)

2018-02-14 Thread Andrea Turli
thanks @alibazlamit could you please open a jira issue that describes the rationale for this PR? Thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/431#issuecomment-365676093

Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)

2018-02-14 Thread Ali Bazlamit
Compute test results : https://gist.github.com/alibazlamit/fab05a5e3235be8202f34c627d8bdc65 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/431#issuecomment-365646226

[jclouds/jclouds-labs] Oneandone baremetal update (#431)

2018-02-14 Thread Ali Bazlamit
This PR holds the latest updates in the 1&1 API You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/431 -- Commit Summary -- * Baremetal update * updates * Baremetal update -- File Changes -- M